From: Priyanka Dhanda <pdhanda@users.mediawiki.org>
Date: Thu, 14 Oct 2010 17:56:52 +0000 (+0000)
Subject: Cleanup of SimpleSeleniumTestCase. Removed unnecessary include.
X-Git-Tag: 1.31.0-rc.0~34503
X-Git-Url: http://git.cyclocoop.org/data/%7B%24admin_url%7Dconfig?a=commitdiff_plain;h=600d880fb782d94058381b2f683739f2f047e570;p=lhc%2Fweb%2Fwiklou.git

Cleanup of SimpleSeleniumTestCase. Removed unnecessary include.
---

diff --git a/maintenance/tests/selenium/SimpleSeleniumConfig.php b/maintenance/tests/selenium/SimpleSeleniumConfig.php
index 48de1e25a0..cffa83c4ea 100644
--- a/maintenance/tests/selenium/SimpleSeleniumConfig.php
+++ b/maintenance/tests/selenium/SimpleSeleniumConfig.php
@@ -3,7 +3,7 @@ class SimpleSeleniumConfig {
 	
 	public static function getSettings(&$includeFiles, &$globalConfigs) {
 		$includes = array(
-			'skins/Chick.php'
+			//files that needed to be included would go here
 		);
 		$configs = array(
 			'wgDefaultSkin' => 'chick'
diff --git a/maintenance/tests/selenium/SimpleSeleniumTestCase.php b/maintenance/tests/selenium/SimpleSeleniumTestCase.php
index 8f27dcd360..8f01b43791 100644
--- a/maintenance/tests/selenium/SimpleSeleniumTestCase.php
+++ b/maintenance/tests/selenium/SimpleSeleniumTestCase.php
@@ -17,6 +17,10 @@ class SimpleSeleniumTestCase extends SeleniumTestCase {
 		$this->assertEquals( $correct, true );
 	}
 	
+	/*
+	 * All this test really does is verify that a global var was set.
+	 * It depends on $wgDefaultSkin = 'chick'; being set
+	 */
 	public function testGlobalVariableForDefaultSkin() {
 		$this->open( $this->getUrl() . '/index.php?&action=purge' );
 		$bodyClass = $this->getAttribute( "//body/@class" );
diff --git a/maintenance/tests/selenium/SimpleSeleniumTestSuite.php b/maintenance/tests/selenium/SimpleSeleniumTestSuite.php
index cf3293766e..49a06d4618 100644
--- a/maintenance/tests/selenium/SimpleSeleniumTestSuite.php
+++ b/maintenance/tests/selenium/SimpleSeleniumTestSuite.php
@@ -7,7 +7,6 @@
  * $wgSeleniumTestConfigs['SimpleSeleniumTestSuite'] = 'SimpleSeleniumConfig::getSettings';
  * OR
  * 2) Add the following to your Localsettings.php
- * require_once( "$IP/skins/Chick.php" );
  * $wgDefaultSkin = 'chick';
  */
 class SimpleSeleniumTestSuite extends SeleniumTestSuite