dépôts
/
lhc
/
web
/
wiklou.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2a17686
)
registration: Don't array_unique() over the queue before loading it
author
Kunal Mehta
<legoktm@gmail.com>
Tue, 19 May 2015 05:30:37 +0000
(22:30 -0700)
committer
Kunal Mehta
<legoktm@gmail.com>
Tue, 19 May 2015 05:30:37 +0000
(22:30 -0700)
array_unique works over values, not keys (you can't have an array with
duplicate keys in PHP) so it would end up removing extensions that
happened to have an identical timestamp with another one.
Bug: T98956
Change-Id: I66e202ea882ae4d5cb1bcafb7882cbd9cd52a1b3
includes/registration/ExtensionRegistry.php
patch
|
blob
|
history
diff --git
a/includes/registration/ExtensionRegistry.php
b/includes/registration/ExtensionRegistry.php
index
d938f07
..
4836275
100644
(file)
--- a/
includes/registration/ExtensionRegistry.php
+++ b/
includes/registration/ExtensionRegistry.php
@@
-90,8
+90,6
@@
class ExtensionRegistry {
return;
}
- $this->queued = array_unique( $this->queued );
-
// See if this queue is in APC
$key = wfMemcKey( 'registration', md5( json_encode( $this->queued ) ) );
$data = $this->cache->get( $key );