From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Fri, 10 May 2019 13:23:20 +0000 (+0200)
Subject: Remove unused title parameter from EditPage::getEditToolbar()
X-Git-Tag: 1.34.0-rc.0~1724^2
X-Git-Url: http://git.cyclocoop.org/data/%27%20.%20mediabox_timestamp%28find_in_path%28%27javascript/%7B%24www_url%7Dadmin/compta/operations/%40%20%27info_etape_suivante_2%27%20=%3E%20%27You%20can%20move%20on%20to%20the%20next%20step.%27%2C%20%27info_exceptions_proxy%27%20=%3E%20%27Exceptions%20for%20the%20proxy%27%2C%20%27info_exportation_base%27%20=%3E%20%27export%20database%20to%20%40archive%40%27%2C-%27info_facilite_suivi_activite%27%20=%3E%20%27To%20simplify%20monitoring%20of%20the%20site/%27s%20editorial;-%20%20activities%2C%20SPIP%20can%20send%20rmail%20notifications%2C%20e.g.%20to%20an%20editors/%27.%28%24current%20%3E%202?a=commitdiff_plain;h=b4115ca9cf550c2e38dc0ef555f2f87d9d596453;p=lhc%2Fweb%2Fwiklou.git

Remove unused title parameter from EditPage::getEditToolbar()

No code uses this parameter:
https://codesearch.wmflabs.org/search/?q=getEditToolbar
I suggest to skip any deprecation because of this.

It might be worth mentioning this in the release notes anyway, or is
it?

Change-Id: I5d47c22fa741df5f9c248e4e1bff2d6e97aca6a7
---

diff --git a/includes/EditPage.php b/includes/EditPage.php
index 2d5b9e20b5..edc1cbeb07 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -2934,7 +2934,7 @@ ERROR;
 		}
 
 		if ( !$this->mTitle->isUserConfigPage() ) {
-			$out->addHTML( self::getEditToolbar( $this->mTitle ) );
+			$out->addHTML( self::getEditToolbar() );
 		}
 
 		if ( $this->blankArticle ) {
@@ -4101,10 +4101,9 @@ ERROR;
 	/**
 	 * Allow extensions to provide a toolbar.
 	 *
-	 * @param Title|null $title Title object for the page being edited (optional)
 	 * @return string|null
 	 */
-	public static function getEditToolbar( $title = null ) {
+	public static function getEditToolbar() {
 		$startingToolbar = '<div id="toolbar"></div>';
 		$toolbar = $startingToolbar;