From eff3affe3a3b6b1b39923cccee1eaff849450b96 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Tue, 28 Jun 2005 16:35:16 +0000 Subject: [PATCH] * (bug 2576) Fix recording of transclusion links Somehow we ended up with two copies of the same stuff in there, and they stomped up the tables. --- RELEASE-NOTES | 1 + includes/Article.php | 15 +-------------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index a355280f96..46eeade7b2 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -400,6 +400,7 @@ Various bugfixes, small features, and a few experimental things: * (bug 2560) Don't show blank width/height attributes for missing size * Don't show bogus messages about watchlist notifications when disabled * Don't show old debug messages in watchlist +* (bug 2576) Fix recording of transclusion links === Caveats === diff --git a/includes/Article.php b/includes/Article.php index 9b000a30c6..cd22c09cdb 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -1210,20 +1210,7 @@ class Article { $wgLinkCache->clear(); } } - # Parse the text and replace links with placeholders - # Do this outside the locks on the links table - # The existence test queries need to be FOR UPDATE - #$oldUpdate = $wgParser->forUpdate( true ); - $wgOut = new OutputPage(); - $wgOut->addWikiTextWithTitle( $text, $this->mTitle ); - - # Select for update - $wgLinkCache->forUpdate( true ); - - # Get old version of link table to allow incremental link updates - $wgLinkCache->preFill( $this->mTitle ); - $wgLinkCache->clear(); - + # Parse the text and replace links with placeholders $wgOut = new OutputPage(); -- 2.20.1