From 7a8cace5fd7cba47c08c855c8a56f5148a67340a Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Fri, 8 Feb 2019 16:53:48 -0800 Subject: [PATCH] mediawiki.language: Deprecate mw.language.specialCharacters Use require( 'mediawiki.language.specialCharacters' ) instead. Remove mw.language.setSpecialCharacters(), because it was only used by the specialCharacters module. There already was no getter. Depends-On: I9cf525a1e1aadc12d72284d08b98882b0ab95f5e Depends-On: I74e706a6603bd8fa899193de91e49f246608c4c1 Change-Id: I02e0e84b79309caa314954925cc9c0c2874b9bde --- RELEASE-NOTES-1.33 | 3 +++ resources/src/mediawiki.language/mediawiki.language.js | 4 ---- .../mediawiki.language.specialCharacters.js | 6 +++++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33 index b2de154347..094a3ce266 100644 --- a/RELEASE-NOTES-1.33 +++ b/RELEASE-NOTES-1.33 @@ -277,6 +277,9 @@ because of Phabricator reports. use the new extension registration key 'QUnitTestModule'. * (T213426) The jquery.throttle-debounce module has been deprecated. JavaScript code that needs this behaviour should use OO.ui.debounce/throttle. +* The mw.language.specialCharacters property from the + 'mediawiki.language.specialCharacters' module has been deprecated. + Use require( 'mediawiki.language.specialCharacters' ) instead. === Other changes in 1.33 === * (T208871) The hard-coded Google search form on the database error page was diff --git a/resources/src/mediawiki.language/mediawiki.language.js b/resources/src/mediawiki.language/mediawiki.language.js index 8fed6954f5..277034b92d 100644 --- a/resources/src/mediawiki.language/mediawiki.language.js +++ b/resources/src/mediawiki.language/mediawiki.language.js @@ -158,10 +158,6 @@ return text; }, - setSpecialCharacters: function ( data ) { - this.specialCharacters = data; - }, - /** * Formats language tags according the BCP 47 standard. * See LanguageCode::bcp47 for the PHP implementation. diff --git a/resources/src/mediawiki.language/mediawiki.language.specialCharacters.js b/resources/src/mediawiki.language/mediawiki.language.specialCharacters.js index ba8a233aab..6674adb412 100644 --- a/resources/src/mediawiki.language/mediawiki.language.specialCharacters.js +++ b/resources/src/mediawiki.language/mediawiki.language.specialCharacters.js @@ -1,5 +1,9 @@ ( function () { var specialCharacters = require( './specialcharacters.json' ); - mw.language.setSpecialCharacters( specialCharacters ); + // Deprecated since 1.33 + mw.log.deprecate( mw.language, 'specialCharacters', specialCharacters, + 'Use require( \'mediawiki.language.specialCharacters\' ) instead', + 'mw.language.specialCharacters' + ); module.exports = specialCharacters; }() ); -- 2.20.1