From 667ef8fa62c23078c729d1577954e277c9a8835f Mon Sep 17 00:00:00 2001 From: Elliott Eggleston Date: Wed, 27 Feb 2019 10:48:58 -0500 Subject: [PATCH] Fix warning on QUnit modules without dependencies Check if $module['dependencies'] is set before checking whether it's a string. Change-Id: I9ece83d4ec92d0d3a41a1c6863492e646f011eab --- includes/resourceloader/ResourceLoader.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php index 415808212d..3d1335049b 100644 --- a/includes/resourceloader/ResourceLoader.php +++ b/includes/resourceloader/ResourceLoader.php @@ -424,7 +424,7 @@ class ResourceLoader implements LoggerAwareInterface { // Add the QUnit testrunner as implicit dependency to extension test suites. foreach ( $testModules['qunit'] as &$module ) { // Shuck any single-module dependency as an array - if ( is_string( $module['dependencies'] ) ) { + if ( isset( $module['dependencies'] ) && is_string( $module['dependencies'] ) ) { $module['dependencies'] = [ $module['dependencies'] ]; } -- 2.20.1