From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 13 Oct 2008 06:02:32 +0000 (+0000)
Subject: Don't use vague boolean
X-Git-Tag: 1.31.0-rc.0~44768
X-Git-Url: http://git.cyclocoop.org/data/%24self?a=commitdiff_plain;h=ee07baa6c361d148029aefe48d1d47c5cb677674;p=lhc%2Fweb%2Fwiklou.git

Don't use vague boolean
---

diff --git a/includes/Article.php b/includes/Article.php
index 159ce7b7e7..a71f1a9e08 100644
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -1593,8 +1593,8 @@ class Article {
 			}
 
 			# Invalidate cache of this article and all pages using this article
-			# as a template. Partly deferred.
-			Article::onArticleEdit( $this->mTitle, false ); // leave templatelinks for editUpdates()
+			# as a template. Partly deferred. Leave templatelinks for editUpdates().
+			Article::onArticleEdit( $this->mTitle, 'skiptransclusions' );
 			# Update links tables, site stats, etc.
 			$this->editUpdates( $text, $summary, $isminor, $now, $revisionId, $changed );
 		} else {
@@ -3239,11 +3239,11 @@ class Article {
 	/**
 	 * Purge caches on page update etc
 	 */
-	public static function onArticleEdit( $title, $touchTemplates = true ) {
+	public static function onArticleEdit( $title, $transclusions = 'transclusions' ) {
 		global $wgDeferredUpdateList, $wgUseFileCache;
 
 		// Invalidate caches of articles which include this page
-		if( $touchTemplates )
+		if( $transclusions !== 'skiptransclusions' )
 			$wgDeferredUpdateList[] = new HTMLCacheUpdate( $title, 'templatelinks' );
 
 		// Invalidate the caches of all pages which redirect here
diff --git a/includes/Import.php b/includes/Import.php
index b8db93435f..7bd44fae4f 100644
--- a/includes/Import.php
+++ b/includes/Import.php
@@ -219,7 +219,7 @@ class WikiRevision {
 
 		} elseif( $changed ) {
 			wfDebug( __METHOD__ . ": running onArticleEdit\n" );
-			Article::onArticleEdit( $this->title, false ); // leave templatelinks for editUpdates()
+			Article::onArticleEdit( $this->title, 'skiptransclusions' ); // leave templatelinks for editUpdates()
 
 			wfDebug( __METHOD__ . ": running edit updates\n" );
 			$article->editUpdates(