From: Kunal Mehta <legoktm@gmail.com>
Date: Sun, 15 Mar 2015 02:41:55 +0000 (-0700)
Subject: Remove FormSpecialPage::$fields
X-Git-Tag: 1.31.0-rc.0~12044
X-Git-Url: http://git.cyclocoop.org/data/%24self?a=commitdiff_plain;h=a693c7222c358e473c3d51a4989fd28ee356c5b1;p=lhc%2Fweb%2Fwiklou.git

Remove FormSpecialPage::$fields

Just use the result of FormSpecialPage::getFormFields() directly

Change-Id: I2f6f8e20b83a24e744ab4c6ea5417d9627a3e0aa
---

diff --git a/includes/specialpage/FormSpecialPage.php b/includes/specialpage/FormSpecialPage.php
index 21e465a62e..90567617fa 100644
--- a/includes/specialpage/FormSpecialPage.php
+++ b/includes/specialpage/FormSpecialPage.php
@@ -89,11 +89,9 @@ abstract class FormSpecialPage extends SpecialPage {
 	 * @return HTMLForm|null
 	 */
 	protected function getForm() {
-		$this->fields = $this->getFormFields();
-
 		$form = HTMLForm::factory(
 			$this->getDisplayFormat(),
-			$this->fields,
+			$this->getFormFields(),
 			$this->getContext(),
 			$this->getMessagePrefix()
 		);