From: Reedy <reedy@wikimedia.org>
Date: Sat, 26 Sep 2015 17:04:00 +0000 (+0100)
Subject: Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect
X-Git-Tag: 1.31.0-rc.0~9790^2
X-Git-Url: http://git.cyclocoop.org/data/%24self?a=commitdiff_plain;h=8882634112e45466cc6fcebb1be3d788b2afbf78;p=lhc%2Fweb%2Fwiklou.git

Re-enable MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect

Change-Id: I1b756909a1080108c5147d46950f826871ef6dc1
---

diff --git a/includes/HttpFunctions.php b/includes/HttpFunctions.php
index 5d46b5e3d9..ad5aeb3edc 100644
--- a/includes/HttpFunctions.php
+++ b/includes/HttpFunctions.php
@@ -897,7 +897,7 @@ class PhpHttpRequest extends MWHttpRequest {
 			) );
 		}
 
-		foreach( $certLocations as $key => $cert ) {
+		foreach ( $certLocations as $key => $cert ) {
 			if ( is_dir( $cert ) ) {
 				$certOptions['capath'] = $cert;
 				break;
diff --git a/phpcs.xml b/phpcs.xml
index 8a28177316..7076f60017 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -6,7 +6,6 @@
 		<exclude name="PSR2.Methods.MethodDeclaration.Underscore"/>
 		<exclude name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix"/>
 		<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
-		<exclude name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect"/>
 		<exclude name="Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed"/>
 	</rule>
 	<file>.</file>
diff --git a/tests/phpunit/includes/libs/RunningStatTest.php b/tests/phpunit/includes/libs/RunningStatTest.php
index edfaf162c7..35a8e4ffac 100644
--- a/tests/phpunit/includes/libs/RunningStatTest.php
+++ b/tests/phpunit/includes/libs/RunningStatTest.php
@@ -23,7 +23,7 @@ class RunningStatTest extends PHPUnit_Framework_TestCase {
 	 */
 	public function testRunningStatAccuracy() {
 		$rstat = new RunningStat();
-		foreach( $this->points as $point ) {
+		foreach ( $this->points as $point ) {
 			$rstat->push( $point );
 		}
 
@@ -51,7 +51,7 @@ class RunningStatTest extends PHPUnit_Framework_TestCase {
 	public function testRunningStatMerge() {
 		$expected = new RunningStat();
 
-		foreach( $this->points as $point ) {
+		foreach ( $this->points as $point ) {
 			$expected->push( $point );
 		}
 
@@ -60,13 +60,13 @@ class RunningStatTest extends PHPUnit_Framework_TestCase {
 
 		// Accumulate the first half into one RunningStat object
 		$first = new RunningStat();
-		foreach( $sets[0] as $point ) {
+		foreach ( $sets[0] as $point ) {
 			$first->push( $point );
 		}
 
 		// Accumulate the second half into another RunningStat object
 		$second = new RunningStat();
-		foreach( $sets[1] as $point ) {
+		foreach ( $sets[1] as $point ) {
 			$second->push( $point );
 		}