From: Jesús Martínez Novo <martineznovo@gmail.com>
Date: Thu, 25 Aug 2016 14:07:57 +0000 (+0200)
Subject: Turn $wgRunJobsAsync off by default
X-Git-Tag: 1.31.0-rc.0~4523^2
X-Git-Url: http://git.cyclocoop.org/data/%24self?a=commitdiff_plain;h=1214a7cae94f2190065e3fd53083f79bcb94957d;p=lhc%2Fweb%2Fwiklou.git

Turn $wgRunJobsAsync off by default

The current situation doesn't work in all installations and has being worse
since MediaWiki 1.27. Default settings should be safe in all installations,
and $wgRunJobsAsync wasn't one of them.

Bug: T142751
Change-Id: I8daa38534a0e925a75ba2fb47e3e299f1baee4b1
---

diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index ef9d734162..3af1654c3f 100644
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -25,6 +25,8 @@ production.
 * $wgUserEmailUseReplyTo is now true by default to work around restrictive DMARC policies.
 * Subpages are now enabled by default in the Template namespace. Set
   $wgNamespacesWithSubpages[NS_TEMPLATE] to false to keep the old behavior.
+* $wgRunJobsAsync is now false by default (T142751). This change only affects
+  wikis with $wgJobRunRate > 0.
 
 === New features in 1.29 ===
 * (T5233) A cookie can now be set when a user is autoblocked, to track that user if
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 09ea958318..f419b77425 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -8105,10 +8105,7 @@ $wgJobRunRate = 1;
  *
  * @since 1.23
  */
-$wgRunJobsAsync = (
-	!function_exists( 'register_postsend_function' ) &&
-	!function_exists( 'fastcgi_finish_request' )
-);
+$wgRunJobsAsync = false;
 
 /**
  * Number of rows to update per job