From 7cf3280d53f0334a8237128c586ca60a62d48c4f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sun, 10 Aug 2014 03:12:34 +0200 Subject: [PATCH] Remove some unnecessary IE 6 hacks We dropped JS support for IE 6. These workarounds for its bugs are no longer necessary, because this code is no longer loaded. (The CSS files modified are parts of modules that require JS support.) We probably have a lot more, these just came up when grepping for 'IE6' and were obvious. Change-Id: I7588b03f6ade699ddda4ec28be6c6f512e4b0ea8 --- resources/src/jquery/jquery.suggestions.css | 5 ----- resources/src/mediawiki/mediawiki.notification.css | 5 ----- .../suites/resources/jquery/jquery.autoEllipsis.test.js | 7 +------ 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/resources/src/jquery/jquery.suggestions.css b/resources/src/jquery/jquery.suggestions.css index ea65946659..15cd926486 100644 --- a/resources/src/jquery/jquery.suggestions.css +++ b/resources/src/jquery/jquery.suggestions.css @@ -9,11 +9,6 @@ border: none; z-index: 1099; padding: 0; - margin: -1px -1px 0 0; -} - -/* IGNORED BY IE6 */ -html > body .suggestions { margin: -1px 0 0 0; } diff --git a/resources/src/mediawiki/mediawiki.notification.css b/resources/src/mediawiki/mediawiki.notification.css index 0c8152e967..ae399ce746 100644 --- a/resources/src/mediawiki/mediawiki.notification.css +++ b/resources/src/mediawiki/mediawiki.notification.css @@ -12,11 +12,6 @@ position: fixed; } -* html .mw-notification-area-floating { - /* Make it at least 'absolute' in IE6 since 'fixed' is not supported */ - position: absolute; -} - .mw-notification { padding: 0.25em 1em; margin-bottom: 0.5em; diff --git a/tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js b/tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js index 842817f582..1005316e74 100644 --- a/tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js +++ b/tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js @@ -47,12 +47,7 @@ // Put this text in the span and verify it doesn't fit $span.text( spanTextNew ); - // In IE6 width works like min-width, allow IE6's width to be "equal to" - if ( $.client.test( { 'msie': 6 }, $.client.profile(), true ) ) { - assert.gtOrEq( $span.width(), $span.parent().width(), 'Fit is maximal (adding two characters makes it not fit any more) - IE6: Maybe equal to as well due to width behaving like min-width in IE6' ); - } else { - assert.gt( $span.width(), $span.parent().width(), 'Fit is maximal (adding two characters makes it not fit any more)' ); - } + assert.gt( $span.width(), $span.parent().width(), 'Fit is maximal (adding two characters makes it not fit any more)' ); } ); }( jQuery ) ); -- 2.20.1