From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 18 Jul 2011 22:30:38 +0000 (+0000)
Subject: Removed testBug29116LoadWithEmptyIp. Fails due to wfDeprecated() call in load() and... 
X-Git-Tag: 1.31.0-rc.0~28756
X-Git-Url: http://git.cyclocoop.org/data/%24oldEdit?a=commitdiff_plain;h=dac8655a58176d00d78e1cb3ffd8a1720648cbea;p=lhc%2Fweb%2Fwiklou.git

Removed testBug29116LoadWithEmptyIp. Fails due to wfDeprecated() call in load() and nothing uses that so it's not worth it.
---

diff --git a/tests/phpunit/includes/BlockTest.php b/tests/phpunit/includes/BlockTest.php
index 2f224ba841..dff5dfe520 100644
--- a/tests/phpunit/includes/BlockTest.php
+++ b/tests/phpunit/includes/BlockTest.php
@@ -82,25 +82,6 @@ class BlockTest extends MediaWikiLangTestCase {
 
 	}
 
-	/**
-	 * This is the method previously used to load block info in CheckUser etc
-	 * passing an empty value (empty string, null, etc) as the ip parameter bypasses IP lookup checks.
-	 *
-	 * This stopped working with r84475 and friends: regression being fixed for bug 29116.
-	 *
-	 * @dataProvider dataBug29116
-	 */
-	function testBug29116LoadWithEmptyIp( $vagueTarget ) {
-		$uid = User::idFromName( 'UTBlockee' );
-		$this->assertTrue( ($uid > 0), 'Must be able to look up the target user during tests' );
-
-		$block = new Block();
-		$ok = $block->load( $vagueTarget, $uid );
-		$this->assertTrue( $ok, "Block->load() with empty IP and user ID '$uid' should return a block" );
-
-		$this->assertTrue( $this->block->equals( $block ), "Block->load() returns the same block as the one that was made when given empty ip param " . var_export( $vagueTarget, true ) );
-	}
-
 	/**
 	 * CheckUser since being changed to use Block::newFromTarget started failing
 	 * because the new function didn't accept empty strings like Block::load()