From: umherirrender <umherirrender_de.wp@web.de>
Date: Thu, 27 Nov 2014 20:12:58 +0000 (+0100)
Subject: Expand error message when parser tests found no hook
X-Git-Tag: 1.31.0-rc.0~12805^2
X-Git-Url: http://git.cyclocoop.org/data/%24oldEdit?a=commitdiff_plain;h=69d903dc20415ace47c52439c248df31b5ebb48a;p=lhc%2Fweb%2Fwiklou.git

Expand error message when parser tests found no hook

The existing message is hard to understand and does not mention, that
this is a problem in the parser test itself and not with phpunit.

Before:
1) Warning
The data provider specified for ParserTest_<file>::testParserTest is
invalid.
Problem running hook

After:
1) Warning
The data provider specified for ParserTest_<file>::testParser
Problem running requested parser hook from the test file

Change-Id: I0b4225cc9ab95e8dd048515315c789113dacf39e
---

diff --git a/tests/testHelpers.inc b/tests/testHelpers.inc
index acfdac8c4c..6d3ac2f5cb 100644
--- a/tests/testHelpers.inc
+++ b/tests/testHelpers.inc
@@ -471,7 +471,7 @@ class TestFileIterator implements Iterator {
 		$hooksResult = $this->delayedParserTest->unleash( $this->parserTest );
 		if ( !$hooksResult ) {
 			# Some hook reported an issue. Abort.
-			throw new MWException( "Problem running hook" );
+			throw new MWException( "Problem running requested parser hook from the test file" );
 		}
 
 		$this->test = array(