From: Antoine Musso <hashar@users.mediawiki.org>
Date: Tue, 28 Jun 2011 19:32:25 +0000 (+0000)
Subject: Find 'all' special ns regardless of its rank in the select
X-Git-Tag: 1.31.0-rc.0~29215
X-Git-Url: http://git.cyclocoop.org/data/%24oldEdit?a=commitdiff_plain;h=5418ac98d26f10e260bb4cb89b9dacc70c1dde3e;p=lhc%2Fweb%2Fwiklou.git

Find 'all' special ns regardless of its rank in the select

This is done by looking for an <option> element with an empty string value
which denote the special case 'all'.
Also removed a comment in Xml.php asking to keep 'all' as a first element
since it is no longer needed.

Follow up r90943 (comment 18872 by Brion)
---

diff --git a/includes/Xml.php b/includes/Xml.php
index 1e8696be1e..a100a8bf28 100644
--- a/includes/Xml.php
+++ b/includes/Xml.php
@@ -132,8 +132,6 @@ class Xml {
 		}
 
 		if( !is_null( $all ) )
-			# Please make sure the 'namespacesall' is the first or you will break
-			# such an assumption (ex js: mw.special.recentchanges.updateCheckboxes)
 			$namespaces = array( $all => wfMsg( 'namespacesall' ) ) + $namespaces;
 		foreach( $namespaces as $index => $name ) {
 			if( $index < NS_MAIN ) {
diff --git a/resources/mediawiki.special/mediawiki.special.recentchanges.js b/resources/mediawiki.special/mediawiki.special.recentchanges.js
index 7b117595da..7e284fbd02 100644
--- a/resources/mediawiki.special/mediawiki.special.recentchanges.js
+++ b/resources/mediawiki.special/mediawiki.special.recentchanges.js
@@ -15,8 +15,8 @@
 		 * special 'all' namespace is selected/unselected respectively.
 		 */
 	 	updateCheckboxes: function() {
-			// The 'all' namespace is the FIRST in the list.
-			var isAllNS = $select.find( 'option' ).first().is( ':selected' );
+			// The option element for the 'all' namespace has an empty value
+			var isAllNS = ('' === $select.find('option:selected').val() );
 
 			// Iterates over checkboxes and propagate the selected option
 			$.each( checkboxes, function( i, id ) {