From: Reedy <reedy@wikimedia.org>
Date: Sat, 7 Apr 2012 16:23:16 +0000 (+0100)
Subject: Action::checkCanExecute doesn't return anything on success, but WatchAction returns... 
X-Git-Tag: 1.31.0-rc.0~23971^2
X-Git-Url: http://git.cyclocoop.org/data/%24oldEdit?a=commitdiff_plain;h=478d42cc35eb507ecf2963173baad2f30cf9ed57;p=lhc%2Fweb%2Fwiklou.git

Action::checkCanExecute doesn't return anything on success, but WatchAction returns the result

Change-Id: Ib4169a8067f22f4a80295923e2aa77d151c4c47c
---

diff --git a/includes/Action.php b/includes/Action.php
index 84c0f808e7..a25e8aa9ab 100644
--- a/includes/Action.php
+++ b/includes/Action.php
@@ -266,6 +266,7 @@ abstract class Action {
 	 *
 	 * @param $user User: the user to check, or null to use the context user
 	 * @throws ErrorPageError
+	 * @return bool True on success
 	 */
 	protected function checkCanExecute( User $user ) {
 		$right = $this->getRestriction();
@@ -287,6 +288,7 @@ abstract class Action {
 		if ( $this->requiresWrite() && wfReadOnly() ) {
 			throw new ReadOnlyError();
 		}
+		return true;
 	}
 
 	/**