From: Ori Livneh <ori@wikimedia.org>
Date: Tue, 27 Oct 2015 03:28:21 +0000 (-0700)
Subject: Get rid of CSS transitions on form elements in mediawiki.ui
X-Git-Tag: 1.31.0-rc.0~9207^2
X-Git-Url: http://git.cyclocoop.org/data/%24oldEdit?a=commitdiff_plain;h=028d7488135c451e6f23a4389c13ef7d771d79d0;p=lhc%2Fweb%2Fwiklou.git

Get rid of CSS transitions on form elements in mediawiki.ui

They seem to serve no function whatsoever other than to irritate and delay the
loading of the page.

Change-Id: I54c195541713a5bfbc8bd7078499ac49671697c6
---

diff --git a/resources/src/mediawiki.ui/components/buttons.less b/resources/src/mediawiki.ui/components/buttons.less
index d66973a8ea..600b7711c1 100644
--- a/resources/src/mediawiki.ui/components/buttons.less
+++ b/resources/src/mediawiki.ui/components/buttons.less
@@ -12,9 +12,6 @@
 //
 // Styleguide 2.
 
-@transitionDuration: .1s;
-@transitionFunction: ease-in-out;
-
 // Neutral button styling
 //
 // These are the main actions on the page/workflow. The page should have only one of progressive, constructive and desctructive buttons, the rest being quiet.
@@ -66,8 +63,6 @@
 		cursor: default;
 	}
 
-	.transition(background @transitionDuration @transitionFunction, color @transitionDuration @transitionFunction, box-shadow @transitionDuration @transitionFunction;);
-
 	// Styling for specific button types
 	// -----------------------------------------
 
diff --git a/resources/src/mediawiki.ui/components/checkbox.less b/resources/src/mediawiki.ui/components/checkbox.less
index ac5becb800..bd5dd4a297 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -72,7 +72,6 @@
 
 		// the pseudo before element of the label after the checkbox now looks like a checkbox
 		& + label::before {
-			.transition( 0.2s cubic-bezier(0.175, 0.885, 0.32, 1.275) );
 			content: '';
 			cursor: pointer;
 			.box-sizing(border-box);
diff --git a/resources/src/mediawiki.ui/components/inputs.less b/resources/src/mediawiki.ui/components/inputs.less
index 2f76131286..62f0e8345f 100644
--- a/resources/src/mediawiki.ui/components/inputs.less
+++ b/resources/src/mediawiki.ui/components/inputs.less
@@ -39,7 +39,6 @@
 	font-family: inherit;
 	font-size: inherit;
 	line-height: inherit;
-	.transition(~"border 0.2s cubic-bezier(0.39, 0.575, 0.565, 1), box-shadow 0.2s cubic-bezier(0.39, 0.575, 0.565, 1)");
 
 	// Placeholder text styling must be set individually for each browser @winter
 	&::-webkit-input-placeholder { // webkit
diff --git a/resources/src/mediawiki.ui/components/radio.less b/resources/src/mediawiki.ui/components/radio.less
index 1928699bb5..52effd65b2 100644
--- a/resources/src/mediawiki.ui/components/radio.less
+++ b/resources/src/mediawiki.ui/components/radio.less
@@ -63,7 +63,6 @@
 
 		// the pseudo before element of the label after the radio now looks like a radio
 		& + label::before {
-			.transition( 0.2s cubic-bezier(0.175, 0.885, 0.32, 1.275) );
 			content: '';
 			cursor: pointer;
 			.box-sizing(border-box);