Don't use <!-- --> to wrap JavaScript code!
This ACTUALLY MAKES THE CODE DISAPPEAR when using an XML parser.
Instead, wrapped in /*<![CDATA[*/ /*]]>*/ to ensure XML compatibility for contents.
We've long since given up on super-ancient browsers that don't
know about <script>; they're so old you can't even use name-based
virtual hosts so why bother? ;)
* User::getOption now accept a default value to override default user values
this makes it consistent with WebRequest::get* methods. Corrected code in
various places accordingly.
+* (bug 8264) Fix JavaScript global vars for XHTML mode
== Languages updated ==
static function makeVariablesScript( $data ) {
global $wgJsMimeType;
- $r = "<script type= \"$wgJsMimeType\"><!--\n";
+ $r = "<script type= \"$wgJsMimeType\">/*<![CDATA[*/\n";
foreach ( $data as $name => $value ) {
$encValue = Xml::encodeJsVar( $value );
$r .= "var $name = $encValue;\n";
}
- $r .= "--></script>\n";
+ $r .= "/*]]>*/</script>\n";
return $r;
}