From 6c9fb706a3d44f113b1f96ee1a52014a4a49fd07 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 28 Jun 2019 13:22:11 -0700 Subject: [PATCH] rdbms: make FakeResultWrapper use get_object_vars() again get_object_vars() avoids a bug in older PHP versions where string digit fields end up as string digit array keys instead of proper integers, which can cause errors on access. Follow up to d9f688698ce0 Change-Id: Ic93231e4a7244f49149ce9ed35fbcb1e04ac4065 --- .../libs/rdbms/database/resultwrapper/FakeResultWrapper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php b/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php index 3709de7de2..2ca3d7d51b 100644 --- a/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php +++ b/includes/libs/rdbms/database/resultwrapper/FakeResultWrapper.php @@ -35,7 +35,7 @@ class FakeResultWrapper extends ResultWrapper { $this->next(); - return is_object( $row ) ? (array)$row : $row; + return is_object( $row ) ? get_object_vars( $row ) : $row; } function seek( $pos ) { -- 2.20.1