$lbFactory->rollbackMasterChanges( __METHOD__ );
}
} else {
- // Done; nothing changed
$dbw->endAtomic( __METHOD__ );
}
}
// TODO: move to storage service
$newid = $wikiPage->insertOn( $dbw );
if ( $newid === false ) {
- $dbw->endAtomic( __METHOD__ ); // nothing inserted
+ $dbw->endAtomic( __METHOD__ );
$status->fatal( 'edit-already-exists' );
- return $status; // nothing done
+ return $status;
}
// At this point we are now comitted to returning an OK
$restrictions
);
- // Nothing to remove.
if ( empty( $restrictionsToRemove ) ) {
continue;
}
return self::intermediateEditsMsg( $nEdits, $numUsers, $limit );
}
- return ''; // nothing
+ return '';
}
/**
*/
public function addRelations( $field, $values, $logid ) {
if ( !strlen( $field ) || empty( $values ) ) {
- return false; // nothing
+ return false;
}
$data = [];
__METHOD__
);
- # Done!
return true;
}
$this->output( "done.\n" );
}
- # Done
$this->commitTransaction( $dbw, __METHOD__ );
}
]
);
if ( !$rows || $rows->numRows() <= 0 ) {
- # Done, hopefully.
break;
}
]
);
if ( !$rows || $rows->numRows() <= 0 ) {
- # Done, hopefully.
break;
}
foreach ( $rows as $row ) {
$numRows = $res->numRows();
$total += $numRows;
if ( $res->numRows() <= 0 ) {
- // All done!
$this->output( "DONE! (handled $total entries)\n" );
break;
}
$this->output( "done.\n" );
}
- # This bit's done
# Purge redundant text records
$this->commitTransaction( $dbw, __METHOD__ );
if ( $delete ) {
$props,
$timestamp
)->isOK() ) {
- # We're done!
$this->output( "done.\n" );
$doProtect = false;
$this->assertEquals( false, $this->backend->fileExists( [ 'src' => $dest ] ),
"Destination file $dest does not exist ($backendName)." );
- return; // done
+ return;
}
$status = $this->backend->doOperation(
$this->assertEquals( false, $this->backend->fileExists( [ 'src' => $dest ] ),
"Destination file $dest does not exist ($backendName)." );
- return; // done
+ return;
}
$status = $this->backend->doOperation(