From: Matěj Suchánek <matejsuchanek97@gmail.com>
Date: Fri, 29 Jun 2018 20:53:11 +0000 (+0200)
Subject: WikiPage: Do not set "undid revision ID" for rollbacks
X-Git-Tag: 1.34.0-rc.0~4905^2
X-Git-Url: http://git.cyclocoop.org/data/%24self?a=commitdiff_plain;h=8ed6eed7a7ea9f5e4c55f859e7f2513997b2acde;p=lhc%2Fweb%2Fwiklou.git

WikiPage: Do not set "undid revision ID" for rollbacks

It causes them to be tagged with the "mw-undo" tag, in addition to the
"mw-rollback" tag they already have.

Bug: T190374
Change-Id: Ia447a107f0844cfef4a51a72fdec7aeea0480c70
---

diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index ad3c8c592b..c25ff357c9 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -2959,7 +2959,7 @@ class WikiPage implements Page, IDBAccessObject {
 		}
 
 		$updater->setOriginalRevisionId( $target->getId() );
-		$updater->setUndidRevisionId( $current->getId() );
+		// Do not call setUndidRevisionId(), that causes an extra "mw-undo" tag to be added (T190374)
 		$updater->addTags( $tags );
 
 		// TODO: this logic should not be in the storage layer, it's here for compatibility