From: Kunal Mehta <legoktm@member.fsf.org>
Date: Sun, 19 Aug 2018 07:06:35 +0000 (-0700)
Subject: Improve StaticArrayWriterTest and add missing @covers tag
X-Git-Tag: 1.34.0-rc.0~4372^2
X-Git-Url: http://git.cyclocoop.org/data/%24self?a=commitdiff_plain;h=81f4eb4b714e5563126e571d5615b0c0ac63ac0c;p=lhc%2Fweb%2Fwiklou.git

Improve StaticArrayWriterTest and add missing @covers tag

Checking for proper quoting was suggested by Krinkle in CR.

Change-Id: I7fa599767017a5cfc82899bc4178de6cb34bdd02
---

diff --git a/tests/phpunit/includes/libs/StaticArrayWriterTest.php b/tests/phpunit/includes/libs/StaticArrayWriterTest.php
index bfb3b584c9..276fee3f6c 100644
--- a/tests/phpunit/includes/libs/StaticArrayWriterTest.php
+++ b/tests/phpunit/includes/libs/StaticArrayWriterTest.php
@@ -20,11 +20,15 @@
 
 use Wikimedia\StaticArrayWriter;
 
+/**
+ * @covers \Wikimedia\StaticArrayWriter
+ */
 class StaticArrayWriterTest extends PHPUnit\Framework\TestCase {
 	public function testCreate() {
 		$data = [
 			'foo' => 'bar',
 			'baz' => 'rawr',
+			"they're" => '"quoted properly"',
 		];
 		$writer = new StaticArrayWriter();
 		$actual = $writer->create( $data, "Header\nWith\nNewlines" );
@@ -36,6 +40,7 @@ class StaticArrayWriterTest extends PHPUnit\Framework\TestCase {
 return [
 	'foo' => 'bar',
 	'baz' => 'rawr',
+	'they\'re' => '"quoted properly"',
 ];
 
 PHP;