From d1143076ca6e411bd2f562b56532a578577ba656 Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Tue, 2 Oct 2018 12:55:12 -0400 Subject: [PATCH] RCFilters: better vertical alignment of checkbox and text in menus - Remove min-height so menu items are a little smaller and their content is vertically-aligned. - Force `vertical-align: middle;` for checkboxes by overriding OOUI with extreme specificity. Bug: T200364 Change-Id: If0b2b5c1b749f913badbd0c02a85852ec0007020 --- .../styles/mw.rcfilters.ui.ItemMenuOptionWidget.less | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less index 1cc48e2b4f..bf855be970 100644 --- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less +++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less @@ -3,7 +3,6 @@ @import 'mw.rcfilters.variables'; .mw-rcfilters-ui-itemMenuOptionWidget { - min-height: 3.5em; padding: 0 0.5em; .box-sizing( border-box ); @@ -53,12 +52,15 @@ .oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline { // Override margin-top and -bottom rules from FieldLayout margin: 0 !important; /* stylelint-disable-line declaration-no-important */ + + .oo-ui-fieldLayout-body > .oo-ui-fieldLayout-field { + vertical-align: middle; + } } .oo-ui-checkboxInputWidget { // Workaround for IE11 rendering issues. T162098 display: block; - padding-top: 1em; } label { -- 2.20.1