From 820d33ac96ad63d993cf27c0fe05efc4e8895686 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Thu, 9 May 2019 23:25:53 +0100 Subject: [PATCH] Remove deprecated unused method `getModuleScripts()` Deprecated in 1.33 and no longer used. Removed from OutputPage and from ParserOutput. Usage ===== https://codesearch.wmflabs.org/search/?q=%5CbgetModuleScripts%5Cb&i=nope&files=&repos= Bug: T220656 Change-Id: Ifddea94504d0c749d3a77daf967d5fec95b50339 --- RELEASE-NOTES-1.34 | 2 ++ includes/OutputPage.php | 9 --------- includes/parser/ParserOutput.php | 5 ----- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index 5cb3dbe1f0..ae20991e38 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -143,6 +143,8 @@ because of Phabricator reports. 1.28, have been removed. * PageArchive::getTextFromRow(), ::listAllPages(), and ::getLastRevisionText(), deprecated in 1.32, have been removed. +* OutputPage::getModuleScripts(), ParserOutput::getModuleScripts(), deprecated + in 1.33, have been removed. * … === Deprecations in 1.34 === diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 641f0b857b..c45fce7a9d 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -548,15 +548,6 @@ class OutputPage extends ContextSource { $this->mModules = array_merge( $this->mModules, (array)$modules ); } - /** - * @deprecated since 1.33 Use getModules() instead. - * @return array - */ - public function getModuleScripts() { - wfDeprecated( __METHOD__, '1.33' ); - return []; - } - /** * Get the list of style-only modules to load on this page. * diff --git a/includes/parser/ParserOutput.php b/includes/parser/ParserOutput.php index f80e6bf5d2..40bcebdd51 100644 --- a/includes/parser/ParserOutput.php +++ b/includes/parser/ParserOutput.php @@ -510,11 +510,6 @@ class ParserOutput extends CacheTime { return $this->mModules; } - public function getModuleScripts() { - wfDeprecated( __METHOD__, '1.33' ); - return []; - } - public function getModuleStyles() { return $this->mModuleStyles; } -- 2.20.1