zoranzoki21 [Mon, 29 Apr 2019 23:29:39 +0000 (01:29 +0200)]
docs/kss/package.json: Update Gerrit /r/p/ link to /r/
Bug: T218844
Change-Id: Ie503c5f7dc3bd89d983c1b368e25a4d185ae617e
jenkins-bot [Mon, 29 Apr 2019 21:02:39 +0000 (21:02 +0000)]
Merge "User: Remove/Kill usage of deprecated User::makeGroupLinkWiki()"
Derick Alangi [Mon, 29 Apr 2019 20:13:53 +0000 (21:13 +0100)]
User: Remove/Kill usage of deprecated User::makeGroupLinkWiki()
This method was deprecated in 1.29 and usage of this method can no
longer be found.
Usage
=====
https://codesearch.wmflabs.org/search/?q=makeGroupLinkWiki&i=nope&files=&repos=
Bug: T220656
Change-Id: Iff5ef6666e8ec3e7060ddef8f60362206f4306d0
jenkins-bot [Mon, 29 Apr 2019 20:11:05 +0000 (20:11 +0000)]
Merge "jobqueue: make JobQueueDB stricter about broken job_params fields"
jenkins-bot [Mon, 29 Apr 2019 20:02:56 +0000 (20:02 +0000)]
Merge "objectcache: replace debugLog() calls with faster debug() calls in MemcachedPeclBagOStuff"
jenkins-bot [Mon, 29 Apr 2019 20:01:21 +0000 (20:01 +0000)]
Merge "objectcache: micro-optimize determineKeyClassForStats() by using the limit option to explode()"
Translation updater bot [Mon, 29 Apr 2019 19:56:09 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I29daa267c536e8dc57b524e4a9232c606364b9cb
jenkins-bot [Mon, 29 Apr 2019 19:35:18 +0000 (19:35 +0000)]
Merge "User: Remove deprecated methods ::getGroupPage() & ::makeGroupLinkHTML()"
Derick Alangi [Mon, 29 Apr 2019 10:58:21 +0000 (11:58 +0100)]
User: Remove deprecated methods ::getGroupPage() & ::makeGroupLinkHTML()
These methods were deprecated in 1.29 and usage can no longer be found so,
removing ahead of 1.34 cut.
Usage
=====
* User::getGroupPage() -
https://codesearch.wmflabs.org/search/?q=%5B%5E%3E%5D(User)%3A%3AgetGroupPage%5C(&i=nope&files=&repos=
* User::makeGroupLinkHTML() -
https://codesearch.wmflabs.org/search/?q=%5B%5E%3E%5D(User)%3A%3AmakeGroupLinkHTML%5C(&i=nope&files=&repos=
Bug: T220656
Change-Id: I4e48eb351883b044269d77a8baaf7b5030138c34
jenkins-bot [Mon, 29 Apr 2019 17:06:58 +0000 (17:06 +0000)]
Merge "mw.widgets.TitleWidget: Update icons, use OOUI where possible"
jenkins-bot [Mon, 29 Apr 2019 16:13:34 +0000 (16:13 +0000)]
Merge "Clarify documentation of minor and notminor API parameters"
Ed Sanders [Mon, 29 Apr 2019 16:09:43 +0000 (17:09 +0100)]
mw.widgets.TitleWidget: Update icons, use OOUI where possible
Bug: T222079
Change-Id: I7ff1ca9410236b7404556cb0b90cab3340ee7b0b
jenkins-bot [Mon, 29 Apr 2019 11:44:50 +0000 (11:44 +0000)]
Merge "Deprecate User::isBlocked()"
jenkins-bot [Mon, 29 Apr 2019 09:08:44 +0000 (09:08 +0000)]
Merge "editpage: Make TextConflictHelper::toEditContent private"
jenkins-bot [Mon, 29 Apr 2019 02:29:28 +0000 (02:29 +0000)]
Merge "Avoid usage of deprecated wfGetMainCache() function"
Derick Alangi [Sat, 23 Mar 2019 13:02:00 +0000 (14:02 +0100)]
SpecialUserrights: Improve ::userCanChangeRights() method logic
Bug: T37674
Change-Id: I22aa9ff72aec175b0f86ebcf48cd7716f3328b01
Lucas Werkmeister [Sun, 28 Apr 2019 20:15:15 +0000 (22:15 +0200)]
Clarify documentation of minor and notminor API parameters
Change-Id: I9f55dd179ea7efcc618120da4e18b7708903a5ff
Derick Alangi [Sun, 28 Apr 2019 19:41:17 +0000 (20:41 +0100)]
Avoid usage of deprecated wfGetMainCache() function
This function was deprecated in 1.32 and replaced with the use of
ObjectCache::getLocalClusterInstance().
Change-Id: Id50700a6a7110888b12c4ee1a2100134173760a0
Derick Alangi [Sat, 27 Apr 2019 07:00:19 +0000 (08:00 +0100)]
GlobalFunctions: Remove deprecated `wfMakeUrlIndexes()` function
This function was hard deprecated in 1.33 and per code search, usage
is no longer there, probably completely replaced?
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbwfMakeUrlIndexes%5Cb&i=nope&files=&repos=
Bug: T42485
Change-Id: I01642a8207f582762428f5a7ac33830066268b2e
jenkins-bot [Sun, 28 Apr 2019 07:59:13 +0000 (07:59 +0000)]
Merge "jobqueue: Follow-up for
fc5d51f12936ed (added GenericParameterJob)"
jenkins-bot [Sat, 27 Apr 2019 23:07:12 +0000 (23:07 +0000)]
Merge "RELEASE-NOTES: Follow-up on I28092eeb8dec058c5dba2fb63"
jenkins-bot [Sat, 27 Apr 2019 10:20:48 +0000 (10:20 +0000)]
Merge "Rename $isIpUser to $isAnon, in line with convention elsewhere"
Derick Alangi [Sat, 27 Apr 2019 08:42:48 +0000 (09:42 +0100)]
RELEASE-NOTES: Follow-up on I28092eeb8dec058c5dba2fb63
Change-Id: Id170565f7ce71648ccdab415ded90d8eaf330400
jenkins-bot [Sat, 27 Apr 2019 07:21:46 +0000 (07:21 +0000)]
Merge "GlobalFunctions: Remove usage of `wfArrayFilter` & `wfArrayFilterByKey`"
Derick Alangi [Sat, 27 Apr 2019 06:40:47 +0000 (07:40 +0100)]
GlobalFunctions: Remove usage of `wfArrayFilter` & `wfArrayFilterByKey`
These functions were hard deprecated in 1.32 and usage no longer exist
and seems to have been completely removed from all repos. See below;
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5B%5E%3E%5D(wfArrayFilterByKey%5C(%7CwfArrayFilter%5C()&i=nope&files=&repos=
Bug: T42485
Change-Id: I28092eeb8dec058c5dba2fb63f3602249c137b31
Amir Aharoni [Sun, 17 Mar 2019 12:48:53 +0000 (14:48 +0200)]
Add N'Ko to Names.php
Bug: T221994
Change-Id: I8c8e05ebabec8d50fa089b4d88061667a29d8b83
Aaron Schulz [Sat, 27 Apr 2019 04:40:53 +0000 (21:40 -0700)]
objectcache: micro-optimize determineKeyClassForStats() by using the limit option to explode()
Change-Id: I7d95998487dd18078599b16201c9d0ec0debcb0b
Aaron Schulz [Sat, 27 Apr 2019 04:10:05 +0000 (21:10 -0700)]
objectcache: replace debugLog() calls with faster debug() calls in MemcachedPeclBagOStuff
Change-Id: Iefe29d43f2bc8efa8288b4625d20bd803f35bbfe
jenkins-bot [Sat, 27 Apr 2019 02:35:00 +0000 (02:35 +0000)]
Merge "API: Add STRAIGHT_JOIN to ApiQueryUserContribs to avoid planner oddness"
Zoranzoki21 [Sat, 20 Apr 2019 23:34:48 +0000 (01:34 +0200)]
Split parser related files to have one class in one file
Change-Id: I36b26609ccb3f135a22961b32a46cdc06603b3e4
Aaron Schulz [Fri, 26 Apr 2019 20:11:09 +0000 (13:11 -0700)]
jobqueue: make JobQueueDB stricter about broken job_params fields
Also rename throwDBException() to getDBException() and make the
callers throw the result to avoid phpstorm warnings. Remove $row
assignment that is always overridden as well.
Change-Id: I84bc4b11f10152eada6dd6f4788c4f79dcb4a2fb
Chiefwei [Sun, 17 Mar 2019 12:53:13 +0000 (20:53 +0800)]
Chinese Conversion Table Update 2019-1
Update the Chinese conversion table routinely to fix bugs reported from https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .
It is only data changes and only works for Chinese WikiProjects.
Change-Id: Id2d16722eaa837c37e8696c9dd9a2d2231af26e8
Brad Jorsch [Tue, 23 Apr 2019 18:02:34 +0000 (14:02 -0400)]
API: Add STRAIGHT_JOIN to ApiQueryUserContribs to avoid planner oddness
For some unknown reason, when the `actor` table has few enough rows (or
few enough compared to `revision_actor_temp`) MariaDB 10.1.37 decides it
makes more sense to fetch everything from `actor` + `revision_actor_temp`
and filesort rather than fetching the limited number of rows from
`revision_actor_temp`.
We can work around it by telling it to not reorder the query, but then
(unlike in I9da981c0) we also have to reorder it ourselves to put
`revision_actor_temp` first instead of `revision`.
Bug: T221511
Change-Id: Ic63875b26a051a2da58374d5d76c95a6fa8ecc8e
Translation updater bot [Fri, 26 Apr 2019 19:57:37 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I30314516bdc6ed318ca7f76c9217c548aad5e2ed
jenkins-bot [Fri, 26 Apr 2019 19:10:46 +0000 (19:10 +0000)]
Merge "Allow <figure-inline> attributes through Sanitizer"
jenkins-bot [Fri, 26 Apr 2019 19:10:10 +0000 (19:10 +0000)]
Merge "Synchronize allowed attributes for <audio> with Parsoid/TimedMediaHandler"
Thalia [Thu, 25 Apr 2019 12:02:12 +0000 (13:02 +0100)]
Rename $isIpUser to $isAnon, in line with convention elsewhere
Change-Id: I66721f4af5e844c3e18ba35558390563b8424863
jenkins-bot [Fri, 26 Apr 2019 11:47:47 +0000 (11:47 +0000)]
Merge "Rename BlockRestriction -> BlockRestrictionStore and wire it up as a service"
jenkins-bot [Fri, 26 Apr 2019 02:25:08 +0000 (02:25 +0000)]
Merge "Add STRAIGHT_JOIN to ApiQueryLogEvents and LogPager to avoid planner oddness"
jenkins-bot [Thu, 25 Apr 2019 23:19:07 +0000 (23:19 +0000)]
Merge "Change the autonym of Javanese from "Basa Jawa" to "Jawa""
Ed Sanders [Wed, 24 Apr 2019 12:46:40 +0000 (13:46 +0100)]
mediawiki.storage: Add methods for storing plain objects as JSON
Change-Id: I3cc1d5adfbce794e8345b7f1090c10fb0d42d150
jenkins-bot [Thu, 25 Apr 2019 22:07:46 +0000 (22:07 +0000)]
Merge "rdbms: add "secret" parameter to ChronologyProtector to use HMAC client IDs"
jenkins-bot [Thu, 25 Apr 2019 20:21:53 +0000 (20:21 +0000)]
Merge "specials: Avoid the use of global variables in Special:Version"
David Barratt [Tue, 23 Apr 2019 17:51:54 +0000 (13:51 -0400)]
Deprecate User::isBlocked()
The method User::isBlocked() attempts to answer two questions:
(1) Does the user have a block?
(2) Is the user prevented from performing this action?
The method can answer #1, but it cannot answer #2. Since User::getBlock() can
also answer #1, this method is redundant. The method cannot answer #2 because
there is not enough context in order to answer that question.
If access is being checked against a Title object, all access checks can be
performed with PermissionManager:userCan() which will also check the user's
blocks.
If performing all access checks is not desirable, using
PermissionManager::isBlockedFrom() is also acceptable for only checking if the
user is blocked. This method does *not* determine if the action is allowed,
only that the user's block applies to that Title.
If access is being checked without an existing Title, User::getBlock() can be
used to get the user's block. Then Block::appliesToRight() can be used to
determine if the block applies explicitly to a right (or returns null if
it is unknown or false if explicitly allowed). If the user is creating a new
Title, but the text of the title is not yet known (as in the case of Wikibase),
access should be checked with Block::appliesToNamespace().
Bug: T209004
Change-Id: Ic0ad1b92e957797fee8dcd00bd1092fe69fa58f1
Timo Tijhof [Thu, 18 Apr 2019 15:29:41 +0000 (16:29 +0100)]
jobqueue: Follow-up for
fc5d51f12936ed (added GenericParameterJob)
* Remove duplicate $params check from Job::factory done in Job::__construct.
* In Job::factory(), restore use of a valid title as default for passing as
constructor arg to old job classes. Their constructor may expect it to
be valid.
Keep the invalid dummy in Job::__construct, and document why.
* tests: Update test case for failure mode when using Job::factory
with a class that requires a title. It asserted getting an invalid
title. This now restores the behaviour prior to
fc5d51f12936ed,
which is that job classes that require a title, get a valid one.
* tests: Remove test case for testToString that used
an explicitly passed but invalid params value. I've converted
that to expect the exception we now throw instead.
* tests: Update getMockJob(), also used by testToString, which was
relying on undocumented behaviour that 'new Title' is public
and gets namespace=0 and title=''. Before
fc5d51f12936ed,
title params weren't in toString() and it asserted outputting
three spaces (delimiter, empty string from formatted title,
delimiter).
In
fc5d51f12936ed, this changed to asserting "Special:" which
seems unintentional as we didn't pass it the internally reserved
NS_SPECIAL/'' value, and yet was caught by the dbkey=='' check.
Given this test case doesn't deal with titles, omit it for now.
A job can either have a $title and title/namespace in params,
or neither. This test was asserting an in-memory scenario
where $title can be an object, but title/namespace absent from
params.
Bug: T221368
Depends-On: I89f6ad6967d6f82d87a62c15c0dded901c51b714
Change-Id: I2ec99a12ecc627359a2aae5153d5d7c54156ff46
Brad Jorsch [Thu, 25 Apr 2019 13:49:01 +0000 (09:49 -0400)]
ApiLogout: Follow up Icb674095
This implements getWebUITokenSalt(), as mentioned in T25227#
2008199 and
implemented in
F3328897. Somehow it didn't make it into Icb674095.
This also fixes some issues in the unit test:
* Properly link the user to the request's Session so User::doLogout()
won't log a warning. This also gives use to the otherwise-unneeded
implementation of setUp(), and lets us get rid of the broken call to
User::newFromId() that was passing an IP address rather than a user ID.
* Privatize some internal methods.
* Use setExpectedApiException() instead of manually catching and
hard-coding the English exception message.
* Also assert that the bad token error didn't result in a logout.
Bug: T25227
Change-Id: I2aecfba821cca3c367c5e7e8d188a88197fb82d2
jenkins-bot [Thu, 25 Apr 2019 09:39:02 +0000 (09:39 +0000)]
Merge "[SECURITY] [API BREAKING CHANGE] Require logout token."
jenkins-bot [Wed, 24 Apr 2019 20:09:11 +0000 (20:09 +0000)]
Merge "Remove unused wgUploadWarningObj.keypress"
Translation updater bot [Wed, 24 Apr 2019 19:55:35 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I36801827ec21f0fcc6a42b0bacce8ff938e3af41
James D. Forrester [Wed, 24 Apr 2019 18:36:00 +0000 (13:36 -0500)]
Update OOUI to v0.31.5
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.5
Bug: T218229
Bug: T221705
Depends-On: I89a829b50e318649ed80b4bd9ac2fea61d08a5d2
Change-Id: I89a829b50e318649ed80b4bd9ac2fea61d08a5d1
Derick Alangi [Tue, 29 Jan 2019 17:40:58 +0000 (18:40 +0100)]
specials: Avoid the use of global variables in Special:Version
We're moving away from globals to Config this patch attempts to
clean off some globals whose values can be nicely gotten via the
use of Config.
Bug: T72638
Change-Id: I25516873c215b74cdd425d023e877e5cdc3d6149
sbassett [Tue, 16 Apr 2019 22:09:43 +0000 (17:09 -0500)]
[SECURITY] [API BREAKING CHANGE] Require logout token.
Special:Userlogout now requires a token
Api action=logout requires a csrf token and the request to be POSTed
Patch author: bawolff
Bug: T25227
Change-Id: Icb674095956bb3f6c847c9553c53e404402ea774
jenkins-bot [Wed, 24 Apr 2019 15:33:54 +0000 (15:33 +0000)]
Merge "Reinstate small category refresh logic in LinksDeletionUpdate"
jenkins-bot [Wed, 24 Apr 2019 13:59:44 +0000 (13:59 +0000)]
Merge "Remove block notice tracking"
jenkins-bot [Wed, 24 Apr 2019 13:44:34 +0000 (13:44 +0000)]
Merge "mediawiki.action.view.metadata: Remove JavaScript part of initial state"
jenkins-bot [Wed, 24 Apr 2019 11:26:19 +0000 (11:26 +0000)]
Merge "StubObject: Use 'self' instead of 'StubObject' (or <ClassName>)"
jenkins-bot [Wed, 24 Apr 2019 08:45:06 +0000 (08:45 +0000)]
Merge "UsersPager: Use CSS-based parentheses"
Thiemo Kreuz [Wed, 24 Apr 2019 08:29:32 +0000 (10:29 +0200)]
editpage: Make TextConflictHelper::toEditContent private
The method is not used anywhere:
https://codesearch.wmflabs.org/search/?q=toEditContent&i=1
There is another method with the same name in the EditPage class. But
this is unrelated. As far as I can see the method I'm touching in this
patch was copied from the EditPage class.
Change-Id: I51d167723bd70220adbf4ac36f15f3290b7eb653
Fomafix [Wed, 24 Apr 2019 06:16:02 +0000 (08:16 +0200)]
mediawiki.action.view.metadata: Remove JavaScript part of initial state
THe HTML caches have expired. The JavaScript part of initialization of
the state is not necessary anymore.
This change is a follow up to
6400972e.
Change-Id: Ie87f972a73b2cd4a0444056002243ecc0b90fdb9
Aaron Schulz [Tue, 23 Apr 2019 23:59:35 +0000 (16:59 -0700)]
Reinstate small category refresh logic in LinksDeletionUpdate
Add new Category::refreshCountsIfSmall() method that will do a non-locking
SELECT with LIMIT before deciding whether to do a full locking SELECT and
refresh. Call this from LinksDeletionUpdate.
Bug: T18036
Change-Id: I9de8311565988453b8e29a7f3d95d758182fcec1
jenkins-bot [Wed, 24 Apr 2019 00:05:09 +0000 (00:05 +0000)]
Merge "Split ApiErrorFormatter.php to have one class in one file"
jenkins-bot [Tue, 23 Apr 2019 23:12:08 +0000 (23:12 +0000)]
Merge "Gallery slideshow: Remove excess margin on controls"
jenkins-bot [Tue, 23 Apr 2019 23:12:03 +0000 (23:12 +0000)]
Merge "Gallery: Refactor CSS as LESS"
jenkins-bot [Tue, 23 Apr 2019 23:11:55 +0000 (23:11 +0000)]
Merge "Gallery slideshow: Improve missing image and error handling"
Dayllan Maza [Wed, 17 Apr 2019 19:04:15 +0000 (15:04 -0400)]
Remove block notice tracking
This is a clean up after collecting the necessary data related to
blocks and how often users see the block notices
See: https://phabricator.wikimedia.org/T189724
Bug: T214214
Depends-On: I047587c064e63e8bd4b933351edfec298f7c7956
Depends-On: I532a0cd95009109ba25caa8dd31badd5c1900da7
Change-Id: Icfa74ad6337c0a4f12ae24b43d36c0e3cb302a3b
jenkins-bot [Tue, 23 Apr 2019 21:41:29 +0000 (21:41 +0000)]
Merge "Gallery slideshow: Support MMV"
jenkins-bot [Tue, 23 Apr 2019 21:31:38 +0000 (21:31 +0000)]
Merge "Alter two uses of hasOrMadeRecentMasterChanges() for consistency"
jenkins-bot [Tue, 23 Apr 2019 21:31:33 +0000 (21:31 +0000)]
Merge "Hypenate ChronologyProtector HTTP headers"
jenkins-bot [Tue, 23 Apr 2019 21:12:40 +0000 (21:12 +0000)]
Merge "Keep ERROR_* constants in ApiStashEdit for backwards compatibility"
jenkins-bot [Tue, 23 Apr 2019 20:54:03 +0000 (20:54 +0000)]
Merge "Avoid pre-send parse in DerivedPageDataUpdater due to isCountable()"
Translation updater bot [Tue, 23 Apr 2019 20:24:03 +0000 (22:24 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0c876a9635fcabff26a042e73e3796f0eba375ef
Aaron Schulz [Tue, 23 Apr 2019 19:43:29 +0000 (12:43 -0700)]
Keep ERROR_* constants in ApiStashEdit for backwards compatibility
Follow-up to
285930668495b
Bug: T221689
Change-Id: Ibe275c69d5b47fd36efac4a91b2334970dd02fe8
jenkins-bot [Tue, 23 Apr 2019 19:02:33 +0000 (19:02 +0000)]
Merge "Remove last references to the long-gone CSS classes .editExternally and .editExternallyHelp"
Aaron Schulz [Tue, 23 Apr 2019 18:37:53 +0000 (11:37 -0700)]
Hypenate ChronologyProtector HTTP headers
Follow up to
6b6997dcf9036e372b4
Change-Id: I4c26c16821f3b57996c7d5c7195010c57a603041
Aaron Schulz [Tue, 19 Mar 2019 03:31:54 +0000 (20:31 -0700)]
Alter two uses of hasOrMadeRecentMasterChanges() for consistency
Rather than have the behavior vary and possibly break code or tests
when small changes happen, make User/NameTableStore more explicit
about when cache key purges happens.
This should reduce problems with certain fragile tests, such as those
that could be affected by
03908112635f when --use-normal tables is not
used. Ideally, any fragility should be ironed out of effected code.
Change-Id: Ibe5d1bb4bece2526bc0da99648f7ba73bdc0ffa5
jenkins-bot [Tue, 23 Apr 2019 18:21:42 +0000 (18:21 +0000)]
Merge "Accept new "MediaWiki-ChronologyClientId" HTTP header"
Roan Kattouw [Fri, 19 Apr 2019 21:44:27 +0000 (14:44 -0700)]
UsersPager: Use CSS-based parentheses
Tell Linker::userToolLinks() and Linker::userToolLinksRedContribs()
to omit parentheses, and load the CSS that fills them in.
Change-Id: Ie979537abed226e945cf1918b3ee240ae78ee24e
jenkins-bot [Tue, 23 Apr 2019 17:01:11 +0000 (17:01 +0000)]
Merge "GlobalFunctions: Hard deprecate wfGetLBFactory() function"
jenkins-bot [Tue, 23 Apr 2019 16:40:53 +0000 (16:40 +0000)]
Merge "Relax SpecialPageFatalTest about deprecation notices"
Derick Alangi [Tue, 23 Apr 2019 15:42:33 +0000 (16:42 +0100)]
GlobalFunctions: Hard deprecate wfGetLBFactory() function
Usage of this function has almost disappeard from both core and
all mediawiki extensions. Kill this function in MW 1.35.
Depends-On: Id415d70aa0090c01ea04c3156aecd76caa8e83f8
Change-Id: I95f42b1631caf5ae026b9b7a3ced277bf9fa0608
Brad Jorsch [Tue, 16 Apr 2019 17:45:32 +0000 (13:45 -0400)]
Add STRAIGHT_JOIN to ApiQueryLogEvents and LogPager to avoid planner oddness
For some unknown reason, when the `actor` table has few enough rows (or
few enough compared to `logging`) MariaDB 10.1.37 decides it makes more
sense to fetch everything from `actor` + `logging` and filesort rather than
fetching the limited number of rows from `logging`.
We can work around it by telling it to not reorder the query.
Bug: T220999
Bug: T221458
Change-Id: I9da981c09f18ba72efeeb8279aad99eb21af699a
jhsoby [Wed, 3 Apr 2019 15:53:57 +0000 (17:53 +0200)]
Capitalize native name of Western Armenian
Language names in Western Armenian start with capital letters.
Bug: T219975
Change-Id: Ic4e1c8ce395324a0e68a2212576fcfbc3b22bb2f
Ed Sanders [Fri, 19 Apr 2019 13:41:12 +0000 (14:41 +0100)]
Gallery slideshow: Remove excess margin on controls
Bug: T196722
Change-Id: I09764802a9b5b3739b53933b9d74edc42ee38986
Ed Sanders [Fri, 19 Apr 2019 13:36:33 +0000 (14:36 +0100)]
Gallery: Refactor CSS as LESS
Change-Id: I42669a3445113cbbe09a58cd7524dea25c03b8a0
Ed Sanders [Fri, 19 Apr 2019 13:08:07 +0000 (14:08 +0100)]
Gallery slideshow: Improve missing image and error handling
Change-Id: I6aae5801178aa66fc40d40b9dec239a34b0ee029
Fomafix [Mon, 25 Mar 2019 06:16:21 +0000 (07:16 +0100)]
Remove unused wgUploadWarningObj.keypress
The global object wgUploadWarningObj.keypress was introduced in
80991043
and is now unused.
The unmaintained extension MultiUpload uses wgUploadWarningObj.keypress
but this is an old copy of upload.js
Change-Id: I19974b015386e4139ea1d1c9289cef535f295c28
jenkins-bot [Tue, 23 Apr 2019 08:57:59 +0000 (08:57 +0000)]
Merge "Define index types as strings"
jenkins-bot [Tue, 23 Apr 2019 03:13:00 +0000 (03:13 +0000)]
Merge "Remove references to field rev_text_id"
Bill Pirkle [Tue, 2 Apr 2019 14:37:55 +0000 (09:37 -0500)]
Remove references to field rev_text_id
Field rev_text_id is being retired as part of MCR Schema Migration.
Remove references to this field from maintenance scripts.
Bug: T198341
Change-Id: I43ab93c44cbd0a2a2479baf848f50348e1e4762b
Gilles Dubuc [Wed, 3 Apr 2019 07:06:38 +0000 (09:06 +0200)]
Make the ratio of requests getting Priority Hints configurable
This will allow to create 2 separate populations in
order to verify the effect of the hint.
It's fine if it's not exactly balanced in practice,
what matters is getting a significant amount of
traffic for both scenarios (origin trial is enabled +
an image is given high prio/origin trial is enabled +
no image is given special treatment).
Bug: T216499
Change-Id: I373960b2bed8437c2e97e6d729d43aff6901046c
C. Scott Ananian [Mon, 22 Apr 2019 16:47:48 +0000 (12:47 -0400)]
Allow <figure-inline> attributes through Sanitizer
Parsoid uses <figure-inline> for inline figures. The intention is to
transition core to use <figure> and <figure-inline> as well in the
future (T118517). As a first step (and to keep Parsoid and the legacy
parser in sync) allow <figure-inline> attributes in the Sanitizer.
Note that this does not allow <figure-inline> in wikitext,
since neither <figure> nor <figure-inline> is on the
getRecognizedTagData() list.
Bug: T51097
Bug: T118517
Bug: T118520
Change-Id: I5248717739bef0f7106c2bcf0b4a15acbc3c9a68
C. Scott Ananian [Mon, 22 Apr 2019 16:40:43 +0000 (12:40 -0400)]
Synchronize allowed attributes for <audio> with Parsoid/TimedMediaHandler
We synchronized the allowed attributes for <video> in
4e7483ffd31dd05c11b16bf37552c25ed648bd0a but then decided to use the
<audio> tag for audio media in Parsoid commit
5f3dbdc8794f2605101609f28e679df29a0387bc and updated its Sanitizer,
but never updated core to match.
Bug: T163583
Bug: T133673
Change-Id: Iefcbead2f335949eb45e2880861fd9473b810367
Derick Alangi [Sun, 7 Apr 2019 13:12:40 +0000 (14:12 +0100)]
parser: Remove deprecated Parser class attribute $mUniqPrefix
This variable was deprecated in 1.26 and per a quick search using
Code Search: https://codesearch.wmflabs.org/search/?q=mUniqPrefix&i=nope&files=&repos=
it's no longer used. Hence, removed.
Change-Id: Ic8f939dde3ea511e8e46faf0f1b212d3db2d80cd
Translation updater bot [Mon, 22 Apr 2019 07:01:51 +0000 (09:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5d5889f6c669fe3f8600b398baf88501c95e2a28
jenkins-bot [Mon, 22 Apr 2019 03:35:58 +0000 (03:35 +0000)]
Merge "Add support for new Japanese era name "Reiwa""
Zoranzoki21 [Sat, 20 Apr 2019 22:38:11 +0000 (00:38 +0200)]
Split ApiErrorFormatter.php to have one class in one file
Change-Id: I5c6904e32f9bc7fe3aac511c56b03757bfde15a9
jenkins-bot [Sun, 21 Apr 2019 20:18:36 +0000 (20:18 +0000)]
Merge "registration: Deprecate ExtensionRegistry->load() in favor of ->queue()"
jenkins-bot [Sun, 21 Apr 2019 20:18:30 +0000 (20:18 +0000)]
Merge "registration: Add release notes for environment abilities"
jenkins-bot [Sun, 21 Apr 2019 15:55:10 +0000 (15:55 +0000)]
Merge "rdbms,linker: Simplify implode() with empty array"
Fomafix [Sat, 20 Apr 2019 15:23:50 +0000 (17:23 +0200)]
rdbms,linker: Simplify implode() with empty array
https://php.net/manual/en/function.implode.php#example-6071
// Empty string when using an empty array:
var_dump(implode('hello', array())); // string(0) ""
Change-Id: If6349ba914bb522129d482a714a30b889a4c9f11