From d1f9b125f9cbead6aa75cda85ce7d8704114b1b4 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 29 Dec 2015 01:34:22 -0800 Subject: [PATCH] Fix some FileOpBatch IDEA errors Change-Id: Idd670054b2e257255da18bb8e7048ea9041be269 --- includes/filebackend/FileOpBatch.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/filebackend/FileOpBatch.php b/includes/filebackend/FileOpBatch.php index faa1314422..95a78977f0 100644 --- a/includes/filebackend/FileOpBatch.php +++ b/includes/filebackend/FileOpBatch.php @@ -49,7 +49,7 @@ class FileOpBatch { * - a) unexpected operation errors occurred (network partitions, disk full...) * - b) significant operation errors occurred and 'force' was not set * - * @param array $performOps List of FileOp operations + * @param FileOp[] $performOps List of FileOp operations * @param array $opts Batch operation options * @param FileJournal $journal Journal to log operations to * @return Status @@ -147,6 +147,7 @@ class FileOpBatch { protected static function runParallelBatches( array $pPerformOps, Status $status ) { $aborted = false; // set to true on unexpected errors foreach ( $pPerformOps as $performOpsBatch ) { + /** @var FileOp[] $performOpsBatch */ if ( $aborted ) { // check batch op abort flag... // We can't continue (even with $ignoreErrors) as $predicates is wrong. // Log the remaining ops as failed for recovery... @@ -157,6 +158,7 @@ class FileOpBatch { } continue; } + /** @var Status[] $statuses */ $statuses = array(); $opHandles = array(); // Get the backend; all sub-batch ops belong to a single backend -- 2.20.1