Sam Reed [Fri, 14 Jan 2011 22:37:12 +0000 (22:37 +0000)]
Fix indenting, rearrange some where statements
Alexandre Emsenhuber [Fri, 14 Jan 2011 21:54:29 +0000 (21:54 +0000)]
Added ArticleViewFooter hook to allow extensions adding additional items to the footer of normal views
Alexandre Emsenhuber [Fri, 14 Jan 2011 21:42:38 +0000 (21:42 +0000)]
Stylise Setup.php
Raimond Spekking [Fri, 14 Jan 2011 21:37:20 +0000 (21:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-14 20:51:00 UTC)
Sam Reed [Fri, 14 Jan 2011 21:24:42 +0000 (21:24 +0000)]
Remove ancient comment, collapse if, move USE INDEX into if further down doing the exact same
Sam Reed [Fri, 14 Jan 2011 21:15:12 +0000 (21:15 +0000)]
Followup r80324, add type property description
Sam Reed [Fri, 14 Jan 2011 21:08:08 +0000 (21:08 +0000)]
Start of bug 24650 Fix API to work with categorylinks changes
Addition of a type field for filtering (default is "all" ie no filter)
Adding of type to props, to allow it to be outputted
Antoine Musso [Fri, 14 Jan 2011 20:43:30 +0000 (20:43 +0000)]
Remove debugging issue in user preferences
'tototo' message key does not exist that made the message dropped.
Could have used null as a value but it looks nicer to just set
the value.
Per CR on r80281
Sam Reed [Fri, 14 Jan 2011 20:43:14 +0000 (20:43 +0000)]
* (bug 26733) Wrap initial table creation in transaction
Antoine Musso [Fri, 14 Jan 2011 16:53:36 +0000 (16:53 +0000)]
bug 10158 : do not mention allowing others to contact you if $wgEnableUserEmail=false
This required to tweak HTMLForm to support an array of message keys
for help message. I could reuse help-message but since this helper
also supports array, I created an additional helper for array of
messages.
To test use variations of $wgEnableUserEmail and $wgEmailConfirmToEdit.
Path adapted from jopiswezggzmw at mailinator dot com
Antoine Musso [Fri, 14 Jan 2011 15:08:41 +0000 (15:08 +0000)]
use require( RUN_MAINTENANCE_IF_MAIN ) as per r80205
fix review on r80269
Antoine Musso [Fri, 14 Jan 2011 14:46:58 +0000 (14:46 +0000)]
lame benchmark of if/elseif/else versus switch/case/default
if is faster :
$ php bench_if_switch.php --count 20000
20000 times: function bench_if_switch->doElseIf() :
204.64ms ( 0.01ms each)
20000 times: function bench_if_switch->doSwitch() :
272.98ms ( 0.01ms each)
Chad Horohoe [Fri, 14 Jan 2011 13:25:14 +0000 (13:25 +0000)]
Fix for r80248: undefined variable.
Daniel Friesen [Fri, 14 Jan 2011 11:36:37 +0000 (11:36 +0000)]
Fix remainder of the accidental ->empty() calls I used when converting wfEmptyMsg into Message::exists() calls.
Siebrand Mazeland [Fri, 14 Jan 2011 11:14:48 +0000 (11:14 +0000)]
fix syntax terror.
Daniel Friesen [Fri, 14 Jan 2011 10:51:05 +0000 (10:51 +0000)]
Implement Message::isBlank and Message::isDisabled.
And while we're at it... update a random assortment of code using wfEmptyMsg to use the new wfMessage class and our exists/isBlank/isDisabled methods.
Daniel Friesen [Fri, 14 Jan 2011 09:28:34 +0000 (09:28 +0000)]
Fix r79383, I used Message->plain() under the impression it was the proper replacement for wfMsg when Message->text() was actually the correct method to use.
Daniel Friesen [Fri, 14 Jan 2011 08:32:10 +0000 (08:32 +0000)]
Fix bug 14267 by adding support for a MediaWiki:Mainpage-nstab.
Additionally, *cough* *cough*:
* Add a Title::isMainPage helper for the fairly common $title->equals( Title::newMainPage() ); test.
* Update wfMessageFallback to also accept an array of message keys instead of requiring them listed as arguments to the function.
* Move the bulk of wfMessageFallback code into Message.php instead of leaving it in GlobalFunctions.php
* Change the wfMessageFallback implementation so that the Message class handles the fallbacks themselves eliminating any side effects caused by the fact that wfEmptyMsg always used usedb=false, language=userlang when one might actually use a different language or usedb setting in the message object that actually returned the text (this may be considered a wfEmptyMsg regression in 1.18).
* Make blank "" message contents fallback like nonexistant messages do.
* Re use the new tabAction array handling used to support mainpage-nstab in the talk and view tabs instead of making wfEmptyMsg calls directly in SkinTemplate.
Niklas Laxström [Fri, 14 Jan 2011 07:54:28 +0000 (07:54 +0000)]
Follow-up r80192, tweak docs
Jure Kajzer [Fri, 14 Jan 2011 07:05:21 +0000 (07:05 +0000)]
* changed variable list as per comment on r79954 left only wgDBtype
* all other variables get set trough ->getGlobalNames
* could somone test this on mysql, postgres and sqlite ... it should work, but to be sure
Daniel Friesen [Fri, 14 Jan 2011 02:15:12 +0000 (02:15 +0000)]
Support talk page tab messages like MediaWiki:Nstab-user_talk. Like the MediaWiki:Nstab-main MediaWiki:Nstab-user etc... we already support.
Chad Horohoe [Fri, 14 Jan 2011 02:13:30 +0000 (02:13 +0000)]
Followup r80205: scripts using commandLine.inc were failing the shouldExecute() check due to extra require()s.
Scripts using this entry point cannot be included standalone for uses as classes, they will always execute.
But then again, if you're not subclassing Maintenance then why are you bothering to write a class in a command line script?
Siebrand Mazeland [Fri, 14 Jan 2011 01:30:13 +0000 (01:30 +0000)]
Fix incorrect translations.
Trevor Parscal [Fri, 14 Jan 2011 00:56:53 +0000 (00:56 +0000)]
Removed redundant padding rule added in r80106.
Trevor Parscal [Fri, 14 Jan 2011 00:55:36 +0000 (00:55 +0000)]
Cleaned up some comments that were in the wrong places, missing, or misleading. Added more information about the CSS hacks being used for IE6 support. Merged some rules that were needlessly broken up into multiple sections.
Krinkle [Fri, 14 Jan 2011 00:46:02 +0000 (00:46 +0000)]
whitespace clean up in shared.css
Krinkle [Fri, 14 Jan 2011 00:39:51 +0000 (00:39 +0000)]
Oops, FF2 doesn't support inline-block display. Restoring that one.
FF2 ignores the latter display:inline-block and sticks to the -moz-inline-box
(Follow-up r78232,r 80214)
Krinkle [Fri, 14 Jan 2011 00:34:06 +0000 (00:34 +0000)]
Removing redundant line (Follow-up r78232)
<code>
ul.gallery, li.gallerybox {
display: inline-block;
</code>
the display of ul.gallery is overwritten later.
the display of li.gallery is overwriting an earlier one.
Shouldn't change anything other then having one line less
Chad Horohoe [Thu, 13 Jan 2011 23:45:26 +0000 (23:45 +0000)]
Narrow the <textarea> so it doesn't get pushed below the right navbar
Derk-Jan Hartman [Thu, 13 Jan 2011 23:43:34 +0000 (23:43 +0000)]
Follow up r80164. Define explicit direction on content and noflip on image thumbs. (like vector/screen.css)
Chad Horohoe [Thu, 13 Jan 2011 22:58:55 +0000 (22:58 +0000)]
Fix concern raised by Brion in r74108 (but has really existed since the maintenance rewrite). Right now, including a maintenance script causes it to execute. This is bad when you want to reuse the particular class but not have it start executing all by itself.
Until now, we relied on setting MW_NO_SETUP which was a) hacky, b) irreversable, and c) likely to be forgotten if you didn't use one of the wrappers like runChild().
Instead, move the freaky magic to doMaintenance and have *it* check if it's in a specific call stack that indicates this is being run from the file scope and should be executed. Rename DO_MAINTENANCE to RUN_MAINTENANCE_IF_MAIN so it's nice and clear what magic happens behind the require_once().
Chad Horohoe [Thu, 13 Jan 2011 22:48:09 +0000 (22:48 +0000)]
More hyphen consistency, bug 26685
Daniel Friesen [Thu, 13 Jan 2011 22:42:05 +0000 (22:42 +0000)]
Fix bug 26034; Make the View / Read tab in content_navigation style tabs (skins like Vector) stay selected when on &action=purge.
Daniel Friesen [Thu, 13 Jan 2011 22:20:04 +0000 (22:20 +0000)]
Followup r80192 which had an unclosed comment causing some php notices resulting from hidden var statements.
Mark A. Hershberger [Thu, 13 Jan 2011 22:09:34 +0000 (22:09 +0000)]
Follow up r75662 and r67090 — use UTF-8 minus instead of HTML entity
Sam Reed [Thu, 13 Jan 2011 22:08:13 +0000 (22:08 +0000)]
Fixing up spaces to tabs in r80192
Removing trailing whitespace
Daniel Friesen [Thu, 13 Jan 2011 22:06:48 +0000 (22:06 +0000)]
Fix documentation for the SkinTemplateToolboxEnd hook which has a $sk (QuickTemplate) argument rather than the $tools array it says it has.
Antoine Musso [Thu, 13 Jan 2011 21:08:59 +0000 (21:08 +0000)]
OutputPage properties documentation
This is following a pair session with Zak Greant on november 12th 2010.
Please review, ammend and commit your changes if you have anything useful
to add.
Please note you will find some humoristics quotes.
Raimond Spekking [Thu, 13 Jan 2011 21:04:12 +0000 (21:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-13 20:41:00 UTC)
Sam Reed [Thu, 13 Jan 2011 18:04:30 +0000 (18:04 +0000)]
Followup r80122, protected, just incase it's needed..
Platonides [Thu, 13 Jan 2011 17:51:25 +0000 (17:51 +0000)]
Mark as needing a Database, as noted in r79532 CR.
It is needed for calling getServerVersion() to provide dbversion
Platonides [Thu, 13 Jan 2011 17:43:45 +0000 (17:43 +0000)]
Spacing
Platonides [Thu, 13 Jan 2011 17:35:54 +0000 (17:35 +0000)]
Allow to disable the preprocessor cache with $wgPreprocessorCacheThreshold = false
Platonides [Thu, 13 Jan 2011 17:32:42 +0000 (17:32 +0000)]
I had this parser comparer in my working copy since the summer.
Platonides [Thu, 13 Jan 2011 17:30:27 +0000 (17:30 +0000)]
Improve a preprocessor comment
Roan Kattouw [Thu, 13 Jan 2011 14:42:19 +0000 (14:42 +0000)]
Coerce mtimes to TS_UNIX before outputting them, and fix a wrong timestamp format in ResourceLoaderUserModule. This should fix bug 26704
Derk-Jan Hartman [Thu, 13 Jan 2011 11:39:11 +0000 (11:39 +0000)]
Remove rtl modes from Print stylesheet, since ResourceLoader now does this itself.
Fixes bug 26694 and relates to r65923
Derk-Jan Hartman [Thu, 13 Jan 2011 11:28:35 +0000 (11:28 +0000)]
Convert simple skin to Resource loader.
I removed all of the useroptions generators that were dupe with resourceloaderuseroptions.
The 'highlightbroken' option differs from what is in resourceloaderuseroptions and still remains to be ported.
Bugzilla #26649
Chad Horohoe [Thu, 13 Jan 2011 00:12:23 +0000 (00:12 +0000)]
Return something too
Chad Horohoe [Thu, 13 Jan 2011 00:11:02 +0000 (00:11 +0000)]
Fix broken fileExistsBatch() in ForeignAPIRepo since r51673
Platonides [Wed, 12 Jan 2011 23:07:20 +0000 (23:07 +0000)]
Follow up r47852. Unlike forkWorkers(), the start() method doesn't get the $procs parameter.
Sam Reed [Wed, 12 Jan 2011 23:01:47 +0000 (23:01 +0000)]
Spaces to tabs
Raimond Spekking [Wed, 12 Jan 2011 21:33:03 +0000 (21:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-12 21:05:00 UTC)
Chad Horohoe [Wed, 12 Jan 2011 21:28:59 +0000 (21:28 +0000)]
Fix undefined variable from r79828
Sam Reed [Wed, 12 Jan 2011 21:21:32 +0000 (21:21 +0000)]
61 uses of $this->opts in SpecialContributions, so explicitally defining variable in class
Roan Kattouw [Wed, 12 Jan 2011 21:01:04 +0000 (21:01 +0000)]
Fix properties in r80112
Roan Kattouw [Wed, 12 Jan 2011 20:58:36 +0000 (20:58 +0000)]
Fix issue with missing keys in $wgFileExtensions caused by an array_diff() somewhere. Doesn't seem needed on any of the other vars at first glance
Trevor Parscal [Wed, 12 Jan 2011 20:43:23 +0000 (20:43 +0000)]
Fixed IE bug, you must use html:msg for the msg elements that jquery.localize uses to translate things otherwise IE chokes when you insert them cause it doesn't know about the msg element.
Trevor Parscal [Wed, 12 Jan 2011 20:04:58 +0000 (20:04 +0000)]
Fixed suggestions positioning in IE6
Trevor Parscal [Wed, 12 Jan 2011 20:01:52 +0000 (20:01 +0000)]
Added compressed version of csshover 3.11. Also fixed major issue where including it at the bottom with the scripts caused it to be included too late, and thus not even be used. Now we are adding it through OutputPage::addHeadItem.
Trevor Parscal [Wed, 12 Jan 2011 19:37:06 +0000 (19:37 +0000)]
Fixed positioning of search icon in IE6, and other browsers as well.
Trevor Parscal [Wed, 12 Jan 2011 19:20:51 +0000 (19:20 +0000)]
Fixed watch icon positioning in IE6. Converted PNGs to 8bit to improve appearance in older browsers.
Sam Reed [Wed, 12 Jan 2011 19:03:59 +0000 (19:03 +0000)]
Per CR on r75575, remove array_keys() as getModuleNames has array_key'd the returned stuffs
Chad Horohoe [Wed, 12 Jan 2011 13:17:36 +0000 (13:17 +0000)]
Fix key name
Alexandre Emsenhuber [Wed, 12 Jan 2011 12:50:46 +0000 (12:50 +0000)]
Set $mRevision to null by default so we don't need the isset() call
Chad Horohoe [Wed, 12 Jan 2011 09:59:55 +0000 (09:59 +0000)]
(bug 26688) Proper warning message is not displayed for the blank 'Database host'
Chad Horohoe [Wed, 12 Jan 2011 09:00:08 +0000 (09:00 +0000)]
(bug 26687) Error msg needs full stop
Chad Horohoe [Wed, 12 Jan 2011 08:57:53 +0000 (08:57 +0000)]
DB name can have hyphens (fixed in r79767), bug 26685 pointed out the message discrepancy
Chad Horohoe [Wed, 12 Jan 2011 08:53:56 +0000 (08:53 +0000)]
Fix for r79741, setTargetLanguage and setUserLang want an object and string, respectively. Fixes bug 26686
Sam Reed [Wed, 12 Jan 2011 02:20:41 +0000 (02:20 +0000)]
Fix another typo in r80075
Sam Reed [Wed, 12 Jan 2011 02:19:09 +0000 (02:19 +0000)]
Fix typo from r80075
Rename table variable
Sam Reed [Wed, 12 Jan 2011 02:16:56 +0000 (02:16 +0000)]
Follwup r75575, honour table prefixes. Bad Roan ;)
Sam Reed [Wed, 12 Jan 2011 02:12:53 +0000 (02:12 +0000)]
Followup r75575
reedy@ubuntu64-esxi:~/mediawiki/trunk/phase3/maintenance$ php cleanupRemovedModules.php
Fatal error: Call to undefined method ResourceLoader::getModules() in /home/reedy/mediawiki/trunk/phase3/maintenance/cleanupRemovedModules.php on line 40
Sam Reed [Wed, 12 Jan 2011 01:17:31 +0000 (01:17 +0000)]
Not sure why I originally used array_key_exists(). Switch for isset()
Platonides [Wed, 12 Jan 2011 00:30:42 +0000 (00:30 +0000)]
Follow up r79845. No need to keep $wgCustomConvertCommand there.
Sam Reed [Wed, 12 Jan 2011 00:29:17 +0000 (00:29 +0000)]
Document return type.
Explicit class member variable definition
Sam Reed [Wed, 12 Jan 2011 00:24:25 +0000 (00:24 +0000)]
initFromQueryResult doesn't use the $db parameter.
Private method, updated callers to not pass it.
Platonides [Wed, 12 Jan 2011 00:11:11 +0000 (00:11 +0000)]
Follow up r80025.
The space is actually used inside extensions, such as Maps, covertly called as 'display_map' into
Validator, then converted into 'display map' by getName().
Trevor Parscal [Tue, 11 Jan 2011 23:15:26 +0000 (23:15 +0000)]
Fixed logic error - all tests were passing... :(
Trevor Parscal [Tue, 11 Jan 2011 23:10:12 +0000 (23:10 +0000)]
Reverts part of r80036 - jquery.client is already depended on by mediaWiki.util - which is laoded initially as well.
Sean Colombo [Tue, 11 Jan 2011 22:20:56 +0000 (22:20 +0000)]
A wfProfileOut was missing (which messed up profiling sometimes). Thanks to Owen Davis for finding this.
Trevor Parscal [Tue, 11 Jan 2011 21:55:45 +0000 (21:55 +0000)]
Fixed logic error that caused the test to always pass.
Trevor Parscal [Tue, 11 Jan 2011 20:56:15 +0000 (20:56 +0000)]
Included client in the initial payload. Restored functionality that used to exist in this plug-in that adds classes to the document's HTML element for browser and platform information. This will help reduce CSS hacks to only be used for non-JS rendered items.
Derk-Jan Hartman [Tue, 11 Jan 2011 20:22:05 +0000 (20:22 +0000)]
Repair quickbar of standard and cologneblue skins to work under Resourceloader.
Refs bug #26649
Factoring this out into seperate stylesheets seemed silly. Instead just moved
that last css line from skins/common/quickbar.css and skins/common/quickbar-right.css
inline as well.
Sam Reed [Tue, 11 Jan 2011 18:57:28 +0000 (18:57 +0000)]
Remove "Heldergeovane" from both PT and PT_BR message files, per request on TW
Renamed user already exists as "Helder.wiki"
Platonides [Tue, 11 Jan 2011 18:38:32 +0000 (18:38 +0000)]
Forbid '<', '>', ' ', '\n', '\r' in parser hook names.
Registering a tag hook with < or > on its name resulted in a UNIQ marker.
Spaces, tabs or LF do work (CR fails due to the CR->LF transformation),
but it's easier to also forbid them, just as they are not allowed in other
markup languages.
Platonides [Tue, 11 Jan 2011 18:37:15 +0000 (18:37 +0000)]
Add tests for parser tag hooks.
Chad Horohoe [Tue, 11 Jan 2011 16:02:56 +0000 (16:02 +0000)]
Fix a few doQuery() -> query()
Chad Horohoe [Tue, 11 Jan 2011 15:02:59 +0000 (15:02 +0000)]
Fix callbacks for the final time so it actually works per documentation.
Other minor postgres fixes
Niklas Laxström [Tue, 11 Jan 2011 14:30:03 +0000 (14:30 +0000)]
No space after unary minus
Niklas Laxström [Tue, 11 Jan 2011 14:28:35 +0000 (14:28 +0000)]
Spell false with small latter
Niklas Laxström [Tue, 11 Jan 2011 14:27:15 +0000 (14:27 +0000)]
Use same wording as in skintemplate
Chad Horohoe [Tue, 11 Jan 2011 14:00:47 +0000 (14:00 +0000)]
Fix copy+paste mistake from r79989
Chad Horohoe [Tue, 11 Jan 2011 13:54:05 +0000 (13:54 +0000)]
Fix callback issue noted in r79989 (broken in r78774).
$this makes a difference.
I'm an idiot.
Roan Kattouw [Tue, 11 Jan 2011 13:51:49 +0000 (13:51 +0000)]
Followup r80003: array_unique() preserves keys, so we got module arrays that looked like {"0": "ext.liquidThreads", "58": "mediawiki.legacy.wikibits", "59": "mediawiki.util", ... } . To prevent this from happening, use array_values() to reindex the arrays
Niklas Laxström [Tue, 11 Jan 2011 13:46:31 +0000 (13:46 +0000)]
rm stray tab
Roan Kattouw [Tue, 11 Jan 2011 13:41:40 +0000 (13:41 +0000)]
Apply array_unique() to module lists in OutputPage, should prevent lots of duplicate 'ext.liquidThreads' elements in the module array reported by thedj
Alexandre Emsenhuber [Tue, 11 Jan 2011 13:08:28 +0000 (13:08 +0000)]
Seems there was a logic error in r80001 :)
Alexandre Emsenhuber [Tue, 11 Jan 2011 13:04:55 +0000 (13:04 +0000)]
Simplify a bit:
* replaced calls to Article::getLatest() by Title::getLatestRevID()
* introduced Skin::isRevisionCurrent()
* made checks on Skin::pageStats() more coherent
Raimond Spekking [Tue, 11 Jan 2011 07:37:42 +0000 (07:37 +0000)]
Follow-up r79964: Use the existing message 'parentheses' instead of introducing an identical one.