jenkins-bot [Mon, 10 Jun 2019 21:28:20 +0000 (21:28 +0000)]
Merge "mediawiki.Title: Remove dead code and streamline newFromUserInput()"
jenkins-bot [Mon, 10 Jun 2019 21:23:33 +0000 (21:23 +0000)]
Merge "foreign-resources.yaml: Add jquery.chosen"
jenkins-bot [Mon, 10 Jun 2019 20:27:02 +0000 (20:27 +0000)]
Merge "watcheditem: Do not create the same TitleValue object twice"
jenkins-bot [Mon, 10 Jun 2019 20:19:28 +0000 (20:19 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Mon, 10 Jun 2019 20:18:53 +0000 (20:18 +0000)]
Merge "Fix documentation of Maintenance::updateSearchIndex"
Translation updater bot [Mon, 10 Jun 2019 20:18:44 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I695bfdbedde246b905e0fb7573a4070ffb0e4f78
Umherirrender [Fri, 7 Jun 2019 14:28:31 +0000 (16:28 +0200)]
watcheditem: Do not create the same TitleValue object twice
Minor optimization in getWatchedItemsForUser(). Follows-up
7c12727fff0.
Change-Id: I29f40f2c09c334eea33c7aaf351e1f1a93de9c13
jenkins-bot [Mon, 10 Jun 2019 19:59:10 +0000 (19:59 +0000)]
Merge "Remove RELEASE-NOTES-1.33"
Adam Wight [Thu, 6 Jun 2019 10:55:32 +0000 (12:55 +0200)]
selenium: Skip flaky Rollback test
Sometimes the element doesn't appear. This is breaking during gate-and-submit,
so skipping until it can be fixed properly.
Bug: T219440
Change-Id: I7286eb5499e34146acf5da3180b665436569a18c
jenkins-bot [Mon, 10 Jun 2019 15:00:12 +0000 (15:00 +0000)]
Merge "resourceloader: Add coverage for DerivativeRLContext::getDirection inheritance"
Timo Tijhof [Mon, 10 Jun 2019 14:25:24 +0000 (15:25 +0100)]
resourceloader: Add coverage for DerivativeRLContext::getDirection inheritance
This was the only case not covered, possibly due to a copy-paste
mistake when writing the test.
Change-Id: I1d01a1191da15162f301cea4082c0f1f481cece7
Derick Alangi [Sun, 26 May 2019 21:46:15 +0000 (22:46 +0100)]
Use AtEase::quietCall() instead of Wikimedia\quietCall()
Wikimedia\quietCall() is deprecated and AtEase is here for use.
I would have loved to do restoreWarnings() and suppressWarnings()
in this same patch set but will continue the work for a later patch.
Bug: T182273
Change-Id: I43e3a5f378c99b5c40883b35ba133cbd126fc433
jenkins-bot [Mon, 10 Jun 2019 13:48:27 +0000 (13:48 +0000)]
Merge "tidy: Remove unused var and define $parts var to avoid undefined error"
jenkins-bot [Mon, 10 Jun 2019 13:44:50 +0000 (13:44 +0000)]
Merge "jquery.suggestions: Use document.documentElement.clientWidth"
jenkins-bot [Mon, 10 Jun 2019 13:41:20 +0000 (13:41 +0000)]
Merge "jquery.suggestions: Use Object.create( null )"
jenkins-bot [Mon, 10 Jun 2019 13:40:09 +0000 (13:40 +0000)]
Merge "jquery.suggestions: Remove public object $.suggestions"
Derick Alangi [Mon, 15 Apr 2019 16:07:31 +0000 (17:07 +0100)]
tidy: Remove unused var and define $parts var to avoid undefined error
Remove unused variable $parent in RemexCompatMunger::comment(). Also,
RemexMungerData::dump() could have a possibility that all checks fail
and $parts is not defined. There are two ways we can handle this, i.e.
either by doing `$parts = []`(setting $parts to an empty array) or by
safe guarding using an `isset()` check.
This patch uses the former so that $parts is defined and can be used
below in the code.
Change-Id: I4d601a6fe36a1dce0945686cb9880336d08338be
Fomafix [Wed, 29 May 2019 22:56:46 +0000 (00:56 +0200)]
jquery.suggestions: Use Object.create( null )
Object.create( null ) creates an Object without predefined methods like
hasOwnProperty or constructor. This allow to use
key in object
instead of
Object.prototype.hasOwnProperty.call( object, key )
even if the key is 'constructor'.
Change-Id: I6ef9019309022a2a990deda685ba71ca61b86df3
jenkins-bot [Mon, 10 Jun 2019 05:49:20 +0000 (05:49 +0000)]
Merge "Drop SpecialPage::getTitle()"
jenkins-bot [Sun, 9 Jun 2019 20:13:23 +0000 (20:13 +0000)]
Merge "registration: Deprecate ParserTestFiles in extension.json"
jenkins-bot [Sun, 9 Jun 2019 17:33:40 +0000 (17:33 +0000)]
Merge "objectcache: Make BagOStuff::getCurrentTime() public"
Lucas Werkmeister [Sat, 8 Jun 2019 16:30:20 +0000 (18:30 +0200)]
objectcache: Make BagOStuff::getCurrentTime() public
If another cache wraps a BagOStuff, it may need to know about the
BagOStuff’s notion of the current time, which may be mocked and differ
from the real time.
Change-Id: I40f4085d4cf549314394d3140cccb1fe4e48690a
jenkins-bot [Sun, 9 Jun 2019 16:54:59 +0000 (16:54 +0000)]
Merge "build: Set opcache.enable_cli=1 for Travis CI builds"
RazeSoldier [Thu, 6 Jun 2019 08:57:51 +0000 (08:57 +0000)]
build: Set opcache.enable_cli=1 for Travis CI builds
Make test process faster. The code refer <https://docs.travis-ci.com/user/languages/php/>.
Bug: T225078
Change-Id: I8c4e87f75108cfbece17506aa630b205aabaab4b
jenkins-bot [Sun, 9 Jun 2019 12:38:45 +0000 (12:38 +0000)]
Merge "Adjust type hints in database related classes"
jenkins-bot [Sun, 9 Jun 2019 12:16:37 +0000 (12:16 +0000)]
Merge "Use IResultWrapper in LinkBatch and BacklinkCache"
RazeSoldier [Sun, 9 Jun 2019 04:40:01 +0000 (04:40 +0000)]
Drop SpecialPage::getTitle()
Bug: T220656
Change-Id: I85935901a2101f8e5fa5211e54c26f31f9ff0aa1
jenkins-bot [Sat, 8 Jun 2019 22:41:47 +0000 (22:41 +0000)]
Merge "Print: Add padding on pre elements"
Translation updater bot [Sat, 8 Jun 2019 20:09:28 +0000 (22:09 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic243e28c02a6f791d269278c08a4deee105721c2
Derk-Jan Hartman [Sat, 8 Jun 2019 20:04:10 +0000 (22:04 +0200)]
Print: Add padding on pre elements
This is inline with their non-print styling and avoids the border and
the glyph being so close that it affects readability.
Bug: T225188
Change-Id: I0dcf09742483e28535d1d48641ccfba359e9f377
jenkins-bot [Sat, 8 Jun 2019 19:02:23 +0000 (19:02 +0000)]
Merge "Deprecate logout token on GET"
Reedy [Sat, 8 Jun 2019 12:22:12 +0000 (13:22 +0100)]
Remove RELEASE-NOTES-1.33
1.33.0-rc.0 is out, so probably not any more features being backported
It's already divered from the one in the REL1_33 branch, so has
little benefit staying in master
Change-Id: I21fa200e1c817099afa83062a357014b5481a18e
Fomafix [Wed, 5 Jun 2019 19:33:41 +0000 (21:33 +0200)]
jquery.suggestions: Use document.documentElement.clientWidth
On skins with a border and/or a margin on the <body> or the <html>
element the width of <body> is smaller than the width of the window.
Also use .appendTo( document.body ) instead of .appendTo( $( 'body' ) ).
Bug: T47668
Change-Id: I209eb6e3b95ba0fc6e7c5084242a90ca04c9e196
jenkins-bot [Sat, 8 Jun 2019 08:28:30 +0000 (08:28 +0000)]
Merge "Pass options as array to IDatabase::insert"
jenkins-bot [Fri, 7 Jun 2019 21:53:31 +0000 (21:53 +0000)]
Merge "Relax HTML sniffing checks on image upload"
Brion Vibber [Thu, 6 Jun 2019 21:54:29 +0000 (14:54 -0700)]
Relax HTML sniffing checks on image upload
Allows uploaded files to include some HTML tag strings that were
previously forbidden in the first 1k or so of the file:
* <a href
* <img
* <pre
* <table
* <title
They are now allowed as long as the IE MIME type detection heuristic
would not change their types. This should reduce the number of false
positive checks in JPEGs with EXIF data with links.
Also deprecates $wgAllowTitlesInSVG and allows it by default.
This should still protect against malformed PNG attacks on old IE
versions, though false positive checks are conceivable on PNG files
containing comments very close to the beginning of the file.
Adds $wgVerifyMimeTypeIE config var to allow disabling the IE checks
entirely, if desired, but leaves it in place by default. These are
more conservative than the checks that were removed.
Added test cases for the old IE5/6 bug and the particular sort of
JPEG metadata that struck false positives previously.
Bug: T27707
Change-Id: I66642a74fce1a1894cad67d62b0da61020db469a
Brad Jorsch [Fri, 24 May 2019 13:19:49 +0000 (09:19 -0400)]
API: Apply miser-mode namespace check for generator=redirects
Bug: T224246
Change-Id: Icad65fcc14ad91d302c8285e08d6a7ea299a90c6
Umherirrender [Fri, 7 Jun 2019 17:22:19 +0000 (19:22 +0200)]
Fix documentation of Maintenance::updateSearchIndex
Document callback as callable type and the results part as
IResultWrapper to match the implementation, which is passing return of
Database::query to this function
Change-Id: I63ee8d4907590a21ef34d0b761b8fabfe0ff2569
Umherirrender [Fri, 7 Jun 2019 17:12:35 +0000 (19:12 +0200)]
Pass options as array to IDatabase::insert
The documentation only allows arrays there
Change-Id: I00c6e47a817a70bed9a443aebc675ef4c3d6b1e5
Umherirrender [Fri, 7 Jun 2019 15:19:48 +0000 (17:19 +0200)]
Change array type on ApiQueryBase::addTables
This function results in passing its value to IDatabase::select as first
parameter $table.
The first parameter is documented as string|array, because it can take
more complex arrays:
* Joins using parentheses for grouping (since MediaWiki 1.31) may be
* constructed using nested arrays. For example,
*
* [ 'tableA', 'nestedB' => [ 'tableB', 'b2' => 'tableB2' ] ]
Update the type to allow also passing such complex arrays to this
function
ApiQueryBase::showHiddenUsersAddBlockInfo() is using this format
Change-Id: I8038243545bc1c79a1106ccc3bec7738e63c2e2e
jenkins-bot [Fri, 7 Jun 2019 08:11:27 +0000 (08:11 +0000)]
Merge "Add missing Title::newFromLinkTarget to api module compare"
jenkins-bot [Fri, 7 Jun 2019 08:05:54 +0000 (08:05 +0000)]
Merge "Fix ServiceOptions type in constructor documentation"
jenkins-bot [Fri, 7 Jun 2019 08:05:03 +0000 (08:05 +0000)]
Merge "WatchedItemStore::getWatchedItem returns a WatchedItem"
Reedy [Fri, 7 Jun 2019 01:31:44 +0000 (02:31 +0100)]
Add 1.27.7 to HISTORY
Change-Id: If41890454e3487b6b7803a1671915041c53f9561
Reedy [Fri, 7 Jun 2019 00:08:20 +0000 (01:08 +0100)]
Bring in HISTORY for 1.27.6/1.30.2/1.31.2/1.32.2
Bug: T205046
Change-Id: Ib4819bf71c22873a4b16c55b7e22d0f33aa07148
Thalia [Thu, 6 Jun 2019 21:29:02 +0000 (17:29 -0400)]
Fix spelling error in test function name
Change-Id: Ib9b83f6936a3ba86dbb7537d9cef7810c8bc36db
jenkins-bot [Thu, 6 Jun 2019 20:37:15 +0000 (20:37 +0000)]
Merge "SECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358"
jenkins-bot [Thu, 6 Jun 2019 20:37:09 +0000 (20:37 +0000)]
Merge "SECURITY: Add permission check for user is permitted to view the log type"
jenkins-bot [Thu, 6 Jun 2019 20:36:18 +0000 (20:36 +0000)]
Merge "SECURITY: Add permission check for user is permitted to view the log type"
Translation updater bot [Thu, 6 Jun 2019 20:14:43 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I33e9fe577fee1d6203e2f91d143c25b1d2291bd5
Umherirrender [Thu, 6 Jun 2019 20:10:57 +0000 (22:10 +0200)]
Add missing Title::newFromLinkTarget to api module compare
The function getArticleID is not implemented by a LinkTarget as returned
by getPageAsLinkTarget, so this needs a wrapper to create a Title
object.
ApiQueryBase::addTitleInfo also needs a Title object to call
getPrefixedText
Change-Id: I8d1b4a77da8b3ce4eaf9e7e5100a3243669f2d3e
Umherirrender [Thu, 6 Jun 2019 19:59:27 +0000 (21:59 +0200)]
Fix ServiceOptions type in constructor documentation
Change-Id: I3fcde4e484ddd6d86e4ca12dcf5977051e7f4cf2
Umherirrender [Thu, 6 Jun 2019 19:56:18 +0000 (21:56 +0200)]
Use IResultWrapper in LinkBatch and BacklinkCache
Change-Id: If96d6dfeea17e73073b78c19526787e788f7b412
jenkins-bot [Thu, 6 Jun 2019 19:34:22 +0000 (19:34 +0000)]
Merge "Log headers sent errors more usefully in thumb.php"
jenkins-bot [Thu, 6 Jun 2019 19:15:19 +0000 (19:15 +0000)]
Merge "SECURITY: Fix cache mode for (un)patrolled recent changes query"
James D. Forrester [Thu, 25 Apr 2019 21:12:52 +0000 (16:12 -0500)]
SECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358
Patch taken from https://github.com/DanielRuf/snyk-js-jquery-174006?files=1
and left in-repo. Note that this will break the foreign resources check,
which is not currently a unit test but was planned to become such soon.
Bug: T221739
Change-Id: I99c2be81c74a8f1d35c421f0ee43c75efb30a7d0
rxy [Sun, 28 Apr 2019 20:14:18 +0000 (05:14 +0900)]
SECURITY: Add permission check for user is permitted to view the log type
Bug: T222038
Change-Id: I92ec2adfd9c514b3be1c07b7d22b9f9722d24a82
rxy [Sun, 28 Apr 2019 20:04:01 +0000 (05:04 +0900)]
SECURITY: Add permission check for user is permitted to view the log type
Bug: T222036
Change-Id: I7584ee8db23a8834bbab21e355cab9857a293f72
jenkins-bot [Thu, 6 Jun 2019 18:59:45 +0000 (18:59 +0000)]
Merge "SECURITY: API: Respect $wgBlockCIDRLimit in action=block"
jenkins-bot [Thu, 6 Jun 2019 18:59:38 +0000 (18:59 +0000)]
Merge "SECURITY: rate-limit and prevent blocked users from changing email"
jenkins-bot [Thu, 6 Jun 2019 18:59:30 +0000 (18:59 +0000)]
Merge "SECURITY: blacklist CSS var()"
jenkins-bot [Thu, 6 Jun 2019 18:26:01 +0000 (18:26 +0000)]
Merge "SECURITY: Fix reauth in Special:ChangeEmail"
Lucas Werkmeister [Mon, 17 Dec 2018 13:02:39 +0000 (14:02 +0100)]
SECURITY: Fix cache mode for (un)patrolled recent changes query
Restricting the list of recent changes to patrolled, not patrolled,
autopatrolled, not autopatrolled, or unpatrolled recent changes requires
special permissions (as does displaying that status in the properties of
returned entries), but we only set the cache mode to private in the
first two cases.
Bug: T212118
Change-Id: I4c3fe6e47f80ebf97fa37875c704328d08772d26
Kunal Mehta [Fri, 13 Jul 2018 15:07:51 +0000 (08:07 -0700)]
SECURITY: API: Respect $wgBlockCIDRLimit in action=block
$wgBlockCIDRLimit states how large rangeblocks are allowed to be for IPv4
and IPv6. The API now calls SpecialBlock::validateTarget() to perform
that validation step.
As a minor thing, SpecialBlock::checkUnblockSelf() is now called twice by
the API, but that can probably be cleaned up at another time.
Tests included.
Bug: T199540
Change-Id: Ic7d60240d9ebd9580c0eb3b41e4befceab69bd81
Brian Wolff [Wed, 21 Nov 2018 16:15:28 +0000 (16:15 +0000)]
SECURITY: rate-limit and prevent blocked users from changing email
This is to counter spam where people use Special:ChangeEmail to
spam people with the confirmation email and using the username
to promote their thing
Bug: T209794
Change-Id: I8b2bd0f60c66f44c91dc78e3512a73e4237df2f3
Max Semenik [Wed, 7 Nov 2018 02:38:22 +0000 (18:38 -0800)]
SECURITY: blacklist CSS var()
Bug: T208881
Change-Id: I9a4ced2bc47eb5f96cf35e693bf5261c48acb126
Brian Wolff [Fri, 15 Jun 2018 08:19:49 +0000 (08:19 +0000)]
SECURITY: Fix reauth in Special:ChangeEmail
Previously you could bypass reauthentication by directly
POSTing to Special:ChangeEmail.
Bug: T197279
Change-Id: I674557351e0e91a8105c12ddf6cd30283aac9f7a
Reedy [Thu, 6 Jun 2019 15:14:58 +0000 (16:14 +0100)]
Add some @since tags to HeaderCallback
Change-Id: I28053418d107f4a101aa7d8a2203c6864acd311f
Gergő Tisza [Thu, 6 Jun 2019 14:21:21 +0000 (16:21 +0200)]
Log headers sent errors more usefully in thumb.php
Bug: T225197
Change-Id: Ifcb02b3d5794061f27c005b32164ac014f926357
jenkins-bot [Thu, 6 Jun 2019 14:27:28 +0000 (14:27 +0000)]
Merge "Improve return types in class MagicWordArray"
jenkins-bot [Thu, 6 Jun 2019 14:10:35 +0000 (14:10 +0000)]
Merge "Document $rows on hook ChangesListInitRows as IResultWrapper"
jenkins-bot [Thu, 6 Jun 2019 14:10:29 +0000 (14:10 +0000)]
Merge "Fix type hint for properties holding MapCacheLRU"
Umherirrender [Tue, 4 Jun 2019 19:37:54 +0000 (21:37 +0200)]
WatchedItemStore::getWatchedItem returns a WatchedItem
Follow-Up: I31e983d7ac287158101b18ad95779d83537302a2
Change-Id: I4819d6e9f919467d46b3704331a54068a50c2cfa
Adam Wight [Thu, 6 Jun 2019 10:51:03 +0000 (12:51 +0200)]
Correct name of the recommended function
Change-Id: I6b79b6a9e3d17eafdb92fd940d64e9108ff5c293
jenkins-bot [Thu, 6 Jun 2019 09:04:26 +0000 (09:04 +0000)]
Merge "Refactor buildPrevNextNavigation"
jenkins-bot [Thu, 6 Jun 2019 04:20:49 +0000 (04:20 +0000)]
Merge "Improve type hints to special page related classes"
jenkins-bot [Thu, 6 Jun 2019 02:02:29 +0000 (02:02 +0000)]
Merge "Remove DatabaseSqliteMock unit test class in favor of mocking"
jenkins-bot [Thu, 6 Jun 2019 01:46:42 +0000 (01:46 +0000)]
Merge "Improve @var on User class"
jenkins-bot [Thu, 6 Jun 2019 00:07:23 +0000 (00:07 +0000)]
Merge "Update OOUI to v0.32.1"
clarakosi [Wed, 29 May 2019 23:08:11 +0000 (19:08 -0400)]
Refactor buildPrevNextNavigation
Refactored buildPrevNextNavigation() into standalone helper class,
PrevNextNavigationRenderer, to be used by both SpecialPages and Pagers.
Bug:T207977
Change-Id: Ic49837a451f795ec203e867961ec1c69075cc91a
Aaron Schulz [Wed, 5 Jun 2019 21:25:46 +0000 (22:25 +0100)]
Remove DatabaseSqliteMock unit test class in favor of mocking
Change-Id: Id22233359df25920c335e4945e606c6c3283f2a1
jenkins-bot [Wed, 5 Jun 2019 20:51:04 +0000 (20:51 +0000)]
Merge "Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad"
Translation updater bot [Wed, 5 Jun 2019 19:58:20 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5ff3c17b7b9ee534e3efa6cdb7ce4b7b40a54d16
Umherirrender [Wed, 5 Jun 2019 18:32:05 +0000 (20:32 +0200)]
Fix type hint for properties holding MapCacheLRU
Change-Id: Ia22b1dbcde3b96b3f437a213da95b3556fa42d70
Umherirrender [Wed, 5 Jun 2019 17:19:22 +0000 (19:19 +0200)]
Improve @var on User class
Add missing @var tags with types or add missing types to @var
Change-Id: I34eb4c26d34da072465f1b162fb2d0291610f564
Umherirrender [Mon, 3 Jun 2019 17:39:57 +0000 (19:39 +0200)]
Adjust type hints in database related classes
Change from ResultWrapper to IResultWrapper
Change from mysqli_result to resource
Changed mixed to return hint of interface
Document that fieldInfo returns bool
Change-Id: I5572fd41e0e11a2bc2eb116d0c82327499ecc518
James D. Forrester [Wed, 5 Jun 2019 16:32:46 +0000 (09:32 -0700)]
Update OOUI to v0.32.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.1
Bug: T223841
Bug: T224739
Bug: T224885
Depends-On: I1e6ed138cbab66c94cd45289799302d88d22cad9
Change-Id: I72278024790829841c15dd7b3eb09fe1a98cac9c
jenkins-bot [Wed, 5 Jun 2019 15:42:04 +0000 (15:42 +0000)]
Merge "HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory"
Thalia [Fri, 24 May 2019 13:02:32 +0000 (14:02 +0100)]
Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad
Before this, DatabaseBlock:newFromTarget initialises a new block and
calls DatabaseBlock::newLoad on that instance, passing through the
target and type via that instance. However, newLoad returns a brand
new block instance. This patch makes newLoad into a static method,
with the target and type passed as method parameters.
It also separates the block-choosing logic in newLoad into a separate
method, DatabaseBlock::chooseMostSpecificBlock. Doing this (1) makes
it more transparent that Block uses two different ways to choose a
block (see also Block::chooseBlock), and (2) makes it possible to
re-use newLoad to get multiple blocks.
Also, filter out any duplicate autoblocks that are found by newLoad.
Bug: T206163
Change-Id: Iefa3aaadf2954c3b86f5c691096af31de40fae6c
daniel [Wed, 22 May 2019 20:12:11 +0000 (22:12 +0200)]
Make userLink() not fail too hard on false and null.
This works around an issue in Flow, which sometimes passes false
for a user name.
Bug: T224095
Change-Id: I14dc52f7199012dc35605f3170b06eb1719165a7
jenkins-bot [Wed, 5 Jun 2019 09:10:26 +0000 (09:10 +0000)]
Merge "Fix return type of UploadBase::check* functions"
jenkins-bot [Wed, 5 Jun 2019 08:57:05 +0000 (08:57 +0000)]
Merge "Allow int as return type of MediaHandler::isMetadataValid"
jenkins-bot [Wed, 5 Jun 2019 08:56:34 +0000 (08:56 +0000)]
Merge "Fix type to callable on FileRepo::getErrorCleanupFunction"
Kunal Mehta [Tue, 4 Jun 2019 19:45:38 +0000 (15:45 -0400)]
HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory
Change-Id: I3fddf30f1b0fc2cce79f652cb71efba119439a9f
jenkins-bot [Tue, 4 Jun 2019 20:03:38 +0000 (20:03 +0000)]
Merge "Add action=query&meta=languageinfo API module"
Translation updater bot [Tue, 4 Jun 2019 19:57:17 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I98b20ec1bd615860212c254729a20ed998a76ba1
Umherirrender [Tue, 4 Jun 2019 19:44:51 +0000 (21:44 +0200)]
Fix return type of UploadBase::check* functions
Change-Id: I37964663fc8cb63575c1e0be9c5ced489d69136e
Umherirrender [Tue, 4 Jun 2019 19:33:37 +0000 (21:33 +0200)]
Allow int as return type of MediaHandler::isMetadataValid
MediaHandler::METADATA_COMPATIBLE is a int,
which is a possible return value here
Change-Id: Ia84139ee8e09839e1f46a6d34738612dfd365415
Umherirrender [Tue, 4 Jun 2019 19:28:25 +0000 (21:28 +0200)]
Fix type to callable on FileRepo::getErrorCleanupFunction
Change-Id: Idb07fb2d6ade9eb3619ecea5516d7e9815b7bb54
Kunal Mehta [Mon, 3 Jun 2019 00:56:10 +0000 (20:56 -0400)]
Hard-deprecate SkinFactory::getDefaultInstance()
Was soft-deprecated in 1.27.
Change-Id: I5f4afefc6c439c7e8d173a844c76ccd693f9bbf1