Ryan Schmidt [Mon, 13 Oct 2008 02:18:49 +0000 (02:18 +0000)]
* re-implement r41983 (forgot to add log message). Changes made:
** <poem> handling fixes: use DoubleReplacer class instead of create_function(), moving recursiveTagParse above line-break replacements, removed strip items, updated parser tests to reflect new output when combined with <nowiki>
Brion Vibber [Mon, 13 Oct 2008 01:44:22 +0000 (01:44 +0000)]
Tweaks to r41902 "(bug 14634) Show range blocks for IPs"
* Remove the "scan range blocks" checkbox -- doing the range check is sane default behavior, and should Just Work. :)
* Paranoia SQL escaping. We may "know" that the strings will never include something escapable, but then again someone might make a mistake one day. By ensuring we escape them, we have one less thing to worry about, and one less thing to double-check every time we look at this code.
Note that a search for a particular range block currently does not turn up larger range blocks that include it, which it probably should.
Brion Vibber [Mon, 13 Oct 2008 00:08:44 +0000 (00:08 +0000)]
Back out r41786 for now "(bug 9226) Fetch restrictions properly on export"
Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/41786#c121:
Issues:
1. Restriction fetches may not be synchronous with original start in a long-running export
2. Looks like this adds an SQL query to slave for every single page
3. In case of timed-out DB connections or a dying slave, this might break a long-running dump process
Brion Vibber [Sun, 12 Oct 2008 23:14:39 +0000 (23:14 +0000)]
Revert mystery change r41983 -- no explanation of the change or its purpose.
Appears to be an attempt to remove some extra whitespace, but it's kind of unclear.
Siebrand Mazeland [Sun, 12 Oct 2008 20:02:32 +0000 (20:02 +0000)]
Localisation updates for core messages from Betawiki (2008-10-12 21:44 CEST)
Aaron Schulz [Sun, 12 Oct 2008 19:00:27 +0000 (19:00 +0000)]
Check $wgUser->useRCPatrol()
Aaron Schulz [Sun, 12 Oct 2008 17:33:24 +0000 (17:33 +0000)]
Rebuilt messages
Aaron Schulz [Sun, 12 Oct 2008 17:31:03 +0000 (17:31 +0000)]
(bug 15946) Add hidepatrolled option to Special:Watchlist
Aaron Schulz [Sun, 12 Oct 2008 17:07:09 +0000 (17:07 +0000)]
(bug 15952) Don't try to lazy populate sha1 in read-only mode
Tim Starling [Sun, 12 Oct 2008 14:29:55 +0000 (14:29 +0000)]
Add readOnlyBySection setting, to replace live hack.
Tim Starling [Sun, 12 Oct 2008 13:28:04 +0000 (13:28 +0000)]
Reverted r41655. Causes a text load on parser cache hit. Reduces parser cache hit performance especially for ES clusters. Messages not reverted on the assumption that this revert is temporary.
Siebrand Mazeland [Sun, 12 Oct 2008 11:03:44 +0000 (11:03 +0000)]
Localisation updates for core messages from Betawiki (2008-10-12 12:47 CEST)
Siebrand Mazeland [Sun, 12 Oct 2008 08:57:48 +0000 (08:57 +0000)]
Fix bug in namespace aliases definition. Was introduced in r26981
Siebrand Mazeland [Sun, 12 Oct 2008 08:55:06 +0000 (08:55 +0000)]
(bug 15947) Fix bug introduced in r41134: removed quotes
Huji [Sun, 12 Oct 2008 08:28:30 +0000 (08:28 +0000)]
Localisation updates: Adding/updating Persian translations
Ryan Schmidt [Sun, 12 Oct 2008 02:20:08 +0000 (02:20 +0000)]
Aaron Schulz [Sat, 11 Oct 2008 23:30:38 +0000 (23:30 +0000)]
(bug 15428) Fix erroneous coloring of unrelated items due to text matches. Only do the links.
Ryan Schmidt [Sat, 11 Oct 2008 21:53:44 +0000 (21:53 +0000)]
* fixes for the merged Poem extension, per comments by Tim Starling on CodeReview (r41710)
* adding <poem> tests to the parser tests file
Aaron Schulz [Sat, 11 Oct 2008 21:06:21 +0000 (21:06 +0000)]
* Make $user->invalidateCache() get the Id if needed
* Remove redundant cache clearing in renameuser
Aaron Schulz [Sat, 11 Oct 2008 17:35:38 +0000 (17:35 +0000)]
More RC UDP refactoring for bug 15276
Chad Horohoe [Sat, 11 Oct 2008 16:38:43 +0000 (16:38 +0000)]
Revert r41603, r41751 (splitting Preferences validation into its own class). Breaks a lot of things per comments on Code Review by Tim.
Tim Starling [Sat, 11 Oct 2008 13:53:00 +0000 (13:53 +0000)]
Fix freaky calling method for MovePageForm::showForm(), add docs
Greg Sabino Mullane [Sat, 11 Oct 2008 12:08:10 +0000 (12:08 +0000)]
Add column ipblocks.ipb_allow_usertalk
Greg Sabino Mullane [Sat, 11 Oct 2008 11:45:26 +0000 (11:45 +0000)]
Add index on templatelinks.tl_from
Siebrand Mazeland [Sat, 11 Oct 2008 09:14:03 +0000 (09:14 +0000)]
Rebuild messages files involved in recent reverts.
Siebrand Mazeland [Sat, 11 Oct 2008 09:06:11 +0000 (09:06 +0000)]
* Want to commit new messages? "php rebuildLanguage.php --lang=en"
* Does it give output about unknown messages? Fix it in messages.inc. Repeat cycle.
Tim Starling [Sat, 11 Oct 2008 08:28:07 +0000 (08:28 +0000)]
* Revert r38347, removal of movenologintext. This error message is and has always been used in Title.php.
* Readded some cant-move-user-page messages by reverse-merging r41596
Tim Starling [Sat, 11 Oct 2008 08:26:01 +0000 (08:26 +0000)]
* Reintroduce user page move permission as per r41465, generally useful regardless of whether the Renameuser extension is in use. Do the check in Title::getUserPermissionsErrorsInternal(), so that the move page tab won't be displayed on user pages for users who can't move them.
* Use error message text suitable for humans. Be specific about whether the source or the destination is the problem, say what the namespace is for those people who don't get namespaces, don't introduce unnecessary jargon words like "root" for a page that isn't a subpage.
* Fixed incorrect display of movenotallowed for immobile namespaces, use the new specific error messages.
Tim Starling [Sat, 11 Oct 2008 05:20:18 +0000 (05:20 +0000)]
Revert r41445: static members invite permanent use in the caller, which would give us an ugly interface to remain backwards compatible with. See CodeReview.
Tim Starling [Sat, 11 Oct 2008 04:31:15 +0000 (04:31 +0000)]
Revert merge of DismissableSiteNotice into the core (r41679 and subsequent edits). We should have higher standards than this for core code. This is largely my own crap code and there's a reason I didn't commit it to the core in the first place.
* The sitenotice_id hack is virtually unusable and needs to be replaced with a dedicated message update interface.
* There's a need for automatic message expiry.
* The Wikimedia-specific "spite the anons" feature, preventing anonymous users from dismissing site notices because they allegedly don't contribute to the wiki enough to deserve it, needs to be made optional.
Alex Z [Fri, 10 Oct 2008 22:19:55 +0000 (22:19 +0000)]
Adding file cache to the parser to improve rendering time on pages with several uses of the same image; designed with input from Brion and Tim. Cache size is limited to 1000.
Aaron Schulz [Fri, 10 Oct 2008 20:42:39 +0000 (20:42 +0000)]
remove unused var
Aryeh Gregor [Fri, 10 Oct 2008 19:23:21 +0000 (19:23 +0000)]
(bug 2796) Remove selector that will never match
#p-tbx has never actually matched anything that I know of: the correct id is #p-tb. Maybe it would be better to switch the rule to actually apply to #p-tb, but nobody has actually pointed out what this will do for two years, and for all I know it will break something. So delete it so the source code matches how it actually works.
Greg Sabino Mullane [Fri, 10 Oct 2008 18:24:02 +0000 (18:24 +0000)]
Quick fix to index dropping, without using IF EXISTS clause, per bug #15896
Greg Sabino Mullane [Fri, 10 Oct 2008 18:15:53 +0000 (18:15 +0000)]
Fix invalid SQL, per bug #15836
Greg Sabino Mullane [Fri, 10 Oct 2008 18:08:45 +0000 (18:08 +0000)]
Alter oldimage.metadata to bytea, per bug 15815
Aryeh Gregor [Fri, 10 Oct 2008 17:43:17 +0000 (17:43 +0000)]
(bug 15928) Make special pages dropdown inline
There was a weird extra "|" at the end of lines in Nostalgia (probably other non-MonoBook skins too). Upon investigation, I found that the special pages dropdown (which immediately followed that separator but on the next line) had a class="inline", which actually did nothing but whose intent was fairly obvious. I removed the presentational class and just styled it using the id, so now the separator actually . . . separates.
Ilmari Karonen [Fri, 10 Oct 2008 17:09:53 +0000 (17:09 +0000)]
Use getParameter() for the "maxage" and "smaxage" parameters rather than pulling them straight out of the request
so that they'll be properly validated (and in particular coerced to integers).
Aaron Schulz [Fri, 10 Oct 2008 16:01:54 +0000 (16:01 +0000)]
Tweak udp function to allow any prefix
Meno25 [Fri, 10 Oct 2008 15:54:29 +0000 (15:54 +0000)]
Update files
Aryeh Gregor [Fri, 10 Oct 2008 15:37:51 +0000 (15:37 +0000)]
Add more info to Title::newFromText() comment
Point the reader to makeTitle() and makeTitleSafe() to force a namespace to be used regardless of prefix, to hopefully reduce confusion.
Aryeh Gregor [Fri, 10 Oct 2008 15:37:44 +0000 (15:37 +0000)]
Reformat comment for Title::newFromText
Don't use ugly \type nonsense. We want this to be readable in the source code at least as much as in the auto-generated docs. Follow the standard used everywhere else, documented at <http://www.mediawiki.org/wiki/Manual:Code_standards>: "@param varname type desc...". Also respace to 80 chars per line, not some random number.
Aryeh Gregor [Fri, 10 Oct 2008 15:37:32 +0000 (15:37 +0000)]
Fix E_NOTICE from r41770
Alexandre Emsenhuber [Fri, 10 Oct 2008 15:26:34 +0000 (15:26 +0000)]
typo *sigh*
Tim Starling [Fri, 10 Oct 2008 13:02:57 +0000 (13:02 +0000)]
Fixed regression from r35821: the status key is meant to prevent DB overload, not memcached overload.
Meno25 [Fri, 10 Oct 2008 11:52:30 +0000 (11:52 +0000)]
Update files
Aaron Schulz [Fri, 10 Oct 2008 06:53:54 +0000 (06:53 +0000)]
Update
Aaron Schulz [Fri, 10 Oct 2008 06:16:18 +0000 (06:16 +0000)]
Tweak r41829 to use new messages
Fran Rogers [Fri, 10 Oct 2008 06:00:46 +0000 (06:00 +0000)]
Fix template-included categories from 'leaking' from older revisions when cascading protection is on.
Tim Starling [Fri, 10 Oct 2008 01:54:04 +0000 (01:54 +0000)]
Fix stomach-churning case of edititis in r41350: made optional.
Ryan Schmidt [Fri, 10 Oct 2008 01:15:11 +0000 (01:15 +0000)]
* integrating UniversalEditButton extension into core (enabled by default, set $wgUniversalEditButton = false; in LocalSettings to disable)
Tim Starling [Fri, 10 Oct 2008 01:02:39 +0000 (01:02 +0000)]
Fix error display on invalid destination title on GET, e.g. with URL /wiki/Special:MovePage/Main_Page?wpNewTitle=Main_Page . Broken by r35990 and again by r41343.
Tim Starling [Fri, 10 Oct 2008 00:27:06 +0000 (00:27 +0000)]
Parser test for bug 15196
Rotem Liss [Thu, 9 Oct 2008 21:56:16 +0000 (21:56 +0000)]
Localization update.
Aaron Schulz [Thu, 9 Oct 2008 21:49:20 +0000 (21:49 +0000)]
(bug 14634) Show range blocks for IPs
Antoine Musso [Thu, 9 Oct 2008 21:11:10 +0000 (21:11 +0000)]
Document wfVarDump()
Alex Z [Thu, 9 Oct 2008 21:08:42 +0000 (21:08 +0000)]
Fix some profiling errors in wfGetSiteNotice() if no sitenotice is defined
Aaron Schulz [Thu, 9 Oct 2008 20:45:38 +0000 (20:45 +0000)]
More cleanup:
* Fix ipv6 range searches too
* Use nicer ip checks
* Trim address
Aaron Schulz [Thu, 9 Oct 2008 20:37:40 +0000 (20:37 +0000)]
Fix ipv6 block searches
Alexandre Emsenhuber [Thu, 9 Oct 2008 20:12:13 +0000 (20:12 +0000)]
(bug 15795) Special:Userrights is now listed on Special:SpecialPages when user can only his rights
Aaron Schulz [Thu, 9 Oct 2008 03:41:29 +0000 (03:41 +0000)]
Stop watchlist links from hoping around from bold to non-bold
Tim Starling [Thu, 9 Oct 2008 02:52:38 +0000 (02:52 +0000)]
Typo
Tim Starling [Thu, 9 Oct 2008 02:26:49 +0000 (02:26 +0000)]
Image integrity checker
Ilmari Karonen [Thu, 9 Oct 2008 00:56:26 +0000 (00:56 +0000)]
Make the {{ns:}} core parser function accept localized namespace names and aliases. Also change the output to use spaces
instead of underscores so that it matches the output of {{NAMESPACE}} and related magic words.
Siebrand Mazeland [Wed, 8 Oct 2008 22:10:51 +0000 (22:10 +0000)]
Localisation updates for core messages from Betawiki
Siebrand Mazeland [Wed, 8 Oct 2008 21:39:58 +0000 (21:39 +0000)]
Localisation updates for core messages from Betawiki (2008-10-08 23:33 CEST)
Aaron Schulz [Wed, 8 Oct 2008 21:31:09 +0000 (21:31 +0000)]
(bug 13179) Allow transclusion of Special:RecentChangesLinked
Aaron Schulz [Wed, 8 Oct 2008 21:30:21 +0000 (21:30 +0000)]
Don't show header if including
Aaron Schulz [Wed, 8 Oct 2008 20:55:35 +0000 (20:55 +0000)]
Show contribs link only if it applies
Rotem Liss [Wed, 8 Oct 2008 18:34:39 +0000 (18:34 +0000)]
LOcalization update.
Brion Vibber [Wed, 8 Oct 2008 17:29:42 +0000 (17:29 +0000)]
Tweak to r41837 -- remove 'alt $1' alias for 'alt=$1', we're not sure we need it :)
Aryeh Gregor [Wed, 8 Oct 2008 16:33:36 +0000 (16:33 +0000)]
(bug 368) Allow alt= attribute for images
Alt text is now set in the following ways, in decreasing priority:
1) Set to the alt= parameter if present.
2) Set to the unnamed (caption) parameter if present, and if the image does not have the thumb or frame option set (i.e., if the unnamed parameter is not actually being used for a caption -- using it as both caption and alt text would just lead to text being repeated).
3) Set to the empty string.
Title text and captions should not be affected in any case. The only backward-compatibility effect (i.e., on images not using the new alt= syntax) should be that if previously the same text was repeated in the alt text and then again in the caption, the alt text will now be empty. Setting the alt parameter should never change the HTML output compared to not setting it, except of course changing the alt text.
All parser tests pass, except the usual ones.
Rotem Liss [Wed, 8 Oct 2008 06:54:00 +0000 (06:54 +0000)]
Localization update.
Raimond Spekking [Wed, 8 Oct 2008 06:44:00 +0000 (06:44 +0000)]
Cleanup for r41831:
* Typo in message name
* Add new message to messages.inc
Aaron Schulz [Wed, 8 Oct 2008 04:44:29 +0000 (04:44 +0000)]
(bug 15432) Contribs links at blockip. Moved "edit" message and shorten some.
Aaron Schulz [Wed, 8 Oct 2008 02:29:23 +0000 (02:29 +0000)]
(bug 11904) Add edit links to template list on edit form
Aaron Schulz [Tue, 7 Oct 2008 21:42:23 +0000 (21:42 +0000)]
Revert r41788 and make flaggedrevs do the findFile call itself
Siebrand Mazeland [Tue, 7 Oct 2008 21:15:02 +0000 (21:15 +0000)]
Localisation updates for core messages from Betawiki (2008-10-07 23:07 CEST)
Alexandre Emsenhuber [Tue, 7 Oct 2008 20:14:55 +0000 (20:14 +0000)]
Revert r41792, broke uploads. Note that RepoGroup::findFile() returns false if no file was found, which might be the case when uploading new files ;) (see bug 15883)
Roan Kattouw [Tue, 7 Oct 2008 18:23:39 +0000 (18:23 +0000)]
(bug 15881) API: Empty or invalid parameters cause database errors
Alexandre Emsenhuber [Tue, 7 Oct 2008 18:10:08 +0000 (18:10 +0000)]
* Display default extensions messages for language subpages when the page being edited doesn't exist
* Fix MessageCache::figureMessage() to allow slashes in message name
Siebrand Mazeland [Tue, 7 Oct 2008 16:33:11 +0000 (16:33 +0000)]
Follow up on r41723. 'rcnotefrom' is no longer in use.
Roan Kattouw [Tue, 7 Oct 2008 14:57:59 +0000 (14:57 +0000)]
* (bug 15845) API: Added pageid/fromid parameter to action=delete/move, making manipulation of legacy pages with invalid titles possible
* Fix an E_STRICT while I'm at it
Rotem Liss [Tue, 7 Oct 2008 11:01:05 +0000 (11:01 +0000)]
Localization update for he.
Raimond Spekking [Tue, 7 Oct 2008 07:56:35 +0000 (07:56 +0000)]
Cleanup for r41782: use a common class, not a series of specific IDs.
Per Brions codereview: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/41782#c124
Aaron Schulz [Tue, 7 Oct 2008 02:22:37 +0000 (02:22 +0000)]
Tweak r41788 - Use findFile() to check current version if $time given
Brion Vibber [Tue, 7 Oct 2008 01:10:32 +0000 (01:10 +0000)]
Cleanup for r41713 PHP 4 warning page:
* Avoid register_globals XSS vulns hitting the template directly
* Avoid register_globals XSS vulns when using funny URLs
* Avoid horrible links when using funny URLs :)
* Swapped REQUEST_URI for SCRIPT_NAME as primary in path check, since SCRIPT_NAME doesn't include the PATH_INFO bits so will work when hitting a URL like index.php/Foo/Bar, or hopefully a rewrite?
* Don't spew errors if the file_get_contents() fails
* Don't FATAL out if file_get_contents() doesn't exist -- new in 4.3.0 :)
* Add a link to PHP download page
Brion Vibber [Tue, 7 Oct 2008 00:31:26 +0000 (00:31 +0000)]
Update to r41727 (bug 539) "click" parameter on images.
* Renamed to "link", which seems clearer and less mouse-centric ;)
* Added parser test cases:
3 new PASSING test(s) :)
* Image with link parameter, wiki target [Has never failed]
* Image with link parameter, URL target [Has never failed]
* Image with empty link parameter [Has never failed]
Aaron Schulz [Tue, 7 Oct 2008 00:30:18 +0000 (00:30 +0000)]
Add handy $time parameter to wfLocalFile()
Aaron Schulz [Mon, 6 Oct 2008 23:57:05 +0000 (23:57 +0000)]
(bug 10250) New password submission oddness for empty passwords
Aaron Schulz [Mon, 6 Oct 2008 23:51:33 +0000 (23:51 +0000)]
(bug 9226) Fetch restrictions properly on export
Brion Vibber [Mon, 6 Oct 2008 23:30:52 +0000 (23:30 +0000)]
Cleanup for r41724: parser test cases altered by removal of unneeded <span> in floating thumb.
The stray <span> was added by Gabriel Wicke in r2953 "to allow better css styling", but doesn't appear to have been really used. Doesn't seem any clear benefit to it, and it causes problems with fancy media types like OggHandler, so let's kill it and fix the tests. :)
Aaron Schulz [Mon, 6 Oct 2008 23:21:30 +0000 (23:21 +0000)]
Query and UI cleanup
Siebrand Mazeland [Mon, 6 Oct 2008 21:32:51 +0000 (21:32 +0000)]
Remove 'their' from 'blocklist-nousertalk'
Raimond Spekking [Mon, 6 Oct 2008 21:16:28 +0000 (21:16 +0000)]
* Format page protection warning identical to similar warnings
* Move these lines to shared.css
Siebrand Mazeland [Mon, 6 Oct 2008 21:09:21 +0000 (21:09 +0000)]
Localisation updates for core messages from Betawiki (2008-10-06 23:00 CEST)
Siebrand Mazeland [Mon, 6 Oct 2008 20:54:05 +0000 (20:54 +0000)]
Fix on r41778: actually replace 'history-search' by 'history-fieldset-title' in code.
Siebrand Mazeland [Mon, 6 Oct 2008 20:51:24 +0000 (20:51 +0000)]
* rename 'history-search' to 'history-fieldset-title' and change description (thank you Splarka for talking back)
* fix a message group comment in messages.inc
Rotem Liss [Mon, 6 Oct 2008 20:42:54 +0000 (20:42 +0000)]
Localization update.
Aaron Schulz [Mon, 6 Oct 2008 20:17:35 +0000 (20:17 +0000)]
(bug 4391) Blocklist filters