Aryeh Gregor [Wed, 29 Nov 2006 02:43:04 +0000 (02:43 +0000)]
(bug 6016) Left-aligned images should stack vertically, like right-aligned images, not horizontally.
Greg Sabino Mullane [Tue, 28 Nov 2006 21:40:42 +0000 (21:40 +0000)]
Fix broken contribution listings with postgres by adding a new variable
to check if we are using integers or explicit timestamps.
Greg Sabino Mullane [Tue, 28 Nov 2006 21:32:59 +0000 (21:32 +0000)]
Slight UPDATE syntax adjustment for non-mysql databases.
Niklas Laxström [Tue, 28 Nov 2006 19:01:14 +0000 (19:01 +0000)]
* (bug 6329) Date/Time settings on Frisian wikis do not conform to Frisian usage.
Niklas Laxström [Tue, 28 Nov 2006 16:58:58 +0000 (16:58 +0000)]
* (bug 6910) Dates in Vietnamese localization broken
Brion Vibber [Tue, 28 Nov 2006 04:44:09 +0000 (04:44 +0000)]
Revert r17964, breaks diff links for no apparent reason.
Brion Vibber [Tue, 28 Nov 2006 04:31:35 +0000 (04:31 +0000)]
Revert special:deletedcontribs for now; it's not ready to go live without the
index change so would hold up other work for a few days, and the code's kind
of ugly and should get refactored.
Would love to see this on a branch for the moment.
Ilmari Karonen [Tue, 28 Nov 2006 03:22:12 +0000 (03:22 +0000)]
New special page Special:Deletedcontribs for browsing deleted edits made by a user.
NOTENOTENOTE: This is a one-night hack; feel free to tweak it mercilessly. It has
a lot of common code with Special:Contributions that should be factored out. There
is no link to this new page anywhere in the UI yet; I'd like people to test and
review this a bit before officially announcing it. The page is currently only
available to users with deletedhistory privileges; a possible additional feature
might be to allow all users to list (but not view) their _own_ deleted edits.
Ilmari Karonen [Tue, 28 Nov 2006 00:32:00 +0000 (00:32 +0000)]
make undelete preview more consistent with normal article view (tidy, pagename)
Brion Vibber [Tue, 28 Nov 2006 00:16:49 +0000 (00:16 +0000)]
Woops, left a parameter off of the AuthPlugin default interface class. *embarrassed*
Niklas Laxström [Mon, 27 Nov 2006 23:20:29 +0000 (23:20 +0000)]
* Don't mess up diff link when revision is not deleted
Niklas Laxström [Mon, 27 Nov 2006 22:55:12 +0000 (22:55 +0000)]
* Indentation, magic numbers
Niklas Laxström [Mon, 27 Nov 2006 22:40:22 +0000 (22:40 +0000)]
*I like verbs
Niklas Laxström [Mon, 27 Nov 2006 19:49:48 +0000 (19:49 +0000)]
* Xmlify a little
Brion Vibber [Mon, 27 Nov 2006 18:27:25 +0000 (18:27 +0000)]
* Fix regression when selecting mysql 4.0 schema in installer
* Detect PHP parse errors in generated config and dump the file
as a debugging aid, instead of silently corrupting the behavior
of the installer
Rotem Liss [Mon, 27 Nov 2006 17:19:52 +0000 (17:19 +0000)]
Message order compatibility.
Tim Starling [Mon, 27 Nov 2006 15:09:43 +0000 (15:09 +0000)]
Fixed wikia link
Rotem Liss [Mon, 27 Nov 2006 13:11:15 +0000 (13:11 +0000)]
Fixes.
Rotem Liss [Mon, 27 Nov 2006 12:58:01 +0000 (12:58 +0000)]
(bug 8012) Update for messagesSv.php (Swedish language)
Nick Jenkins [Mon, 27 Nov 2006 08:36:57 +0000 (08:36 +0000)]
Changing lines like this: "extract( $dbw->tableNames( 'page', 'archive' ) );" to be like this: "list ($page, $archive) = $dbw->tableNamesN( 'page', 'archive' );".
Three reasons for this:
1) It's better for analysis tools [which want explicit variable declaration]
2) It's easier for a human to read, as it's completely explicit where the variables came from [which is something you don't get with extract() ]
3) It makes it easier to find everywhere where a variable is used with search/grep [which you can't currently do with $tbl_page variables from things like: "extract($db->tableNames( 'page', 'revision'), EXTR_PREFIX_ALL, 'tbl');"].
Otherwise, from a functionality/efficiency perspective the two forms should be identical.
By doing this have been able run static analysis over the usages of these variables, thus eliminating 5 unneeded table names from calls, plus removing 3 unused calls entirely, and it just feels subjectively slightly nicer to me.
Tim Starling [Mon, 27 Nov 2006 03:15:38 +0000 (03:15 +0000)]
Fixed Parser::getRevisionTimestamp()
Andrew Garrett [Mon, 27 Nov 2006 03:09:35 +0000 (03:09 +0000)]
Make passing an invalid revid for undoing fail gracefully
Tim Starling [Mon, 27 Nov 2006 02:43:36 +0000 (02:43 +0000)]
Aryeh Gregor [Mon, 27 Nov 2006 01:54:04 +0000 (01:54 +0000)]
Fix display of link in "already rolled back" message for image/category pages ($1 -> :$1)
Rotem Liss [Sun, 26 Nov 2006 19:01:56 +0000 (19:01 +0000)]
Fixing a PHP warning about passing variables by reference from the function call (should be passed from the function decleration itself, and they are passed in that way), like the other call to wfMerge in this file; tested.
Rotem Liss [Sun, 26 Nov 2006 15:11:06 +0000 (15:11 +0000)]
(bug 8040) Turkish internationalization contains errors
Rotem Liss [Sun, 26 Nov 2006 15:08:39 +0000 (15:08 +0000)]
(bug 8039) Update to Indonesian localisation (id) #42
Rotem Liss [Sun, 26 Nov 2006 15:01:50 +0000 (15:01 +0000)]
Update.
Aryeh Gregor [Sun, 26 Nov 2006 13:58:40 +0000 (13:58 +0000)]
* Add new editFormPageTop placeholder for text injection
* Use that instead of editFormTextTop for undo failure, so it displays above the preview if applicable
* <strong class="error"> for undo failure
* Explicitly declare $editFormX as public
Aryeh Gregor [Sun, 26 Nov 2006 13:41:36 +0000 (13:41 +0000)]
* Add AOL IPs to whitelist by default
* Add period to "undo failed" message
* Use <p>, not <br />
Andrew Garrett [Sun, 26 Nov 2006 11:15:35 +0000 (11:15 +0000)]
Add message explaining if undoing an edit failed.
Andrew Garrett [Sun, 26 Nov 2006 10:54:01 +0000 (10:54 +0000)]
* (bug 6295) Add a 'revision patching' functionality, where an edit can be undone (with a functionality similar to diff rev1 rev2 | patch -R rev3 -o rev3). This is triggered by including &undo=revid in an edit URL. A link to a URL that will undo a given edit is shown on NEW NON-CURRENT revision headers on diff pages.
Andrew Garrett [Sun, 26 Nov 2006 00:10:40 +0000 (00:10 +0000)]
(bug 8009) Title change for ancientpages in de
Tim Starling [Sat, 25 Nov 2006 17:32:41 +0000 (17:32 +0000)]
oops
Tim Starling [Sat, 25 Nov 2006 17:11:58 +0000 (17:11 +0000)]
Fixed inefficient use of array_keys() introduced by Nick in r17880. If this is setting off alarms, then fix the alarms.
Tim Starling [Sat, 25 Nov 2006 16:27:33 +0000 (16:27 +0000)]
Removed wfRangeStartEnd() and wfIsAddressInRange() -- avoid proliferation of global functions.
Tim Starling [Sat, 25 Nov 2006 16:24:44 +0000 (16:24 +0000)]
* Added temporary special-case AOL proxy detection, they're automatically counted as trusted proxies for now.
* Removed wfRangeStartEnd() and wfIsAddressInRange() -- avoid proliferation of global functions.
Rotem Liss [Sat, 25 Nov 2006 14:35:59 +0000 (14:35 +0000)]
(bug 7859) Updates for Kazakh i18n
Rotem Liss [Sat, 25 Nov 2006 14:12:00 +0000 (14:12 +0000)]
(bug 7859) Updates for Kazakh i18n
Andrew Garrett [Sat, 25 Nov 2006 13:51:50 +0000 (13:51 +0000)]
hooks.txt documentation for UploadForm:initial hook added in r17917
Rotem Liss [Sat, 25 Nov 2006 07:44:20 +0000 (07:44 +0000)]
Fix.
Rotem Liss [Sat, 25 Nov 2006 07:40:09 +0000 (07:40 +0000)]
(bug 8031) Update to Japanese localisation (ja)
Andrew Garrett [Fri, 24 Nov 2006 23:48:22 +0000 (23:48 +0000)]
Patch by Leon Weber that adds a hook 'UploadForm:initial' before the upload form is generated, and two member variable for text injection into the form, which can be filled by the hooks.
Brion Vibber [Fri, 24 Nov 2006 22:11:47 +0000 (22:11 +0000)]
* Use INSERT IGNORE for db-based BagOStuff add/insert, for more memcache-like
behavior when keys already exist on add (instead of dying with an error...)
Brion Vibber [Fri, 24 Nov 2006 22:10:11 +0000 (22:10 +0000)]
* Installer support for experimental MySQL 4.1/5.0 binary-safe schema
Rotem Liss [Fri, 24 Nov 2006 19:16:39 +0000 (19:16 +0000)]
(bug 8031) Update to Japanese localisation (ja)
Rotem Liss [Fri, 24 Nov 2006 19:06:35 +0000 (19:06 +0000)]
(bug 8009) Automatic edit summary for redirects is not filled for edits in existing pages
Rotem Liss [Fri, 24 Nov 2006 15:38:00 +0000 (15:38 +0000)]
Removing several ignored messages from the language files.
Rotem Liss [Fri, 24 Nov 2006 15:34:23 +0000 (15:34 +0000)]
Removing newtalkseperator from all the language files except for English.
Rotem Liss [Fri, 24 Nov 2006 15:21:40 +0000 (15:21 +0000)]
(bug 8026) Update to Japanese localisation (ja)
Rotem Liss [Fri, 24 Nov 2006 15:11:43 +0000 (15:11 +0000)]
Probably a typo.
Rotem Liss [Fri, 24 Nov 2006 15:06:50 +0000 (15:06 +0000)]
(bug 7859) Updates for Kazakh i18n
Rotem Liss [Fri, 24 Nov 2006 14:59:04 +0000 (14:59 +0000)]
(bug 8020) Update for Cantonese language (zh-yue) #6
Rotem Liss [Fri, 24 Nov 2006 14:51:01 +0000 (14:51 +0000)]
Setting newtalkseperator as an ignored message, and removing it from the Hebrew translation; will remove from other translations later.
Rotem Liss [Fri, 24 Nov 2006 14:46:05 +0000 (14:46 +0000)]
(bug 8012) Update for messagesSv.php (Swedish language)
Rotem Liss [Fri, 24 Nov 2006 10:22:22 +0000 (10:22 +0000)]
Update.
Aryeh Gregor [Fri, 24 Nov 2006 06:41:02 +0000 (06:41 +0000)]
(bug 7892) Add media count to category page, à la subcats/pages. Used a new count() method I added to ImageGallery class.
Rotem Liss [Thu, 23 Nov 2006 18:55:41 +0000 (18:55 +0000)]
Update.
Andrew Garrett [Thu, 23 Nov 2006 11:15:46 +0000 (11:15 +0000)]
As per Rob's suggestion, remove autosummaries for short new pages, and replace them with autosummaries for all new pages. On more reflection, this makes a lot more sense
Andrew Garrett [Thu, 23 Nov 2006 09:32:28 +0000 (09:32 +0000)]
(bug 8013) Add autosummary for new pages with >500 characters. I would merge this with the original short new page autosummary, but this would break current message customisations on other wikis. en.wp comes to mind.
Nick Jenkins [Thu, 23 Nov 2006 08:37:52 +0000 (08:37 +0000)]
Would probably be wanting "$wgStyleVersion" rather than "wgStyleVersion", otherwise if metadata.js changes can bump $wgStyleVersion till the cows come home, but still won't cause it to be refreshed ;-)
Nick Jenkins [Thu, 23 Nov 2006 08:30:37 +0000 (08:30 +0000)]
Probable bug in wfIsAddressInRange() - $unsignedIP and $unsignedip are not the same thing. One is defined, and the other is undefined / null.
Nick Jenkins [Thu, 23 Nov 2006 08:25:56 +0000 (08:25 +0000)]
Code housekeeping stuff (and barring any stuff-ups on my behalf, there should be no changes in behaviour whatsoever after this) -
* removing some unused global declarations.
* removing or commenting out or adding comments for unused local vars.
* Adding one or two local var declarations.
* Declaring $matches array passed to preg_match() / preg_match_all() as array() before using [not required, just have a slight preference for the explicitness].
* remove one or two pass-by-reference function declarations where the value is not modified.
* Adding some braces to if-else blocks.
* In Parser.php, stripstrate is now an object rather than an array as per r17820, so we no longer need ask for a reference to it (as in "$x =& $this->mStripState;"), and in fact it's probably just simpler to get rid of $x altogether.
* Moving some preg regexes from "" quoting to '' quoting to stop static analyzer whinging about bad escape sequences.
... up to "LinksUpdate.php" in the includes/ directory.
Andrew Garrett [Thu, 23 Nov 2006 05:10:29 +0000 (05:10 +0000)]
wfGetIp-> in checking autoblock whitelist in doAutoblock. Kudos to Simetrical for spotting the issue.
Aryeh Gregor [Wed, 22 Nov 2006 23:42:39 +0000 (23:42 +0000)]
Revert last three commits. I totally broke autoblock and didn't notice somehow. :|
Aryeh Gregor [Wed, 22 Nov 2006 23:32:21 +0000 (23:32 +0000)]
More bugs! Why did I only spot these after commit >:|
Aryeh Gregor [Wed, 22 Nov 2006 23:27:10 +0000 (23:27 +0000)]
Argh, syntax error
Aryeh Gregor [Wed, 22 Nov 2006 23:21:53 +0000 (23:21 +0000)]
* Moved Werdna's new IP functions to the IP class
* Handle bad input to new IP::isAddressInRange gracefully (return false)
* Block::doAutoblock always returns a bool now, as the docs say
* Split off Block::isWhitelistedIp from Block::doAutoblock
* Put AOL proxy IPs in whitelist, and also one from Singapore that was troublesome on enwiki (more should be added, probably?)
* Improve some docs
* Fix a bug: check if the passed IP is in the whitelist, not if the request IP is in the whitelist
Daniel Kinzler [Wed, 22 Nov 2006 20:53:11 +0000 (20:53 +0000)]
Added placeholders for text injection by hooks to EditPage.php
Brion Vibber [Wed, 22 Nov 2006 17:46:36 +0000 (17:46 +0000)]
There used to be a big warning message, I think. Putting it back because nobody reads the damn documentation.
Rotem Liss [Wed, 22 Nov 2006 17:06:44 +0000 (17:06 +0000)]
Removing several ignored and optional messages.
Rotem Liss [Wed, 22 Nov 2006 17:04:20 +0000 (17:04 +0000)]
(bug 8008) Update to Indonesian localisation (id) #41
Domas Mituzas [Wed, 22 Nov 2006 14:21:53 +0000 (14:21 +0000)]
revert until proper cleanup
Rotem Liss [Wed, 22 Nov 2006 14:11:46 +0000 (14:11 +0000)]
Update; setting autoblock_whitelist to be an ignored message.
Domas Mituzas [Wed, 22 Nov 2006 14:06:00 +0000 (14:06 +0000)]
remove 'subkey' (255) for a field which is 40-chars long, fixes stuff...
Tim Starling [Wed, 22 Nov 2006 13:22:41 +0000 (13:22 +0000)]
fixed a special page name comparison
Andrew Garrett [Wed, 22 Nov 2006 11:51:49 +0000 (11:51 +0000)]
* (bug 7883) Added autoblock whitelisting feature, using which specific ranges can be protected from autoblocking. These ranges are specified, in list format, in the autoblock_whitelist system message.
Tim Starling [Wed, 22 Nov 2006 09:06:24 +0000 (09:06 +0000)]
Applying patch (slightly modified) from bug 8003 by AlefZet. The patch is clearly necessary, but I'm not sure if it is sufficient. Also fixed indenting.
Tim Starling [Wed, 22 Nov 2006 07:08:50 +0000 (07:08 +0000)]
Implementation of delimiterReplace() with a behaviour much closer to that of the model regex. Tested using comparitive fuzz testing. The only known difference now is where the start delimiter ends with an initial substring of the end delimiter, e.g. the previously mentioned case of C-style comments.
Aryeh Gregor [Wed, 22 Nov 2006 00:25:57 +0000 (00:25 +0000)]
(bug 7554) The correct MIME type for SVG images is now displayed on the image page (image/svg+xml, not image/svg). This is a hack because it only affects display, and doesn't correct the internal storage. I don't know how the latter works, so I wasn't confident touching it.
Aryeh Gregor [Tue, 21 Nov 2006 22:49:25 +0000 (22:49 +0000)]
Since formatComment and commentBlock can take null as well as Title objects (per r17833), corrected documentation (Title -> mixed). Since revComment would immediately fail if passed anything but a Revision object or descendant, restore type hinting to that.
Rotem Liss [Tue, 21 Nov 2006 19:26:11 +0000 (19:26 +0000)]
Fixes for the script rebuildLanguage.php:
* (bug 7983) Sort blocks in the correct order
* Sort the unknown messages alphabetically
* Use single apostrophe on messages which include dollar signs which are not followed by numbers
Rotem Liss [Tue, 21 Nov 2006 19:01:40 +0000 (19:01 +0000)]
(bug 7984) Update to Indonesian localisation (id) #40
Rotem Liss [Tue, 21 Nov 2006 18:55:26 +0000 (18:55 +0000)]
(bug 7978) New localization for Old Church Slavonic
Rotem Liss [Tue, 21 Nov 2006 18:43:52 +0000 (18:43 +0000)]
Fix.
Rotem Liss [Tue, 21 Nov 2006 18:38:06 +0000 (18:38 +0000)]
Reverting the addition of class names near the parameters: it doesn't seem to have a purpose, and breaks PHP 5.0.4 on my computer (PHP raises error when the parameters are set to null).
Rotem Liss [Tue, 21 Nov 2006 18:26:55 +0000 (18:26 +0000)]
Replacing the manual user and user talk links of the blocker in Special:Ipblocklist to Linker::userLink and Linker::userToolLinks; for that, added the function Block::getBy, to get the blocker user ID.
Tim Starling [Tue, 21 Nov 2006 12:12:20 +0000 (12:12 +0000)]
bump style version for wikibits.js change
Tim Starling [Tue, 21 Nov 2006 11:20:04 +0000 (11:20 +0000)]
profiling
Tim Starling [Tue, 21 Nov 2006 10:38:07 +0000 (10:38 +0000)]
Collection of generic string functions and classes
Tim Starling [Tue, 21 Nov 2006 09:53:45 +0000 (09:53 +0000)]
* Introduced StringUtils.php, populated it with some generic string functions, both new and collected from various other files.
* Removed some backtracking regexes with an O(N^2) worst case, replaced with StringUtils::delimiterReplace(). There is a beneficial functional difference: /*/ is no longer considered to be a complete CSS comment.
* Changed the parser strip state from an array to an object. This should hopefully avoid the PHP bugs with array references. StripState uses the new ReplacementArray to do the replacements, thereby supporting FSS.
* Removed DatabaseFunctions.php from the default startup sequence. Moved wfGetDB() to GlobalFunctions.php.
* Introduced the SiteStats class, with a collection of cached site stats accessor functions.
* Removed all global functions from Parser.php, they don't belong there.
* Made LanguageConverter use the new ReplacementArray class instead of managing its own FSS objects.
Tim Starling [Tue, 21 Nov 2006 09:37:36 +0000 (09:37 +0000)]
Fixed recently committed error.
Aryeh Gregor [Tue, 21 Nov 2006 03:22:18 +0000 (03:22 +0000)]
Code style tweaks per brion's suggestions on Wikitech-l
Rotem Liss [Mon, 20 Nov 2006 14:35:44 +0000 (14:35 +0000)]
Update.
Andrew Garrett [Mon, 20 Nov 2006 11:48:03 +0000 (11:48 +0000)]
* Added autosummary for new pages with 500 or less characters, and refactor the autosummary code so it's all done in one function. doEdit is getting too big\!
Aryeh Gregor [Mon, 20 Nov 2006 06:09:29 +0000 (06:09 +0000)]
(bug 2001) Implement sortable tables. sorttable.js is loaded conditionally based on whether a sortable table is on the page, so there should be no unneeded hits.
Andrew Garrett [Mon, 20 Nov 2006 06:01:45 +0000 (06:01 +0000)]
Fix bug reported by Slowking_Man where retroactive autoblocks take effect even if the user being blocked was already blocked with autoblocks disabled.
Aryeh Gregor [Mon, 20 Nov 2006 05:41:53 +0000 (05:41 +0000)]
(bug 7889) Don't show "blank edit summary" notice if a redirect autosummary will be added. Do show it if a blanking autosummary will be added, however.
Also, I separated out the blanking autosummary thing into its own static function, mainly because I almost included it in this too. I decided not to, but why not keep the function separate, doEdit is huge.
Aryeh Gregor [Mon, 20 Nov 2006 05:15:51 +0000 (05:15 +0000)]
* (bug 7918) Fix regression in display of "templates used on this page" for users with edit form before preview
* Make section edits show templates used in the section, not the page
Patch by Mark Haidar (Fyren). I didn't change the Boolean params to class constants because they're currently called as ($this->preview, $this->section != ''), which is much more readable than the alternative.
Aryeh Gregor [Sun, 19 Nov 2006 17:16:34 +0000 (17:16 +0000)]
Fix minor bug in r17715: don't display rollback link on history page for non-latest revision, even if it's at the top of the page. Also add some documentation to PageHistory::historyLine.