Dereckson [Tue, 18 Dec 2012 01:03:44 +0000 (02:03 +0100)]
New methods to drop or rename extension index in DatabaseUpdater
- DatabaseUpdater::dropExtensionIndex( $tableName, $indexName, $sqlPath )
- DatabaseUpdater::renameExtensionIndex( $tableName, $oldIndexName, $newIndexName, $sqlPath, $skipBothIndexExistWarning = false )
[ Case use ]
This feature is required to help extensions schema change to ensure
compatibility with SQLite.
First extensions to use it will be Echo and Flagged Revisions.
Change-Id: Ia2782d644593ab6b64b67720ed61b3994db10346
IAlex [Sat, 5 Jan 2013 18:44:08 +0000 (18:44 +0000)]
Merge "Use nocookiesfornew on account creation if no cookies"
jenkins-bot [Fri, 4 Jan 2013 23:23:20 +0000 (23:23 +0000)]
Merge "Fix Sqlite upgrade test when profiling to database is enabled"
Aaron Schulz [Fri, 21 Dec 2012 00:38:36 +0000 (16:38 -0800)]
[JobQueue] Increment stats for jobs ignored as duplicates.
Change-Id: If4130f4eb79dc2d55b50a7adebfca43620a36d2c
IAlex [Fri, 4 Jan 2013 21:58:39 +0000 (21:58 +0000)]
Merge "Use Database::addQuotes instead of hardcoded quotes"
IAlex [Fri, 4 Jan 2013 21:52:14 +0000 (21:52 +0000)]
Merge "Partial normalisation of hooks.txt"
IAlex [Fri, 4 Jan 2013 21:49:50 +0000 (21:49 +0000)]
Merge "recentchanges.rc_ip is used for retroactive autoblocks"
jenkins-bot [Fri, 4 Jan 2013 21:36:26 +0000 (21:36 +0000)]
Merge "Made the profilers that output text not break js."
Translation updater bot [Fri, 4 Jan 2013 21:33:31 +0000 (21:33 +0000)]
Merge "Localisation updates from translatewiki.net."
Aaron Schulz [Tue, 11 Dec 2012 21:18:57 +0000 (13:18 -0800)]
Made the profilers that output text not break js.
Change-Id: I12377e7ac08203113e8d6650f57091a63ad1af27
jenkins-bot [Fri, 4 Jan 2013 21:18:58 +0000 (21:18 +0000)]
Merge "Also delete the page information cache when invalidating cache of a non-existing page"
Translation updater bot [Fri, 4 Jan 2013 21:05:19 +0000 (21:05 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Iaeeae73d2e7c3c44fa371c0691e5dc9ade2e52a2
Siebrand Mazeland [Fri, 4 Jan 2013 20:33:37 +0000 (21:33 +0100)]
Partial normalisation of hooks.txt
Follow-up to If43cafb5. Almost complete. Needs another scan.
Added TODO where work is needed. I'll create documentation bugs for these
after the last scan.
Change-Id: I16a7bc03be71d1c907393c2a0748bf2150828bed
umherirrender [Fri, 4 Jan 2013 19:58:00 +0000 (20:58 +0100)]
recentchanges.rc_ip is used for retroactive autoblocks
Document this at $wgPutIPinRC and check the global explicit
Change-Id: I5a796edc855ae954ebd0fb11fe54b486e5eff7ed
Brian Wolff [Fri, 4 Jan 2013 19:35:12 +0000 (15:35 -0400)]
Use nocookiesfornew on account creation if no cookies
follow-up I402c6bebcf.
Previously we used nocookiesfornew msg if the user tried to
make an account, and their cookies were missing. I402c6
changed this to session_failure, which was previously
used only for the cases where the token was tampered
with. I think the previous message was better as
it actually mentioned to the user that them not
having cookies could be the cause.
Also its removal may have been accidental as its
not mentioned in the commit msg of that change.
As well that change removed all uses of that
msg from core, but yet didn't delete it
from MessagesEn.php.
Change-Id: I421e294e4a3ddaa0eea90f2abf215af82ee6a00a
umherirrender [Fri, 4 Jan 2013 19:07:37 +0000 (20:07 +0100)]
Use Database::addQuotes instead of hardcoded quotes
Change-Id: I29461e5332f3fc6523cbd899e14394aa88865d93
jenkins-bot [Fri, 4 Jan 2013 18:18:01 +0000 (18:18 +0000)]
Merge "Remove "read" from list of allowed actions on special pages"
jenkins-bot [Fri, 4 Jan 2013 18:16:12 +0000 (18:16 +0000)]
Merge "Block::parseTarget() accepts and can return null"
Tim Starling [Fri, 4 Jan 2013 09:23:26 +0000 (20:23 +1100)]
Use consistent hashing for SqlBagOStuff servers
Also factor out consistent hash code from Redis and the new application
into a class called ArrayUtils. The name "ArrayUtils" is from
I0f4e7d7c, I expect that change will be rebased on top of this one at
some point.
Change-Id: I9375087f4d7a6e8e629d97bfb6b117d9cb7d1bcf
jenkins-bot [Fri, 4 Jan 2013 18:06:43 +0000 (18:06 +0000)]
Merge "Multiple servers in one SqlBagOStuff"
Siebrand Mazeland [Fri, 4 Jan 2013 16:00:48 +0000 (17:00 +0100)]
Explicitely add two undocumented hooks
Found using php maintenance/findHooks.php.
Change-Id: I6977cd5c57566025a63be1c5042d5d64eed44676
Siebrand Mazeland [Fri, 4 Jan 2013 15:56:58 +0000 (16:56 +0100)]
Partial normalisation of hooks.txt
File formatting is very inconsistent. I updated approximately the first
part of the file.
Change-Id: If43cafb59828a1b846dd6dc751efc9ebcd7d5b72
jenkins-bot [Fri, 4 Jan 2013 13:49:53 +0000 (13:49 +0000)]
Merge "(bug 43595) Add a cache version variable to SiteArray"
Alex Monk [Sat, 22 Dec 2012 19:33:05 +0000 (19:33 +0000)]
(bug 38633) Don't block non-existent users via the API
Change-Id: I49232e177b23e11d04f64ac0d939073fa9418d64
Brian Wolff [Fri, 4 Jan 2013 09:11:13 +0000 (05:11 -0400)]
Reuse the WikiPage object to save a db query
Early in the request we call Action::getActionName to get the action
name for HTMLFileCache to see if the current action is cached.
This causes data to be loaded from the WikiPage object
stored in the main request context. However, later when
we're initializing the Article object, we overwrite that
WikiPage object with the one used by the Article object.
Later on the WikiPage object has to be re-loaded, and
hence the exact same db request is run twice in one request,
which seems wasteful.
Instead, initialize the Article object using the WikiPage
object from the context, in order to save the already
loaded data.
Change-Id: I292f0d70feb505fae5fa955fd735d85ad3b22fea
jenkins-bot [Fri, 4 Jan 2013 12:49:15 +0000 (12:49 +0000)]
Merge "(zhtable) Add zh2Hans: '这么' => '这么' for better segmentation"
Alexandre Emsenhuber [Fri, 21 Dec 2012 07:39:28 +0000 (08:39 +0100)]
Move logentry-* messages from newusers and rights log near the other ones
'rightslogentry' and 'rightslogentry-autopromote' are now marked as ignored since
they are only used for IRC notifications.
Also moved new users log description messages near the ones for user rights log.
Change-Id: I63f90d824ff454c0e4177f9f80542c36175c3ffe
Liangent [Sat, 24 Nov 2012 17:50:33 +0000 (01:50 +0800)]
(zhtable) Add zh2Hans: '这么' => '这么' for better segmentation
Change-Id: I5cec6e1f1f966706b591de7b8d66b8f011cbace2
Alexandre Emsenhuber [Sun, 30 Dec 2012 12:14:04 +0000 (13:14 +0100)]
Follow-up Idf308e82 (
e88b0fb): use wfMessage() and numParams()
So that it matches Language::formatDuration().
Change-Id: I7144640c93e95290600997d370a33d946897ef70
Liangent [Mon, 21 May 2012 15:33:32 +0000 (23:33 +0800)]
(bug 33210) Don't convert blue categorylinks to another variant.
By the way the check $oldkey != $vardbk is unnecessary because
there's already $variant != $category check.
Change-Id: I963be065723059073c9cb83c6ef636af8d023faf
jenkins-bot [Fri, 4 Jan 2013 11:48:26 +0000 (11:48 +0000)]
Merge "Parser test to test language conversion around HTML tags."
jenkins-bot [Fri, 4 Jan 2013 11:43:12 +0000 (11:43 +0000)]
Merge "Use proper function recursiveConvertTopLevel() in recursive conversion"
Liangent [Mon, 17 Dec 2012 15:05:23 +0000 (23:05 +0800)]
zhtable maintenance
* The old broken zhtable/Makefile is changed into a wrapper of Makefile.py
* includes/zhtable is moved to maintenance/language/zhtable
Change-Id: I55e431974dd9dcbcb47eb9c3aa6fbf31c5a23125
Liangent [Thu, 6 Dec 2012 14:34:03 +0000 (22:34 +0800)]
Use getPageViewLanguage() instead of getPageLanguage() in firstHeading.
This fixes I55dd392d and I20bd5b6a.
Change-Id: I0c0e3f869d00605090467a83e8f5065870dc8005
Liangent [Fri, 2 Nov 2012 12:37:20 +0000 (20:37 +0800)]
(bug 37176) Localize autosummary of page protecting
Including parentheses, brackets, edit=sysop text, etc. A new message
'protect-summary-desc' has been added.
Change-Id: I888c616ea896bb2585d79ef8ecb6f34fab196191
jenkins-bot [Fri, 4 Jan 2013 08:28:41 +0000 (08:28 +0000)]
Merge "Add months and years to Timestamp::getHumanTimestamp()"
Translation updater bot [Thu, 3 Jan 2013 22:58:16 +0000 (22:58 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I0ac6eb2b725856636cf1018d4c47f2c0be91fdd5
Juliusz Gonera [Thu, 3 Jan 2013 20:57:59 +0000 (12:57 -0800)]
Add months and years to Timestamp::getHumanTimestamp()
Now if the difference between $now and $then is >= 30 days, "X months
ago" or "X years ago" is returned.
Month is defined as 30 days, but it shouldn't cause problems in this
case. The "X time ago" messages are approximate anyway.
Change-Id: I228a11e23783484b64c29db94c3607a415fa81a8
Aaron Schulz [Fri, 14 Dec 2012 18:47:06 +0000 (10:47 -0800)]
[JobQueue] Made showJobs.php work for non-DB queues.
Change-Id: Idada1e3ca8278898de6e53fdcc5dee4786d5bae8
jenkins-bot [Thu, 3 Jan 2013 20:02:25 +0000 (20:02 +0000)]
Merge "Set $mLoadedItems to true in User::loadFromId()"
Marius Hoch [Wed, 2 Jan 2013 22:18:50 +0000 (23:18 +0100)]
(bug 43595) Add a cache version variable to SiteArray
Added a $cacheVersion variable to SiteArray to prevent problems
on SiteArray format changes due to a Memcached value of the object
being stored in the outdated format. This already caused disruption
on wikidata.org twice.
(This new version isn't tested as I don't have a memcached environment
with me atm.)
Change-Id: Ib290b465276b6be8b8753c27ea3f57d4597ec3c1
IAlex [Thu, 3 Jan 2013 19:47:33 +0000 (19:47 +0000)]
Merge "Update CREDITS"
jenkins-bot [Thu, 3 Jan 2013 18:39:39 +0000 (18:39 +0000)]
Merge "(bug 43116) Don't run database updates for shared tables unless --doshared is provided"
Alexandre Emsenhuber [Thu, 3 Jan 2013 10:53:41 +0000 (11:53 +0100)]
Block::parseTarget() accepts and can return null
Documentation currently omits this.
Change-Id: I183121e5134c1bbd53a613780d171b52737f071d
Niklas Laxström [Wed, 2 Jan 2013 17:06:23 +0000 (17:06 +0000)]
Add test for substitution of params with multiple digits
Change-Id: I293bcdeecd5ee83cf05887aa06dc86b5589398eb
Kaldari [Thu, 3 Jan 2013 01:56:51 +0000 (01:56 +0000)]
Merge "Add new hook LinksUpdateAfterInsert to LinksUpdate"
jenkins-bot [Thu, 3 Jan 2013 01:37:38 +0000 (01:37 +0000)]
Merge "Use Html::rawElement() instead of hardcoded string in Special:Contributions"
jenkins-bot [Thu, 3 Jan 2013 01:35:54 +0000 (01:35 +0000)]
Merge "(bug 42915) make MovePage aware of whether redirects are supported."
jenkins-bot [Thu, 3 Jan 2013 01:27:06 +0000 (01:27 +0000)]
Merge "Follow-up I9c7aa3b2 (
b28c7a8): fix one more validation error"
IAlex [Wed, 2 Jan 2013 22:02:42 +0000 (22:02 +0000)]
Merge "[FileBackend] Improved some header related docs."
IAlex [Wed, 2 Jan 2013 22:00:15 +0000 (22:00 +0000)]
Merge "[JobQueue] Clarified documentation a bit."
IAlex [Wed, 2 Jan 2013 21:45:19 +0000 (21:45 +0000)]
Merge "Pass $user from WikiPage::getContent to Revision::getContent"
jenkins-bot [Wed, 2 Jan 2013 21:38:58 +0000 (21:38 +0000)]
Merge "Cleaned up and optimized wfBaseConvert();"
bsitu [Mon, 31 Dec 2012 22:30:32 +0000 (14:30 -0800)]
Add new hook LinksUpdateAfterInsert to LinksUpdate
This will allow extensions to do some work based on the links inserted
Change-Id: Ia522de65ff17e28c6a8cd9997cf6225100fefc9e
Translation updater bot [Wed, 2 Jan 2013 20:39:32 +0000 (20:39 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I74352251601ed9c9fbc16dbf7b51ae168631722f
Aaron Schulz [Wed, 2 Jan 2013 20:12:59 +0000 (12:12 -0800)]
[JobQueue] Clarified documentation a bit.
Change-Id: I065efd6b41a42d2d39b034c3488d2f00c27d7ac5
umherirrender [Wed, 2 Jan 2013 19:22:58 +0000 (20:22 +0100)]
Pass $user from WikiPage::getContent to Revision::getContent
Change-Id: If909ad6049869e2bf38789bd429f08dc3a264cae
Brad Jorsch [Wed, 2 Jan 2013 18:36:43 +0000 (13:36 -0500)]
Add release note for I1a3c7ac6
Change-Id: I9aee1a7e65ab0e235cc7c79fbecf5a0b458b0275
jenkins-bot [Wed, 2 Jan 2013 17:21:19 +0000 (17:21 +0000)]
Merge "(bug 43315) Cursor of enhancedchangelist wrong for non-toggle lines"
Alexandre Emsenhuber [Wed, 2 Jan 2013 13:52:02 +0000 (14:52 +0100)]
Fix Sqlite upgrade test when profiling to database is enabled
The 'profiling' table is missing from expected tables when
$wgProfileToDatabase is set to true, since patch-profiling.sql
is applied while updating in this case.
Change-Id: Iedbe72dca1deda728304fb95fe19ef3b4bdad8de
Alexandre Emsenhuber [Tue, 1 Jan 2013 21:13:30 +0000 (22:13 +0100)]
Don't use isset() to check whether an existing variable is null
Change-Id: I7b4207e91b6fa33ba31b1308f5e71f923def687e
Translation updater bot [Tue, 1 Jan 2013 20:04:18 +0000 (20:04 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I0a954d32095fc9562dd97301a7985dd64d262e78
Alexandre Emsenhuber [Tue, 1 Jan 2013 17:44:10 +0000 (18:44 +0100)]
Set $mLoadedItems to true in User::loadFromId()
CentralAuth calls User::loadFromId() directly after calling setId().
This avoid having to load the object two times in this case.
Change-Id: Iade37631a9346dff45e18acfa078af37c1fbbfab
Dereckson [Tue, 1 Jan 2013 16:44:02 +0000 (17:44 +0100)]
Fixing find hooks script call error in docs/hooks.txt
- maintenance/findhooks.php -> maintenance/findHooks.php
- ./maintenance/... -> php maintenance/... (*)
* Our maintenance files aren't released as executable, so this kind of
instruction could be confusing for UNIX system administration novices.
Change-Id: I5e1e76c46b3a8a4c7168c0b5715ede648044bd44
Translation updater bot [Mon, 31 Dec 2012 20:05:45 +0000 (20:05 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I40c4740df64cf5454f8680f792d9847fa179c2ad
jenkins-bot [Mon, 31 Dec 2012 18:16:45 +0000 (18:16 +0000)]
Merge "use video/webm instead of audio/webm for webm"
jenkins-bot [Mon, 31 Dec 2012 17:46:30 +0000 (17:46 +0000)]
Merge "(bug 40340) Fix cache issues with changing user groups"
jenkins-bot [Mon, 31 Dec 2012 16:14:59 +0000 (16:14 +0000)]
Merge "(bug 34876) improve $.makeCollapsible performance on the initial collapsing"
freakolowsky [Mon, 31 Dec 2012 14:12:11 +0000 (15:12 +0100)]
* Oracle Schema update to latest
* fixed makeSelectOptions (bug 43533)
Change-Id: Ib146a5073de18f2b20a22f34bd60222b230c9514
umherirrender [Mon, 31 Dec 2012 12:23:20 +0000 (13:23 +0100)]
Wrong namespace in BackupDumperPageTest::testFullTextPlain
The problem here is, that title objects are created before wgContLang is
changed, so the title can contains wrong namespace names.
1) BackupDumperPageTest::testFullTextPlain
Text of node title
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Diskussion:BackupDumperTestP1'
+'Talk:BackupDumperTestP1'
Change-Id: I975c0f6ae7e6f51b038fe41edda2f54cd8c97eb6
umherirrender [Mon, 31 Dec 2012 12:54:06 +0000 (13:54 +0100)]
Add some missing parent::tearDown()
Change-Id: Ibcdf5d440043cef25b4aa9fb08b61ec4a2c558d1
Translation updater bot [Sun, 30 Dec 2012 19:03:03 +0000 (19:03 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ic569ea4b8d4d716bd5310134de8305f5e52048b5
jenkins-bot [Sun, 30 Dec 2012 09:34:04 +0000 (09:34 +0000)]
Merge "Add LanguageZh_hans::formatDuration() for Chinese."
btongminh [Sat, 29 Dec 2012 20:39:54 +0000 (21:39 +0100)]
wfMerge() now works if $wgDiff3 contains spaces
Change-Id: Ia18012ee87fe45e292cf08542f5b0680d0b85371
Translation updater bot [Sat, 29 Dec 2012 19:56:11 +0000 (19:56 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Sat, 29 Dec 2012 19:34:18 +0000 (19:34 +0000)]
Merge "Correct isset() and associated checks in Revision::__construct()"
Translation updater bot [Sat, 29 Dec 2012 19:24:47 +0000 (19:24 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ib9a9723b78d650f64fe030afbfeadde050259829
IAlex [Sat, 29 Dec 2012 19:18:05 +0000 (19:18 +0000)]
Merge "Do correct average year length arithmetic."
Alexandre Emsenhuber [Sat, 29 Dec 2012 15:47:22 +0000 (16:47 +0100)]
Use Html::rawElement() instead of hardcoded string in Special:Contributions
Since there is generally no classes in the list items, this avoids having a
lot of useless class="" in the output.
Change-Id: I804af2269def1f06d023145c9ced6f1afa0d0c71
Liangent [Sat, 29 Dec 2012 14:07:21 +0000 (22:07 +0800)]
Do correct average year length arithmetic.
We have ( 24 * 3 + 25 ) leap years in total every 400 years in the
Gregorian calendar.
Change-Id: I2ad9036473afa914ecf8ddcf99ce27e316178f76
Brian Wolff [Thu, 27 Dec 2012 07:28:17 +0000 (03:28 -0400)]
(bug 39062) Show revs without rev_parent_id in Special:Contributions.
This is a follow-up to Ifd63cdf1 (
c8e0ec3f)
Currently if rev_parent_id is not populated on a row we just
output an empty bullet - <li class=""></li>. (Which can
happen if an update is performed properly. There are (were?) some
examples of this on en wikipedia. I was just talking to a user
who had some of his revisions not be populated for that field,
so it can happen.) Heck there's even code that checks for this
case inside the if statement (before this commit) that stops
non rev_parent_id rows from being processed.
This seems very very wrong to me. Change the check for if a revision
is valid to look for rev_id (which is the primary key, so
going to be there, and always has been there).
Also in the
case we don't have a valid revision and can't format it
(For example, an ext made a hook that added random rows
to the Special:Contribs query, but forgot to format some),
instead of outputting an empty bullet, output just an
html comment, (and a debug log entry).
Thank you to Isarra for reporting this issue.
Change-Id: I7ef562d6e829877dd8ea4ffb1e7e04b46c943ec1
jenkins-bot [Fri, 28 Dec 2012 22:00:34 +0000 (22:00 +0000)]
Merge "API list=alltransclusions, rm unique+gen & continue restrict"
Translation updater bot [Fri, 28 Dec 2012 21:01:40 +0000 (21:01 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Icf200b83397e2d0c7d01269a063d23759c397b95
Yuri Astrakhan [Fri, 28 Dec 2012 18:46:11 +0000 (13:46 -0500)]
API list=alltransclusions, rm unique+gen & continue restrict
* list=alltransclusions added to enumerate every instance of page embedding
* list=alllinks & alltransclusions now allow both 'from' and 'continue' in
the same query. When both are present, 'from' is simply ignored.
* list=alllinks & alltransclusions now allow 'unique' in generators, to yield
a list of all link/template target pages instead of source pages.
Change-Id: I4137e2d790f988e0cef638703d9d6961a47fe662
Timo Tijhof [Fri, 28 Dec 2012 17:26:48 +0000 (17:26 +0000)]
Merge "ApiOptionsTest: Group medium (takes more than 2 seconds)."
Timo Tijhof [Fri, 28 Dec 2012 17:23:02 +0000 (18:23 +0100)]
ApiOptionsTest: Group medium (takes more than 2 seconds).
Various jobs are failing in Jenkins due to this test exceeding
the maximum execution time of 2 seconds.
https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-api/684/console
Follows-up
13f0f58,
fb7c95f.
Change-Id: I41a9a571a50e538de514586618d58438c5dd6148
umherirrender [Thu, 27 Dec 2012 19:17:50 +0000 (20:17 +0100)]
(bug 41733) Hide usermessage element from printable view.
Change-Id: Iefa8158d28c8a78f21ad8155eba11d4870573b59
Jan Gerber [Fri, 28 Dec 2012 16:02:36 +0000 (16:02 +0000)]
use video/webm instead of audio/webm for webm
StreamFile::contentTypeFromPath via MimeMagic::guessTypesForExtension
returns the first mime type for a given extension listed in
includes/mime.types. This is used to set the mime type of files in
SWIFT. While audio/webm is a valid mime type for .webm files,
we only have videos with .webm right now. moving video/webm
up to make it the default mime type.
This fixes issues with players that will only show a video if
type is video/webm: Bug 43476
Change-Id: Ib4868995a9b2f474e656ecc4b23a18201fbeb572
Timo Tijhof [Wed, 19 Sep 2012 00:24:35 +0000 (02:24 +0200)]
(bug 40340) Fix cache issues with changing user groups
* migrateUserGroup.php: Call User::invalidateCache
* While at it, also fix the issue where User::clearInstanceCache
did not clear cache for User::getGroups.
Although it does clear the caches of methods used to calculate
other group-related lists (such as User::getEffectiveGroups),
the one for the query from user_groups was still cached in
$this->mGroups.
Presumably this was forgotten when this pattern was introduced
as the instance cache precedes the user_group table.
Change-Id: I22abdba00f8ccf587a3d7696e57970ed4653afc8
Siebrand Mazeland [Thu, 27 Dec 2012 22:54:54 +0000 (23:54 +0100)]
Add plural support for protocols in 'linksearch-text'
Change-Id: I6b043b4b3f7bba585abe6bd44d29a300a35d697c
Alexandre Emsenhuber [Fri, 28 Dec 2012 12:03:06 +0000 (13:03 +0100)]
Correct isset() and associated checks in Revision::__construct()
isset() checks that the member is set *and* its value is not null,
so there's no point doing a second is_null() check.
This also fixes an E_NOTICE when rev_parent_id is not set since
is_null() was called on it after isset() returned false.
Change-Id: I07bf670236413436d23ee5d87d032608b25769ce
Brad Jorsch [Tue, 11 Dec 2012 14:12:08 +0000 (09:12 -0500)]
(bug 42949) API shouldn't assume all exceptions are MWException
Since I20525253, the exception-handling code in ApiMain has
inadvertently assumed that all thrown exceptions will be subclasses of
MWException. This change restores the check for MWException while
preserving the new check for not UsageException introduced in that
commit.
Change-Id: I5016143a07c871bae910e93b22fefe61a959780c
Tim Starling [Fri, 28 Dec 2012 06:47:46 +0000 (17:47 +1100)]
Multiple servers in one SqlBagOStuff
Added a multi-server feature to SqlBagOStuff.
Tests done:
* With both the "shard" and multi-server features enabled and
$wgAllDBsAreLocalhost, tested getMulti, set, incr, decr, keys,
garbageCollect, deleteAll. Tested wiki page views with
$wgMainCacheType set to such a cache.
* Tested connection errors.
* In the plain CACHE_DB configuration, tested wiki page views.
Change-Id: Ifba0d276ef724cc9b33f687bc0adae4637054328
Translation updater bot [Thu, 27 Dec 2012 20:56:20 +0000 (20:56 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I734196d547973e07c8b129523ce693c318c4ee1a
Alexandre Emsenhuber [Thu, 27 Dec 2012 18:49:41 +0000 (19:49 +0100)]
Follow-up I9c7aa3b2 (
b28c7a8): fix one more validation error
"size" attribute of <input> is not allowed when type is "file".
Change-Id: Id8291d2c2e2ddc3e0c462c0eaa3817634d088c6b
Matthew Flaschen [Thu, 27 Dec 2012 18:05:53 +0000 (13:05 -0500)]
Fix typo in ResourceLoaderFileModule.
Change-Id: Ia4460fb8bba7e08f235016fa8b59adf97e48a4d3
Alexandre Emsenhuber [Thu, 27 Dec 2012 17:37:40 +0000 (18:37 +0100)]
(bug 43116) Don't run database updates for shared tables unless --doshared is provided
Added DatabaseUpdater::doTable() to check whether updates should executed on the given table.
Change-Id: I83fd722b604f9bc8a834681d234a0d80964dedc5
umherirrender [Thu, 27 Dec 2012 16:26:24 +0000 (17:26 +0100)]
Fix some validation errors on Special:Import
Fixed errors are:
* Duplicate ID mw-import-table
* Duplicate ID mw-interwiki-rootpage
* The for attribute of the label element must refer to a form control
(2x)
Added also a id for another input element for easy user scripting
Change-Id: I9c7aa3b2af2d49cf3aed42a057ab13aa1275ee90
umherirrender [Thu, 27 Dec 2012 13:54:16 +0000 (14:54 +0100)]
Use NS_* constant for default namespace in api
Change-Id: Ic46e7fe1877c4067b1b6bbea71216c0cdf594cb2
IAlex [Thu, 27 Dec 2012 13:39:27 +0000 (13:39 +0000)]
Merge "allow OldChangesListRecentChangesLine hook to return false and omit line from RC"