Sam Reed [Sat, 15 Oct 2011 22:15:36 +0000 (22:15 +0000)]
Rudimentary hook benchmarks
Max Semenik [Sat, 15 Oct 2011 22:08:42 +0000 (22:08 +0000)]
Fix typo in r99914
Bryan Tong Minh [Sat, 15 Oct 2011 21:40:30 +0000 (21:40 +0000)]
Revert unrelated changes from r99916
Bryan Tong Minh [Sat, 15 Oct 2011 21:38:53 +0000 (21:38 +0000)]
Follow-up r99911: fix tests
Add NullRepo to autoloader
Max Semenik [Sat, 15 Oct 2011 21:06:34 +0000 (21:06 +0000)]
(bug 31674) Can't edit watchlist if it contains special pages
Brion Vibber [Sat, 15 Oct 2011 20:56:56 +0000 (20:56 +0000)]
Followup r79867: re-animate the spinner during Special:Upload's thumbnail init (was lost by drawing the spinner to a canvas).
Switched from an <img> on the pre-canvas code to mw-small-spinner class so the CSS can worry about the path. :)
Bryan Tong Minh [Sat, 15 Oct 2011 20:36:02 +0000 (20:36 +0000)]
Per bug 28135, disable $wgMaxImageArea check when transforming using a hook, and enable the check for non IM scalers.
Bryan Tong Minh [Sat, 15 Oct 2011 20:30:37 +0000 (20:30 +0000)]
Per r97671, add $wgEnableAutoRotation setting that can be used to explicitly disable auto-rotation.
Brion Vibber [Sat, 15 Oct 2011 20:21:52 +0000 (20:21 +0000)]
Followup r80375: let PreprocessorTest work on Preprocessor_Hash etc as well as Preprocessor_Dom
Using same technique as ApiExpandTemplates to serialize the object tree back to XML, rather than asking for the DOM implementation's internal XML return function.
Have to also perform normalization on the test cases, as they aren't normalized to what libxml2 serializes. :P
Note that there are 4 test failures currently with Preprocessor_Hash, as it makes a separate <equals> element around = which doesn't appear to be in Preprocessor_Dom's output.
Raimond Spekking [Sat, 15 Oct 2011 19:40:05 +0000 (19:40 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 15 Oct 2011 19:22:05 +0000 (19:22 +0000)]
Fix E_WARNING from r99863
Chad Horohoe [Sat, 15 Oct 2011 19:06:31 +0000 (19:06 +0000)]
Self revert r99899....I HATE YOU PHPUNIT YOU @#Q**#(#@(#@@#(!!!
Chad Horohoe [Sat, 15 Oct 2011 19:02:07 +0000 (19:02 +0000)]
Temporarily reverting r99863 to see if I can pin down test failures
Markus Glaser [Sat, 15 Oct 2011 18:14:25 +0000 (18:14 +0000)]
* restored category page (some references to Title object were missing)
Happy-melon [Sat, 15 Oct 2011 17:59:42 +0000 (17:59 +0000)]
(bug 31361) broken messages on Special:GlobalBlock.
Sam Reed [Sat, 15 Oct 2011 17:46:37 +0000 (17:46 +0000)]
Seems some base class refactoring has move mTitle
/www/w/includes/CategoryPage.php on line 59
-rakkaus/#mediawiki-i18n- [15-Oct-2011 17:23:57] PHP Fatal error: Call to a member function getNamespace() on a non-object in /www/w/includes/CategoryPage.php on line 59
Also changed return, as parent::view() doesn't return anything
Sam Reed [Sat, 15 Oct 2011 17:37:05 +0000 (17:37 +0000)]
Move CategoryViewer to it's own file
Aaron Schulz [Sat, 15 Oct 2011 17:07:53 +0000 (17:07 +0000)]
Refactored cleanupDeletedBatch() by splitting out the file usage check functions
Alexandre Emsenhuber [Sat, 15 Oct 2011 09:43:30 +0000 (09:43 +0000)]
Use local context instead of global variables
Alexandre Emsenhuber [Sat, 15 Oct 2011 09:32:03 +0000 (09:32 +0000)]
* Added Language::userDate(), Language::userTime() and Language::userTimeAndDate() as new versions of respectively Language::date(), Language::time() and Language::timeanddate(), which take a User object in the second parameter to get time correction and format instead of having to do this when calling the methods and not wanting to user $wgUser's parameters.
* Moved Language::userAdjust() near other related function
* Updated ENotif stuff to use that functions so that the date format is not taken from the sending user but the receiver
* Removed $PAGEEDITDATEANDTIME parameter, unsed and not present in impersonal notification
* Also fixed the debug line in UserMailer::send()
Alexandre Emsenhuber [Sat, 15 Oct 2011 09:11:29 +0000 (09:11 +0000)]
* Timezones are now recognised in user preferences when offset is different due to DST
Brion Vibber [Sat, 15 Oct 2011 02:23:22 +0000 (02:23 +0000)]
Followup to r99653 (bug 31643) -- reenable client-side thumbnailing of SVGs on Special:Upload, with workaround for Firefox 7 regression.
Upstream firefox bug for hang loading some SVGs via data URI: https://bugzilla.mozilla.org/show_bug.cgi?id=694165
A fix may land as soon as Firefox 8.
This rev works around the bug by using window.URL.createObjectURL() instead of loading a data URI via FileReader; the object URL loads more cleanly and doesn't have the same hanging bug.
Needs to be replicated to UploadWizard (or moved to a shared lib!), some other fixes coming so no rush.
Markus Glaser [Sat, 15 Oct 2011 01:33:19 +0000 (01:33 +0000)]
follow-up to r98020. Throw MWException on attempt to serialize database.
Sam Reed [Fri, 14 Oct 2011 21:19:25 +0000 (21:19 +0000)]
Update documentation, returns
Sam Reed [Fri, 14 Oct 2011 21:18:38 +0000 (21:18 +0000)]
Update some deprecated code
Documentation
Fix "/*" comments to "/**"
Flesh out some missing returns, change some return types
Raimond Spekking [Fri, 14 Oct 2011 20:06:14 +0000 (20:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Jeremy Postlethwaite [Fri, 14 Oct 2011 18:04:12 +0000 (18:04 +0000)]
Fixed spelling mistake in comments.
Alexandre Emsenhuber [Fri, 14 Oct 2011 16:01:48 +0000 (16:01 +0000)]
Per Siebrand, fix for r99678: use word-separator and parentheses messages
Alexandre Emsenhuber [Fri, 14 Oct 2011 14:57:06 +0000 (14:57 +0000)]
* Moved wfViewPrevNext() to Language::viewPrevNext() so that it can be used in the context and not always relying on $wgLang
* modified the parameters order in Language::viewPrevNext() in comparaison of wfViewPrevNext() and changed it to require a Title object and extra parameter to be passed as array
* Use more modern methods to genrate i18n and HTML
* Removed wfNumLink(), not used anymore, only referenced in a comment in MetavidWiki extension
* Inlinised wfShowingResults(); I don't see any reason why only this message should get its own function
* Replaced all calls to wfViewPrevNext() and wfShowingResults() in core
* Simply use OutputPage::addWikiMsg() to display 'specialpage-empty' message
* Moved wfSpecialList() near wfViewPrevNext() in GlobalFunction.php
Alexandre Emsenhuber [Fri, 14 Oct 2011 14:20:02 +0000 (14:20 +0000)]
In WantedQueryPage:
* Call Linker methods statically
* Use $this->msg() to simplify parameter formatting and escaping
* Link to Special:Whatlinkshere/Page instead of Special:Whatlinkshere?target=Page for consistency
Sam Reed [Fri, 14 Oct 2011 08:06:54 +0000 (08:06 +0000)]
Documentation
Trim trailing whitespace
Make returns return values where appropriate (ie other paths in the same method do)
Aaron Schulz [Thu, 13 Oct 2011 22:23:13 +0000 (22:23 +0000)]
(bug 31679) Fixed use of 'allowusertalk'
Raimond Spekking [Thu, 13 Oct 2011 19:52:53 +0000 (19:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Thu, 13 Oct 2011 18:44:26 +0000 (18:44 +0000)]
Documentation
Swap a lot of "@returns" to "@return"
Amir E. Aharoni [Thu, 13 Oct 2011 16:48:30 +0000 (16:48 +0000)]
Fixes bug 31496. Patch by Tomer A. I tested it by trying to upload a file with a very long name.
Sam Reed [Thu, 13 Oct 2011 16:40:22 +0000 (16:40 +0000)]
Followup r85756
Update code to use boolean, as it's not going to be null
Amir E. Aharoni [Thu, 13 Oct 2011 13:43:02 +0000 (13:43 +0000)]
Made the arrow point in the correct direction according to the user's language, which may be different from the wiki language.
Alexandre Emsenhuber [Thu, 13 Oct 2011 12:34:39 +0000 (12:34 +0000)]
Use same case for the setListoutput() call than the definition
Alexandre Emsenhuber [Thu, 13 Oct 2011 11:46:21 +0000 (11:46 +0000)]
Moved wfSpecialList() to Language::specialList() so that it can be used in the context of special pages instead of relying unconditionally of $wgLang. Updated all calls in core and added a @deprecated comment to wfSpecialList() but not a wfDeprecated() call since it's still used in SiteMatrix and StalePages extensions.
Brion Vibber [Wed, 12 Oct 2011 22:46:31 +0000 (22:46 +0000)]
Temporarily disable pre-upload SVG thumbnailing in Special:Upload and Special:UploadWizard; workaround for worst part so far of bug 31643: some SVG files hanging Firefox during pre-upload thumbnail generation.
It's possible that this isn't SVG-specific though; large JPEGs are so far known to take a couple seconds and still pause the browser UI, but some SVGs hang Firefox 7/8/9 indefinitely when loaded as a data URI.
Upstream Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=694165
Thomas Gries [Wed, 12 Oct 2011 21:39:32 +0000 (21:39 +0000)]
convenience function call addExtensionField was lacking the true parameter for the sqlPath. I added that
Raimond Spekking [Wed, 12 Oct 2011 20:32:07 +0000 (20:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Wed, 12 Oct 2011 15:42:42 +0000 (15:42 +0000)]
Removed unused method SpecialMergeHistory::getPageLink() that would throw an error because SpecialMergeHistory::userCan() does not exist
Alexandre Emsenhuber [Wed, 12 Oct 2011 15:09:04 +0000 (15:09 +0000)]
* Added User paremeter to Revision::userCan(), Revision::userCanBitfield(), LogEventsList::userCan(), LogEventsList::userCanBitfield(), File::userCan() and its subclasses so that they can check against any user instead of always $wgUser.
* Updated callers that have a context or may use another user than $wgUser
* Revision::getUser(), Revision::getUserText(), Revision::getComment() and Revision::getText() also have a User as parameter, but it will be used only when Revision::FOR_THIS_USER is passed in the first parameter
Brian Wolff [Wed, 12 Oct 2011 14:13:06 +0000 (14:13 +0000)]
(bug 31637) Do not extract tiff:Orientation from XMP data, since then it will be used to rotate images, which is kind of unexpected.
Most people only really expect the Exif data to be used for rotating images (if that), so its unexpected when the xmp property causes an image to be rotated. So disable extracting that property from XMP.
Niklas Laxström [Wed, 12 Oct 2011 13:05:25 +0000 (13:05 +0000)]
namespaceGenderAliases for gl
Ref: http://translatewiki.net/wiki/Thread:Support/Gender_in_namespace_names
Ping bug 31622
Amir E. Aharoni [Wed, 12 Oct 2011 09:17:44 +0000 (09:17 +0000)]
Gender updates.
Alexandre Emsenhuber [Wed, 12 Oct 2011 09:12:22 +0000 (09:12 +0000)]
* Use local context instead of global variables
* Fixed case of Language::timeanddate() call
Alexandre Emsenhuber [Wed, 12 Oct 2011 09:09:00 +0000 (09:09 +0000)]
Check for read only database after checking if the user is logged in, so that anonymous users accessing this page while the wiki is read only won't think this is a temporary error
Mark A. Hershberger [Tue, 11 Oct 2011 21:54:10 +0000 (21:54 +0000)]
Remove hardcoded commit statements for pg installer.
Sam Reed [Tue, 11 Oct 2011 21:34:53 +0000 (21:34 +0000)]
Bit more refactoring
Sam Reed [Tue, 11 Oct 2011 21:28:31 +0000 (21:28 +0000)]
Don't reinvent the wheel to do parameter existence checking
Stops running the code outside the class when there's no point attempting it
Mark A. Hershberger [Tue, 11 Oct 2011 21:24:00 +0000 (21:24 +0000)]
Fix cli install so that db user is created if needed.
Mark A. Hershberger [Tue, 11 Oct 2011 20:49:28 +0000 (20:49 +0000)]
Avoid warnings from PG about improper escaping.
See http://www.postgresql.org/docs/8.1/static/release-8-1.html
Raimond Spekking [Tue, 11 Oct 2011 19:57:27 +0000 (19:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Russ Nelson [Tue, 11 Oct 2011 19:49:29 +0000 (19:49 +0000)]
Some docs and a test for FileRepo::storeBatch()
Thomas Gries [Tue, 11 Oct 2011 18:33:35 +0000 (18:33 +0000)]
added 'key' in 'Dropping .. key' in dropIndex which was missing there
Sam Reed [Tue, 11 Oct 2011 18:30:50 +0000 (18:30 +0000)]
Fix comment blocks that start /* to /**
Thomas Gries [Tue, 11 Oct 2011 18:17:44 +0000 (18:17 +0000)]
self-revert back to protected functions addIndex and dropIndex as suggested in mediawiki.org/wiki/Special:Code/MediaWiki/99510#c24137
Thomas Gries [Tue, 11 Oct 2011 17:52:38 +0000 (17:52 +0000)]
chg protected to public function addIndex and dropIndex . This is i.a. needed for schema updating in OpenID extension in conformity with contemporary updater routines, see comments on rev97447
Alexandre Emsenhuber [Tue, 11 Oct 2011 15:50:01 +0000 (15:50 +0000)]
Make Skin::formatDebugHTML() work again since there is now usage memory
Roan Kattouw [Tue, 11 Oct 2011 15:45:27 +0000 (15:45 +0000)]
list=allusers was throwing fatals when invalid user names occurred in the database. Address this scenario gracefully
Brian Wolff [Tue, 11 Oct 2011 14:05:23 +0000 (14:05 +0000)]
(bug 31588, sort of) Jpeg metadata code wasn't handling padding bytes properly.
Per the spec, segments can have arbitrary runs of 0xFF's between segments that should be skipped.
Alexandre Emsenhuber [Tue, 11 Oct 2011 13:12:40 +0000 (13:12 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Alexandre Emsenhuber [Tue, 11 Oct 2011 13:00:17 +0000 (13:00 +0000)]
Fix usage example of Linker::specialLink()
Santhosh Thottingal [Tue, 11 Oct 2011 10:25:58 +0000 (10:25 +0000)]
Use dataProvider for the testIsValidUserName method. Followup r99466
Santhosh Thottingal [Tue, 11 Oct 2011 10:02:50 +0000 (10:02 +0000)]
Stylize.php changes
Santhosh Thottingal [Tue, 11 Oct 2011 09:17:36 +0000 (09:17 +0000)]
Testcases for isValidUserName method of User.php.
There are many cases this method will fail for non-latin languages,
but not added now since there are bugs reported on that already and results
a rewrite of the method as per UAX 31 standard.
Mark A. Hershberger [Tue, 11 Oct 2011 04:07:51 +0000 (04:07 +0000)]
moar w/s changes!
Sam Reed [Tue, 11 Oct 2011 03:57:53 +0000 (03:57 +0000)]
Add documentation
Add addExtensionField and addExtensionIndex utility functions
Mark A. Hershberger [Tue, 11 Oct 2011 03:49:40 +0000 (03:49 +0000)]
Feed my OCD
Mark A. Hershberger [Tue, 11 Oct 2011 03:24:21 +0000 (03:24 +0000)]
Remove duplicate bits from the optionmap
Thomas Gries [Tue, 11 Oct 2011 00:41:34 +0000 (00:41 +0000)]
updated the message text so that it now says Nothing to migrate...done.
Neil Kandalgaonkar [Mon, 10 Oct 2011 23:29:07 +0000 (23:29 +0000)]
ensure tests for mw.Uri work in non-browser environments
Neil Kandalgaonkar [Mon, 10 Oct 2011 23:15:16 +0000 (23:15 +0000)]
protocol-relative URLs for javascript. Could also be extended to relative urls of any kind -- now mw.Uri is just "relative" to the current URL
Raimond Spekking [Mon, 10 Oct 2011 21:36:52 +0000 (21:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Neil Kandalgaonkar [Mon, 10 Oct 2011 21:33:00 +0000 (21:33 +0000)]
ensured uri is scoped in a few tests
Jeroen De Dauw [Mon, 10 Oct 2011 21:05:02 +0000 (21:05 +0000)]
added shortcut method for commonly used method combination
Raimond Spekking [Mon, 10 Oct 2011 20:19:09 +0000 (20:19 +0000)]
Per r99404: message has translatable content now
Alexandre Emsenhuber [Mon, 10 Oct 2011 18:05:59 +0000 (18:05 +0000)]
* Factorise calls to getTitle() and getSkin()
* Use Linker::linkKnown() instead of link() where possible
* Escape some messages that are escaped in other usages
* Use Title::isSpecial() instead of checking that getPrefixedDBkey() is equals to $wgContLang->specialPage()
Max Semenik [Mon, 10 Oct 2011 17:41:22 +0000 (17:41 +0000)]
Unbreak sending emails using mailTargets() in safe_mode
Alexandre Emsenhuber [Mon, 10 Oct 2011 15:21:56 +0000 (15:21 +0000)]
Fixes for SkinLegacy::specialPagesList():
* Use XmlSelect, Html::rawElement() and Xml::submitButton() to make sure things are correctly escaped
* Get a Title object instead of using $wgContLang->specialPage()
* Redirect to index.php and changed the name of the <select> to title to use the common way instead of linking to redirect.php?wpDropDown=...
Daniel Friesen [Mon, 10 Oct 2011 14:56:09 +0000 (14:56 +0000)]
Include a talk link in the default user signature. This seams to be what most people expect, it's the most user friendly, and it's strange we don't include it by default.
Alexandre Emsenhuber [Mon, 10 Oct 2011 14:55:57 +0000 (14:55 +0000)]
Fixes for r99354:
* Restore call to $wgContLang
* Make CategoryViewer extend ContextSource
Also simplify things by using wfMessage() instead of wfMsg*() in some cases
Siebrand Mazeland [Mon, 10 Oct 2011 10:14:31 +0000 (10:14 +0000)]
Remove configuration specific "As an administrator" from 8 messages. Spotted by Der Umherirrende.
Santhosh Thottingal [Mon, 10 Oct 2011 04:13:38 +0000 (04:13 +0000)]
Language specific height correction for titles. Ref Bug 29405 and Bug 30809. Followup of r97788
Raimond Spekking [Sun, 9 Oct 2011 20:04:54 +0000 (20:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Daniel Friesen [Sun, 9 Oct 2011 19:54:12 +0000 (19:54 +0000)]
Followup r98212; Ensure that true is passed to all uses of SkinTemplateToolboxEnd where we use getToolbox while they haven't been migrated to use getSidebar.
Daniel Friesen [Sun, 9 Oct 2011 19:42:45 +0000 (19:42 +0000)]
Followup r98212; Hook documentation.
Daniel Friesen [Sun, 9 Oct 2011 19:39:54 +0000 (19:39 +0000)]
Fix up makeLinkItem and makeLink:
- Don't explicitly name attributes to use (fixes bug on language_links in 1.18)
- Allow makeLink to accept options specifying how to wrap links and text
John Du Hart [Sun, 9 Oct 2011 18:39:27 +0000 (18:39 +0000)]
Followup r99354, fix Fatal error
John Du Hart [Sun, 9 Oct 2011 16:00:50 +0000 (16:00 +0000)]
CategoryViewer now requires a Context
Derk-Jan Hartman [Sun, 9 Oct 2011 15:35:47 +0000 (15:35 +0000)]
Fix bug 31436.
The collection extension is not array based, which caused an extra seperator to be inserted,
but no content. This was broken in r82487 or before in the SkinLegacy rewrite.
Aaron Schulz [Sun, 9 Oct 2011 12:30:13 +0000 (12:30 +0000)]
FU r99323: spread blocks for edit/move attempts via the API (which uses these functions)
Alexandre Emsenhuber [Sun, 9 Oct 2011 11:43:06 +0000 (11:43 +0000)]
* Use the context when building the preferences form descriptor
* Pass the HTMLForm object to the submit callback so that it can have a context and also access to the form itself (see below). This makes Preferences::tryUISubmit() and Prefrences::tryFormSubmit() signatures incompatible. The only extension calling these is EditUser and I will fix in my next commit.
* Added two extension possibilites (for EditUser): PreferencesForm::getExtraSuccessRedirectParameters() to modify the URL parameters when redirecting after successful save and the fourthparameter to Prefrences::getFormObject() to be able to remove some items from the descriptor
* Pass the user being modified to the HTMLForm to use it to save the preferences instead of doing this unconditionally on $wgUser (to remove one hack in EditUser preferences)
Aaron Schulz [Sun, 9 Oct 2011 05:19:11 +0000 (05:19 +0000)]
Document return types
Brian Wolff [Sun, 9 Oct 2011 03:50:03 +0000 (03:50 +0000)]
(bug 31549; follow-up r83563) Do not include old-style from links in nav links on categories.
They can intefere with contradicting pageuntil links which breaks navigation in categories.
Not including release notes since tagging 1.18, and first public release that had bug was 1.18. However bug was present in 1.17wmf1
Aaron Schulz [Sat, 8 Oct 2011 20:22:53 +0000 (20:22 +0000)]
* Only spread blocks on page edit/move attempts via spreadAnyEditBlock(). We don't want to spread everytime the user's block status is checked as the user may just be viewing something rather than attempting to do anything. For example, if the 'edit' tab were changed to reflect block status, the autoblocks would trigger by a user just *looking* at the page. An example "in the wild" would be the UI checks in r93246.
* Made spreadBlock() protected, no outside callers.
Derk-Jan Hartman [Sat, 8 Oct 2011 19:28:10 +0000 (19:28 +0000)]
Check if there is a prexisting tfoot, before creating a new one.
Follow up to r98669, though this was a problem that also could surface without tfoot emulation.
John Du Hart [Sat, 8 Oct 2011 19:13:35 +0000 (19:13 +0000)]
Add a method to HTML for getting just the HTML (As opposed to passing it right to Output
Also, if a field is marked as required, it should still be checked to see if it's empty before going to the callback. Don't like that behavior? Don't mark it as required.