Fix r40194, which was obviously incorrect. There's no reason $sectionTitle should...

diff --git a/includes/Linker.php b/includes/Linker.php
index 3f8f802..cc02241 100644 (file)
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1219,13 +1219,10 @@ class Linker {
                        if ( $local ) {
                                $sectionTitle = Title::newFromText( '#' . $section );
                        } else {
-                               $sectionTitle = clone( $title );
-                               $sectionTitle->mFragment = $section;
+                               $sectionTitle = Title::makeTitleSafe( $title->getNamespace(), 
+                                       $title->getDBkey(), $section );
                        }
-                       # FIXME: $sectionTitle should probably always be valid at this
-                       # point, but in some scenarios it's not (bug 15351).  Is this cor-
-                       # rect?
-                       if( $title instanceof Title ) {
+                       if ( $sectionTitle ) {
                                $link = $this->link( $sectionTitle,
                                        wfMsgForContent( 'sectionlink' ), array(), array(),
                                        'noclasses' );