Allow '0' as an accesskey.

PHP weak typing strikes again!

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 2632c39..88a3236 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -289,6 +289,7 @@ The following extensions are migrated into MediaWiki 1.14:
   JavaScript is disabled.
 * (bug 4253) Recentchanges IRC messages no longer include title in diff URLs and
   the comment is trimmed if necessary to maintain proper message length.
+* Allow '0' to be an accesskey.
 
 === API changes in 1.14 ===
 

diff --git a/includes/Linker.php b/includes/Linker.php
index 8981947..ad41cb0 100644 (file)
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1719,7 +1719,7 @@ class Linker {
                }
 
                $accesskey = wfMsg( "accesskey-$name" );
-               if( $accesskey && $accesskey != '-' &&
+               if( $accesskey != '' && $accesskey != '-' &&
                !wfEmptyMsg( "accesskey-$name", $accesskey ) ) {
                        if( isset( $attribs['title'] ) ) {
                                $attribs['title'] .= " [$accesskey]";
@@ -1756,7 +1756,7 @@ class Linker {
 
                if( isset( $attribs['title'] ) && $options == 'withaccess' ) {
                        $accesskey = wfMsg( "accesskey-$name" );
-                       if( $accesskey && $accesskey != '-' &&
+                       if( $accesskey != '' && $accesskey != '-' &&
                        !wfEmptyMsg( "accesskey-$name", $accesskey ) ) {
                                $attribs['title'] .= " [$accesskey]";
                        }