Bug: T109544
Change-Id: I02dcfc7a10a74571232a898f1ef348f8dbc48b45
/** @var $formatter RCFeedFormatter */
$formatter = is_object( $feed['formatter'] ) ? $feed['formatter'] : new $feed['formatter']();
$line = $formatter->getLine( $feed, $this, $actionComment );
+ if ( !$line ) {
+ // T109544
+ // If a feed formatter returns null, this will otherwise cause an
+ // error in at least RedisPubSubFeedEngine.
+ // Not sure where/how this should best be handled.
+ continue;
+ }
$engine->send( $feed, $line );
}
* @param RecentChange $rc The RecentChange object showing what sort
* of event has taken place.
* @param string|null $actionComment
- * @return string The text to send.
+ * @return string|null The text to send. If the formatter returns null,
+ * the line will not be sent.
*/
public function getLine( array $feed, RecentChange $rc, $actionComment );
}