From d277a9ead0b1cb9a19bc5fc9ed0eb3c9dc12917e Mon Sep 17 00:00:00 2001 From: Marius Hoch Date: Thu, 27 Sep 2012 01:35:08 +0200 Subject: [PATCH] Link the credits in Special:Version in all languages Add the link to {{SERVER}}{{SCRIPTPATH}}/CREDITS in Special:Version in the code and not in the interface message, which is way more straightforward, makes the message easier and assures that the developers are credited no matter of the current interface language. The following languages need interface changes after this is merged: He, Ko, Bcl, Jv (the fact that this list is so short once again proves the point that the link isn't set in many languages). I'll take care of those. Change-Id: If12c4eb8453da40ede4b9768b2dacfaf838aa2ab --- includes/specials/SpecialVersion.php | 12 +++++++----- languages/messages/MessagesEn.php | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index fbc2c932f4..4e5b6bf5a3 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -83,7 +83,7 @@ class SpecialVersion extends SpecialPage { $ret = Xml::element( 'h2', array( 'id' => 'mw-version-license' ), wfMessage( 'version-license' )->text() ); // This text is always left-to-right. - $ret .= '
'; + $ret .= '
'; $ret .= "__NOTOC__ " . self::getCopyrightAndAuthorList() . "\n " . wfMessage( 'version-license-info' )->text(); @@ -109,7 +109,9 @@ class SpecialVersion extends SpecialPage { 'Roan Kattouw', 'Trevor Parscal', 'Bryan Tong Minh', 'Sam Reed', 'Victor Vasiliev', 'Rotem Liss', 'Platonides', 'Antoine Musso', 'Timo Tijhof', - wfMessage( 'version-poweredby-others' )->text() + '[{{SERVER}}{{SCRIPTPATH}}/CREDITS ' . + wfMessage( 'version-poweredby-others' )->text() . + ']' ); return wfMessage( 'version-poweredby-credits', date( 'Y' ), @@ -136,7 +138,7 @@ class SpecialVersion extends SpecialPage { wfRunHooks( 'SoftwareInfo', array( &$software ) ); $out = Xml::element( 'h2', array( 'id' => 'mw-version-software' ), wfMessage( 'version-software' )->text() ) . - Xml::openElement( 'table', array( 'class' => 'wikitable', 'id' => 'sv-software' ) ) . + Xml::openElement( 'table', array( 'class' => 'wikitable plainlinks', 'id' => 'sv-software' ) ) . " " . wfMessage( 'version-software-product' )->text() . " " . wfMessage( 'version-software-version' )->text() . " @@ -327,7 +329,7 @@ class SpecialVersion extends SpecialPage { wfRunHooks( 'SpecialVersionExtensionTypes', array( &$this, &$extensionTypes ) ); $out = Xml::element( 'h2', array( 'id' => 'mw-version-ext' ), $this->msg( 'version-extensions' )->text() ) . - Xml::openElement( 'table', array( 'class' => 'wikitable', 'id' => 'sv-ext' ) ); + Xml::openElement( 'table', array( 'class' => 'wikitable plainlinks', 'id' => 'sv-ext' ) ); // Make sure the 'other' type is set to an array. if ( !array_key_exists( 'other', $wgExtensionCredits ) ) { @@ -760,7 +762,7 @@ class SpecialVersion extends SpecialPage { ); $out = Html::element( 'h2', array( 'id' => 'mw-version-entrypoints' ), $this->msg( 'version-entrypoints' )->text() ) . - Html::openElement( 'table', array( 'class' => 'wikitable', 'id' => 'mw-version-entrypoints-table' ) ) . + Html::openElement( 'table', array( 'class' => 'wikitable plainlinks', 'id' => 'mw-version-entrypoints-table' ) ) . Html::openElement( 'tr' ) . Html::element( 'th', array(), $this->msg( 'version-entrypoints-header-entrypoint' )->text() ) . Html::element( 'th', array(), $this->msg( 'version-entrypoints-header-url' )->text() ) . diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php index 1ab27bf5d8..097199b293 100644 --- a/languages/messages/MessagesEn.php +++ b/languages/messages/MessagesEn.php @@ -4697,7 +4697,7 @@ You can also [[Special:EditWatchlist|use the standard editor]].', 'version-svn-revision' => '(r$2)', # only translate this message to other languages if you have to change it 'version-license' => 'License', 'version-poweredby-credits' => "This wiki is powered by '''[//www.mediawiki.org/ MediaWiki]''', copyright © 2001-$1 $2.", -'version-poweredby-others' => '[{{SERVER}}{{SCRIPTPATH}}/CREDITS others]', +'version-poweredby-others' => 'others', 'version-license-info' => 'MediaWiki is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. MediaWiki is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. -- 2.20.1