From c527accb75d060e0b1146eefd1e5a246aec68509 Mon Sep 17 00:00:00 2001 From: Rob Church Date: Wed, 5 Apr 2006 16:14:08 +0000 Subject: [PATCH] (bug 5458) Fix double-URL encoding in block log link in contribs and contribs link in block log --- includes/LogPage.php | 2 +- includes/SpecialContributions.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/LogPage.php b/includes/LogPage.php index 2e72ba0c72..432f719026 100644 --- a/includes/LogPage.php +++ b/includes/LogPage.php @@ -191,7 +191,7 @@ class LogPage { $titleLink = $title->getText(); } else { $titleLink = $skin->makeLinkObj( $title, $title->getText() ); - $titleLink .= ' (' . $skin->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Contributions/' . urlencode( $title->getDBkey() ) ), wfMsg( 'contribslink' ) ) . ')'; + $titleLink .= ' (' . $skin->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Contributions/' . $title->getDBkey() ), wfMsg( 'contribslink' ) ) . ')'; } break; default: diff --git a/includes/SpecialContributions.php b/includes/SpecialContributions.php index a676959a06..d13b30d87d 100644 --- a/includes/SpecialContributions.php +++ b/includes/SpecialContributions.php @@ -226,7 +226,7 @@ function wfSpecialContributions( $par = null ) { if( ( $id != 0 && $wgSysopUserBans ) || ( $id == 0 && User::isIP( $nt->getText() ) ) ) { # Block link if( $wgUser->isAllowed( 'block' ) ) - $tools[] = $sk->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Blockip/' . $nt->getPartialUrl() ), wfMsgHtml( 'blocklink' ) ); + $tools[] = $sk->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Blockip/' . $nt->getDBkey() ), wfMsgHtml( 'blocklink' ) ); # Block log link $tools[] = $sk->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Log' ), htmlspecialchars( LogPage::logName( 'block' ) ), 'type=block&page=' . $nt->getPrefixedUrl() ); } -- 2.20.1