From af946ac245e6385b8e83be3ebee394f09066d7bf Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 23 Sep 2016 16:55:44 -0700 Subject: [PATCH] Update wfEscapeShellArg() comments Change-Id: Ib62a51186aee0967ba4420054ee69b83dcae4d59 --- includes/GlobalFunctions.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index 6e8ce8f2c8..5fe4b4efea 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -2194,12 +2194,11 @@ function wfIniGetBool( $setting ) { } /** - * Windows-compatible version of escapeshellarg() - * Windows doesn't recognise single-quotes in the shell, but the escapeshellarg() - * function puts single quotes in regardless of OS. + * Version of escapeshellarg() that works better on Windows. * - * Also fixes the locale problems on Linux in PHP 5.2.6+ (bug backported to - * earlier distro releases of PHP) + * Originally, this fixed the incorrect use of single quotes on Windows + * (https://bugs.php.net/bug.php?id=26285) and the locale problems on Linux in + * PHP 5.2.6+ (bug backported to earlier distro releases of PHP). * * @param string ... strings to escape and glue together, or a single array of strings parameter * @return string -- 2.20.1