From 9d8ff9317eb53da5bfaa3fae499ad16dd8fe9f48 Mon Sep 17 00:00:00 2001 From: Andrew Garrett Date: Sun, 28 Nov 2010 03:21:16 +0000 Subject: [PATCH] Remove isValidPassword check from User::checkPassword. It is hugely annoying to suddenly have the system decide that your password is not strong enough and decide that, as a consequence, you are not allowed to log in anymore. Password strength checking should only be there for changing passwords, not using them! --- includes/User.php | 9 --------- 1 file changed, 9 deletions(-) diff --git a/includes/User.php b/includes/User.php index 6ab18f60d8..22a506bd00 100644 --- a/includes/User.php +++ b/includes/User.php @@ -2780,15 +2780,6 @@ class User { global $wgAuth; $this->load(); - // Even though we stop people from creating passwords that - // are shorter than this, doesn't mean people wont be able - // to. Certain authentication plugins do NOT want to save - // domain passwords in a mysql database, so we should - // check this (incase $wgAuth->strict() is false). - if( !$this->isValidPassword( $password ) ) { - return false; - } - if( $wgAuth->authenticate( $this->getName(), $password ) ) { return true; } elseif( $wgAuth->strict() ) { -- 2.20.1