From 8cef87f3e1b0effe5b4616c69f19383605c0e00e Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Mon, 27 Mar 2017 15:34:39 -0400 Subject: [PATCH] rcfilters: Avoid $.type() Followup to I9a0c5e40b813e075ec33eea882b625dc43a15df6 Replace $.type() with typeof or Array.isArray Change-Id: I4f0f717c345ab1279b626b158b0ed6ada056bbc1 --- resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index 14eabe2e04..7405baef3f 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -321,8 +321,8 @@ * @param {array|object|string} filters */ mw.rcfilters.Controller.prototype.trackHighlight = function ( action, filters ) { - filters = $.type( filters ) === 'string' ? { name: filters } : filters; - filters = $.type( filters ) === 'object' ? [ filters ] : filters; + filters = typeof filters === 'string' ? { name: filters } : filters; + filters = !Array.isArray( filters ) ? [ filters ] : filters; mw.track( 'event.ChangesListHighlights', { -- 2.20.1