From 6b1c0e2d4044d53be0faf858c32733728e97d6e1 Mon Sep 17 00:00:00 2001
From: Max Semenik <maxsem@users.mediawiki.org>
Date: Thu, 5 Aug 2010 20:11:44 +0000
Subject: [PATCH] Improvement for r70521: simplification, avoid iterating over
 an array. Thanks, thedj!

---
 skins/common/password.js | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/skins/common/password.js b/skins/common/password.js
index 990b270273..167e3d8ab6 100644
--- a/skins/common/password.js
+++ b/skins/common/password.js
@@ -31,15 +31,9 @@ function bruteForceComplexity( pwd ) {
 	if ( matches ) {
 		charClasses++;
 		
+		var s = matches.join( '' );
 		// poor man's isUpper() and isLower()
-		var i, lower = false, upper = false;
-		for ( i in matches ) {
-			var ch = matches[i];
-			upper |= ch != ch.toLowerCase();
-			lower |= ch != ch.toUpperCase();
-			if ( upper && lower ) break;
-		}
-		if ( upper && lower ) {
+		if ( s != s.toLowerCase() && s != s.toUpperCase() ) {
 			charClasses++;
 		}
 	}
-- 
2.20.1