From 5644334e2345da1920690a726d0907e4eaff17aa Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Tue, 27 Mar 2012 14:09:25 +0200 Subject: [PATCH] Improved the comment about Special:Contributions. It was prompted by an IRC discussion with SrikanthLogic, who found the comment hard to understand. Change-Id: Idd686257bc4d44f93e06b5645bdc1531bb2b4a2e --- includes/SkinTemplate.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php index d08b7eff75..511443f016 100644 --- a/includes/SkinTemplate.php +++ b/includes/SkinTemplate.php @@ -581,10 +581,12 @@ class SkinTemplate extends Skin { ); # We need to do an explicit check for Special:Contributions, as we - # have to match both the title, and the target (which could come - # from request values or be specified in "sub page" form. The plot + # have to match both the title, and the target, which could come + # from request values (Special:Contributions?target=Jimbo_Wales) + # or be specified in "sub page" form + # (Special:Contributions/Jimbo_Wales). The plot # thickens, because the Title object is altered for special pages, - # so doesn't contain the original alias-with-subpage. + # so it doesn't contain the original alias-with-subpage. $origTitle = Title::newFromText( $request->getText( 'title' ) ); if( $origTitle instanceof Title && $origTitle->isSpecialPage() ) { list( $spName, $spPar ) = SpecialPageFactory::resolveAlias( $origTitle->getText() ); -- 2.20.1