From 4d4716ce66af260bae44a087f889680d4a9f14fb Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sat, 24 Aug 2013 19:51:07 +0200 Subject: [PATCH] Do not show empty metadata section on svgs The SvgHandler does not output all metadata, that means the returned array can be empty. In this case return false to indicate that the metadata section should not be added on the image description page. Change-Id: I989154dbaaaafb2e924838c990e30a9ffe6842a9 --- includes/media/SVG.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/media/SVG.php b/includes/media/SVG.php index 28083a7fa2..4c055a5f07 100644 --- a/includes/media/SVG.php +++ b/includes/media/SVG.php @@ -348,6 +348,7 @@ class SvgHandler extends ImageHandler { 'description' => 'imagedescription', 'title' => 'objectname', ); + $showMeta = false; foreach ( $metadata as $name => $value ) { $tag = strtolower( $name ); if ( isset( $conversion[$tag] ) ) { @@ -356,6 +357,7 @@ class SvgHandler extends ImageHandler { // Do not output other metadata not in list continue; } + $showMeta = true; self::addMeta( $result, in_array( $tag, $visibleFields ) ? 'visible' : 'collapsed', 'exif', @@ -363,7 +365,7 @@ class SvgHandler extends ImageHandler { $value ); } - return $result; + return $showMeta ? $result : false; } -- 2.20.1