From 2754304fefa69b9b4cb894e674aa199bf55e3003 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 29 Mar 2012 16:31:39 -0700 Subject: [PATCH] Added user Id sanity check to setUsernameBitfields() for bug 34755. Change-Id: I44288d199d86045151f8184f7abaa3df886d9d99 --- includes/revisiondelete/RevisionDeleteUser.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/revisiondelete/RevisionDeleteUser.php b/includes/revisiondelete/RevisionDeleteUser.php index fe424efa30..0e965c8206 100644 --- a/includes/revisiondelete/RevisionDeleteUser.php +++ b/includes/revisiondelete/RevisionDeleteUser.php @@ -34,10 +34,10 @@ class RevisionDeleteUser { * @return bool */ private static function setUsernameBitfields( $name, $userId, $op, $dbw ) { - if( $op !== '|' && $op !== '&' ){ + if ( !$userId || ( $op !== '|' && $op !== '&' ) ) { return false; // sanity check } - if( !$dbw instanceof DatabaseBase ){ + if ( !$dbw instanceof DatabaseBase ) { $dbw = wfGetDB( DB_MASTER ); } -- 2.20.1