From 03be8f40f52f838fa95d18d4631070968cc2ce1e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sat, 20 Sep 2014 18:56:04 +0200 Subject: [PATCH] UserTest: Don't rely on the behavior of unknown user options They are not actually expected to be preserved, although they might be. Change-Id: I34e15f3d1e5b9b825e6fc14814c8e9a6ac151ce9 --- tests/phpunit/includes/UserTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/includes/UserTest.php b/tests/phpunit/includes/UserTest.php index 933fed08d0..5be1b96e1d 100644 --- a/tests/phpunit/includes/UserTest.php +++ b/tests/phpunit/includes/UserTest.php @@ -250,12 +250,12 @@ class UserTest extends MediaWikiTestCase { $user = User::newFromName( 'UnitTestUser' ); $user->addToDatabase(); - $user->setOption( 'someoption', 'test' ); + $user->setOption( 'userjs-someoption', 'test' ); $user->setOption( 'cols', 200 ); $user->saveSettings(); $user = User::newFromName( 'UnitTestUser' ); - $this->assertEquals( 'test', $user->getOption( 'someoption' ) ); + $this->assertEquals( 'test', $user->getOption( 'userjs-someoption' ) ); $this->assertEquals( 200, $user->getOption( 'cols' ) ); } @@ -266,9 +266,9 @@ class UserTest extends MediaWikiTestCase { */ public function testAnonOptions() { global $wgDefaultUserOptions; - $this->user->setOption( 'someoption', 'test' ); + $this->user->setOption( 'userjs-someoption', 'test' ); $this->assertEquals( $wgDefaultUserOptions['cols'], $this->user->getOption( 'cols' ) ); - $this->assertEquals( 'test', $this->user->getOption( 'someoption' ) ); + $this->assertEquals( 'test', $this->user->getOption( 'userjs-someoption' ) ); } /** -- 2.20.1