From: Platonides Date: Fri, 18 Feb 2011 23:44:18 +0000 (+0000) Subject: Follow up r63584. The change of resetArticleID() could have all kinds of X-Git-Tag: 1.31.0-rc.0~31912 X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=dae94d247265c139c1beb7cee9e3dc2e7ce62ef4;p=lhc%2Fweb%2Fwiklou.git Follow up r63584. The change of resetArticleID() could have all kinds of side effects, given that it stops lazy cache fillings. --- diff --git a/includes/Article.php b/includes/Article.php index 40a2c4f5c1..6504d3af49 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -1754,7 +1754,7 @@ class Article { if ( $affected ) { $newid = $dbw->insertId(); - $this->mTitle->resetArticleId( $newid ); + $this->mTitle->resetArticleID( $newid ); } wfProfileOut( __METHOD__ ); @@ -2271,6 +2271,8 @@ class Article { $revisionId = $revision->insertOn( $dbw ); $this->mTitle->resetArticleID( $newid ); + # Update the LinkCache. Resetting the Title ArticleID means it will rely on having that already cached (FIXME?) + LinkCache::singleton()->addGoodLinkObj( $newid, $this->mTitle, strlen( $text ), (bool)Title::newFromRedirect( $text ), $revisionId ); # Update the page record with revision data $this->updateRevisionOn( $dbw, $revision, 0 );