From: Bartosz DziewoƄski Date: Thu, 6 Aug 2015 09:16:37 +0000 (+0000) Subject: Revert "mediawiki.page.ready: When infusing, infuse by id, not by element" X-Git-Tag: 1.31.0-rc.0~10450 X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=c32e5fd58a5093d8ce6a5e1fa915bca084b81c00;p=lhc%2Fweb%2Fwiklou.git Revert "mediawiki.page.ready: When infusing, infuse by id, not by element" Infusing by element is better, since it avoids the document.getElementById() lookup and behaves better in case of duplicate ids (which is invalid HTML, but happens). This reverts commit 803d89173fc3a56871767663907785cb3eaf7aa5. Depends on I11fd1c7f2434f904b9ddc94b0903f8278e06f3a1 in OOjs UI. Bug: T105828 Change-Id: I8c1f5015229db7b8a391f324cfd96be4ac158041 --- diff --git a/resources/src/mediawiki.page/mediawiki.page.ready.js b/resources/src/mediawiki.page/mediawiki.page.ready.js index 70029a1fb9..8ec4cf0c67 100644 --- a/resources/src/mediawiki.page/mediawiki.page.ready.js +++ b/resources/src/mediawiki.page/mediawiki.page.ready.js @@ -64,7 +64,7 @@ if ( $nodes.length ) { mw.loader.using( 'mediawiki.widgets' ).done( function () { $nodes.each( function () { - OO.ui.infuse( this.id ); + OO.ui.infuse( this ); } ); } ); }