From: Sam Reed <reedy@users.mediawiki.org>
Date: Fri, 9 Apr 2010 20:02:29 +0000 (+0000)
Subject: Reuse created instance of UserrightsPage
X-Git-Tag: 1.31.0-rc.0~37191
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=bdac0911233f53855a3f4e84bb2e4a3b89479ae7;p=lhc%2Fweb%2Fwiklou.git

Reuse created instance of UserrightsPage
---

diff --git a/includes/api/ApiUserrights.php b/includes/api/ApiUserrights.php
index 25254d70a8..be6d76c2d0 100644
--- a/includes/api/ApiUserrights.php
+++ b/includes/api/ApiUserrights.php
@@ -40,8 +40,7 @@ class ApiUserrights extends ApiBase {
 		$params = $this->extractRequestParams();
 
 		// User already validated in call to getTokenSalt from Main
-		$form = new UserrightsPage;
-		$user = $form->fetchUser( $params['user'] );
+		$user = $this->mForm->fetchUser( $params['user'] );
 
 		$r['user'] = $user->getName();
 		list( $r['added'], $r['removed'] ) =
@@ -108,8 +107,8 @@ class ApiUserrights extends ApiBase {
 			$this->dieUsageMsg( array( 'missingparam', 'user' ) );
 		}
 
-		$form = new UserrightsPage;
-		$user = $form->fetchUser( $params['user'] );
+		$this->mForm = new UserrightsPage;
+		$user = $this->mForm->fetchUser( $params['user'] );
 		if ( $user instanceof WikiErrorMsg ) {
 			$this->dieUsageMsg( array_merge(
 				(array)$user->getMessageKey(), $user->getMessageArgs() ) );