From: VolkerE <volker.e@wikimedia.org>
Date: Wed, 6 Dec 2017 00:33:35 +0000 (+0000)
Subject: Revert "Support changing icon variants on hover"
X-Git-Tag: 1.31.0-rc.0~1277
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=9bb94b0ac81dbdb00fc5110b93f66fd9f7ee3569;p=lhc%2Fweb%2Fwiklou.git

Revert "Support changing icon variants on hover"

This reverts commit 46c62ff5f474c6fe7a409863058e81bb678229b2. After reconsidering menu item treatment under UI Standardization perspective, we don't need and shouldn't use such pattern.

Bug: T110051
Change-Id: I0e8b6035f516e6629010b4f18471445c8833156e
---

diff --git a/includes/resourceloader/ResourceLoaderOOUIImageModule.php b/includes/resourceloader/ResourceLoaderOOUIImageModule.php
index ee87d8d8e8..5c9e1d94ae 100644
--- a/includes/resourceloader/ResourceLoaderOOUIImageModule.php
+++ b/includes/resourceloader/ResourceLoaderOOUIImageModule.php
@@ -98,11 +98,8 @@ class ResourceLoaderOOUIImageModule extends ResourceLoaderImageModule {
 		// Extra selectors to allow using the same icons for old-style MediaWiki UI code
 		if ( substr( $module, 0, 5 ) === 'icons' ) {
 			$definition['selectorWithoutVariant'] = '.oo-ui-icon-{name}, .mw-ui-icon-{name}:before';
-			$definition['selectorWithVariant'] = '
-				.oo-ui-image-{variant}.oo-ui-icon-{name}, .mw-ui-icon-{name}-{variant}:before,
-				/* Hack for Flow, see T110051 */
-				.mw-ui-hovericon:hover .mw-ui-icon-{name}-{variant}-hover:before,
-				.mw-ui-hovericon.mw-ui-icon-{name}-{variant}-hover:hover:before';
+			$definition['selectorWithVariant'] = '.oo-ui-image-{variant}.oo-ui-icon-{name}, ' .
+				'.mw-ui-icon-{name}-{variant}:before';
 		}
 
 		// Fields from module definition silently override keys from JSON files