From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Thu, 7 Nov 2013 21:39:48 +0000 (+0100)
Subject: Declare visibility on class properties
X-Git-Tag: 1.31.0-rc.0~18238
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=3328266ed694fd6ff7fadd562d440c7079923bc4;p=lhc%2Fweb%2Fwiklou.git

Declare visibility on class properties

Set to protected, so they are accessible when subclassed. Grepped core and
a little over 600 extensions for usage. Only usage found in UploadBase.php
and no direct usage of class properties.

Change-Id: Icb3a43867670f140f05643379c7acad34c6518c1
---

diff --git a/includes/utils/ZipDirectoryReader.php b/includes/utils/ZipDirectoryReader.php
index 5d5e28b1bd..1419bbb332 100644
--- a/includes/utils/ZipDirectoryReader.php
+++ b/includes/utils/ZipDirectoryReader.php
@@ -93,27 +93,27 @@ class ZipDirectoryReader {
 	}
 
 	/** The file name */
-	var $fileName;
+	protected $fileName;
 
 	/** The opened file resource */
-	var $file;
+	protected $file;
 
 	/** The cached length of the file, or null if it has not been loaded yet. */
-	var $fileLength;
+	protected $fileLength;
 
 	/** A segmented cache of the file contents */
-	var $buffer;
+	protected $buffer;
 
 	/** The file data callback */
-	var $callback;
+	protected $callback;
 
 	/** The ZIP64 mode */
-	var $zip64 = false;
+	protected $zip64 = false;
 
 	/** Stored headers */
-	var $eocdr, $eocdr64, $eocdr64Locator;
+	protected $eocdr, $eocdr64, $eocdr64Locator;
 
-	var $data;
+	protected $data;
 
 	/** The "extra field" ID for ZIP64 central directory entries */
 	const ZIP64_EXTRA_HEADER = 0x0001;