(bug 10769) Database::update() should return boolean result

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index b97f3c6..5438287 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -342,6 +342,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   used in redirects (i.e. they now work)
 * (bug 8878) Changes to $dateFormats in German localization (removing unused,
   nonexistent formats, putting time after date)
+* (bug 10769) Database::update() should return boolean result
 
 == API changes since 1.10 ==
 

diff --git a/includes/Database.php b/includes/Database.php
index ebb4b25..e0969f2 100644 (file)
--- a/includes/Database.php
+++ b/includes/Database.php
@@ -1495,6 +1495,7 @@ class Database {
         *                       (for the log)
         * @param array  $options An array of UPDATE options, can be one or
         *                        more of IGNORE, LOW_PRIORITY
+        * @return bool
         */
        function update( $table, $values, $conds, $fname = 'Database::update', $options = array() ) {
                $table = $this->tableName( $table );
@@ -1503,7 +1504,7 @@ class Database {
                if ( $conds != '*' ) {
                        $sql .= " WHERE " . $this->makeList( $conds, LIST_AND );
                }
-               $this->query( $sql, $fname );
+               return $this->query( $sql, $fname );
        }
 
        /**